From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id CC200A09F0 for ; Tue, 15 Dec 2020 19:24:03 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 987BECA4E; Tue, 15 Dec 2020 19:24:02 +0100 (CET) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 34F2CA3; Tue, 15 Dec 2020 19:23:58 +0100 (CET) IronPort-SDR: CYTP9fxFsc1Pcp+56PxC6BDBTuZCsVCALnBTJ3xPBm8rieJjB1Nl081u4UMCVZRt62vwz+B+H4 PRO9pn13Tcdg== X-IronPort-AV: E=McAfee;i="6000,8403,9836"; a="154162032" X-IronPort-AV: E=Sophos;i="5.78,422,1599548400"; d="scan'208";a="154162032" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Dec 2020 10:23:55 -0800 IronPort-SDR: ZbRGa7NQT1+kP2gWB2hKirOoxRsi4mOSZEDRhR3uqCDS7UclGae3mA5dwS3L9bg+cd+rP5VIUm zLYrr7fm15gA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.78,422,1599548400"; d="scan'208";a="412082378" Received: from silpixa00400072.ir.intel.com ([10.237.222.213]) by orsmga001.jf.intel.com with ESMTP; 15 Dec 2020 10:23:54 -0800 From: Vladimir Medvedkin To: dev@dpdk.org Cc: arkadiuszx.kusztal@intel.com, john.griffin@intel.com, fiona.trahe@intel.com, deepak.k.jain@intel.com, stable@dpdk.org Date: Tue, 15 Dec 2020 18:23:51 +0000 Message-Id: <1608056631-400065-1-git-send-email-vladimir.medvedkin@intel.com> X-Mailer: git-send-email 2.7.4 Subject: [dpdk-stable] [PATCH] crypto/qat: fix possible access to an uninitialized variable X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" QAT_LOG() has access to the uninitialized variable "name" Fixes: 21792c443205 ("crypto/qat: add multi-process handling of driver ID") Cc: stable@dpdk.org Signed-off-by: Vladimir Medvedkin --- drivers/crypto/qat/qat_asym_pmd.c | 8 ++++---- drivers/crypto/qat/qat_sym_pmd.c | 8 ++++---- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/crypto/qat/qat_asym_pmd.c b/drivers/crypto/qat/qat_asym_pmd.c index ed8a2a5..a2c8aca 100644 --- a/drivers/crypto/qat/qat_asym_pmd.c +++ b/drivers/crypto/qat/qat_asym_pmd.c @@ -251,6 +251,10 @@ qat_asym_dev_create(struct qat_pci_device *qat_pci_dev, struct rte_cryptodev *cryptodev; struct qat_asym_dev_private *internals; + snprintf(name, RTE_CRYPTODEV_NAME_MAX_LEN, "%s_%s", + qat_pci_dev->name, "asym"); + QAT_LOG(DEBUG, "Creating QAT ASYM device %s\n", name); + if (rte_eal_process_type() == RTE_PROC_PRIMARY) { qat_pci_dev->qat_asym_driver_id = qat_asym_driver_id; @@ -264,10 +268,6 @@ qat_asym_dev_create(struct qat_pci_device *qat_pci_dev, } } - snprintf(name, RTE_CRYPTODEV_NAME_MAX_LEN, "%s_%s", - qat_pci_dev->name, "asym"); - QAT_LOG(DEBUG, "Creating QAT ASYM device %s\n", name); - /* Populate subset device to use in cryptodev device creation */ qat_dev_instance->asym_rte_dev.driver = &cryptodev_qat_asym_driver; qat_dev_instance->asym_rte_dev.numa_node = diff --git a/drivers/crypto/qat/qat_sym_pmd.c b/drivers/crypto/qat/qat_sym_pmd.c index 6da9512..93666fd 100644 --- a/drivers/crypto/qat/qat_sym_pmd.c +++ b/drivers/crypto/qat/qat_sym_pmd.c @@ -330,6 +330,10 @@ qat_sym_dev_create(struct qat_pci_device *qat_pci_dev, const struct rte_cryptodev_capabilities *capabilities; uint64_t capa_size; + snprintf(name, RTE_CRYPTODEV_NAME_MAX_LEN, "%s_%s", + qat_pci_dev->name, "sym"); + QAT_LOG(DEBUG, "Creating QAT SYM device %s", name); + /* * All processes must use same driver id so they can share sessions. * Store driver_id so we can validate that all processes have the same @@ -349,10 +353,6 @@ qat_sym_dev_create(struct qat_pci_device *qat_pci_dev, } } - snprintf(name, RTE_CRYPTODEV_NAME_MAX_LEN, "%s_%s", - qat_pci_dev->name, "sym"); - QAT_LOG(DEBUG, "Creating QAT SYM device %s", name); - /* Populate subset device to use in cryptodev device creation */ qat_dev_instance->sym_rte_dev.driver = &cryptodev_qat_sym_driver; qat_dev_instance->sym_rte_dev.numa_node = -- 2.7.4