From: Long Li <longli@linuxonhyperv.com>
To: stable@dpdk.org
Cc: abmarath@microsoft.com, Long Li <longli@microsoft.com>
Subject: [dpdk-stable] [PATCH 19.11] net/netvsc: disable external mbuf on Rx by default
Date: Wed, 16 Dec 2020 10:27:39 -0800 [thread overview]
Message-ID: <1608143259-28440-1-git-send-email-longli@linuxonhyperv.com> (raw)
From: Long Li <longli@microsoft.com>
[ upstream commit 096b31fc0d8c989cc455c35f4d1def24a4ed6dee ]
The upstream commit introduces a new driver parameter and disable the use
of external mbuf by default. The same can be done by defining a max value
for the RX threshold for external mbuf.
The use of external mbuf is disabled by default for two reasons:
1. Due to the limitation of the kernel UIO implementation, physical
address of this external buffer is not exposed to the user-mode. If
this mbuf is passed to another driver, the other driver is unable to
map this buffer to iova.
2. Some DPDK applications are not aware of external mbuf, and may bug
when they receive an mbuf with external buffer attached.
Signed-off-by: Long Li <longli@microsoft.com>
---
drivers/net/netvsc/hn_rxtx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/netvsc/hn_rxtx.c b/drivers/net/netvsc/hn_rxtx.c
index 19f00a0..d618c17 100644
--- a/drivers/net/netvsc/hn_rxtx.c
+++ b/drivers/net/netvsc/hn_rxtx.c
@@ -42,7 +42,7 @@
#define HN_TXD_CACHE_SIZE 32 /* per cpu tx_descriptor pool cache */
#define HN_TXCOPY_THRESHOLD 512
-#define HN_RXCOPY_THRESHOLD 256
+#define HN_RXCOPY_THRESHOLD UINT_MAX
#define HN_RXQ_EVENT_DEFAULT 2048
struct hn_rxinfo {
--
1.8.3.1
next reply other threads:[~2020-12-16 18:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-16 18:27 Long Li [this message]
2020-12-17 9:29 ` Luca Boccassi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1608143259-28440-1-git-send-email-longli@linuxonhyperv.com \
--to=longli@linuxonhyperv.com \
--cc=abmarath@microsoft.com \
--cc=longli@microsoft.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).