From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 60D88A034F for ; Mon, 22 Feb 2021 20:49:28 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4FEE622A2A1; Mon, 22 Feb 2021 20:49:28 +0100 (CET) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id 52A9F22A29D; Mon, 22 Feb 2021 20:49:25 +0100 (CET) IronPort-SDR: i/4aAjkgan6BaCnNq6JW/LHxUGtYqYdgGE2BEQQhRtY+EaSKn3bym8bLZ0WN+HhANO8SPWtKBY tJWDpBG2xIxA== X-IronPort-AV: E=McAfee;i="6000,8403,9903"; a="203977059" X-IronPort-AV: E=Sophos;i="5.81,198,1610438400"; d="scan'208";a="203977059" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Feb 2021 11:49:24 -0800 IronPort-SDR: kUJtfg+5U7ZAjqIGFnqhVIIve7xEadVWS+gw4kU+v1vWevAdqzEdfehLj7244iF4G0KQ8O39FQ M894lFHWLVYA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.81,198,1610438400"; d="scan'208";a="592782519" Received: from txasoft-yocto.an.intel.com ([10.123.72.192]) by fmsmga006.fm.intel.com with ESMTP; 22 Feb 2021 11:49:23 -0800 From: Timothy McDaniel To: jerinj@marvell.com Cc: mattias.ronnblom@ericsson.com, dev@dpdk.org, john.mcnamara@intel.com, harry.van.haaren@intel.com, timothy.mcdaniel@intel.com, stable@dpdk.org Date: Mon, 22 Feb 2021 13:49:07 -0600 Message-Id: <1614023347-5873-1-git-send-email-timothy.mcdaniel@intel.com> X-Mailer: git-send-email 1.7.10 Subject: [dpdk-stable] [PATCH] event/dlb: fix accessing uninitialized variables X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" This patch updates the PMD to initialize response fields prior to calling into the PF layer. Coverity issue: 366187, 366186, 366184, 366166, 366159, 366158, 366153, 366145, 366127, 366125, 366120 Fixes: 8bb077f44ef2 ("event/dlb: add port unlink and unlinks in progress") Fixes: 6a89b28f8163 ("event/dlb: add port link") Fixes: eb14a3421afd ("event/dlb: add eventdev start") Fixes: b94c709decbe ("event/dlb: add infos get and configure") Fixes: f7a9172f36b4 ("event/dlb: add queue setup") Cc: stable@dpdk.org Signed-off-by: Timothy McDaniel --- drivers/event/dlb/dlb.c | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/event/dlb/dlb.c b/drivers/event/dlb/dlb.c index 8b26d1d..18bd19c 100644 --- a/drivers/event/dlb/dlb.c +++ b/drivers/event/dlb/dlb.c @@ -382,7 +382,7 @@ struct process_local_port_data dlb_ldb_credit_pool_create(struct dlb_hw_dev *handle) { struct dlb_create_ldb_pool_args cfg; - struct dlb_cmd_response response; + struct dlb_cmd_response response = {0}; int ret; if (handle == NULL) @@ -414,7 +414,7 @@ struct process_local_port_data dlb_dir_credit_pool_create(struct dlb_hw_dev *handle) { struct dlb_create_dir_pool_args cfg; - struct dlb_cmd_response response; + struct dlb_cmd_response response = {0}; int ret; if (handle == NULL) @@ -447,7 +447,7 @@ struct process_local_port_data { int ret = 0; struct dlb_create_sched_domain_args *config_params; - struct dlb_cmd_response response; + struct dlb_cmd_response response = {0}; if (resources_asked == NULL) { DLB_LOG_ERR("dlb: dlb_create NULL parameter\n"); @@ -711,7 +711,7 @@ struct process_local_port_data uint16_t qm_qid) { struct dlb_unmap_qid_args cfg; - struct dlb_cmd_response response; + struct dlb_cmd_response response = {0}; int32_t ret; if (handle == NULL) @@ -841,7 +841,7 @@ struct process_local_port_data struct dlb_eventdev *dlb; struct dlb_hw_dev *handle; struct dlb_pending_port_unmaps_args cfg; - struct dlb_cmd_response response; + struct dlb_cmd_response response = {0}; int ret; RTE_SET_USED(dev); @@ -1253,7 +1253,7 @@ struct process_local_port_data { struct dlb_hw_dev *handle = &dlb->qm_instance; struct dlb_create_ldb_queue_args cfg; - struct dlb_cmd_response response; + struct dlb_cmd_response response = {0}; int32_t ret; uint32_t qm_qid; int sched_type = -1; @@ -1309,7 +1309,7 @@ struct process_local_port_data { struct dlb_hw_dev *handle = &dlb->qm_instance; struct dlb_get_sn_allocation_args cfg; - struct dlb_cmd_response response; + struct dlb_cmd_response response = {0}; int ret; cfg.group = group; @@ -1330,7 +1330,7 @@ struct process_local_port_data { struct dlb_hw_dev *handle = &dlb->qm_instance; struct dlb_set_sn_allocation_args cfg; - struct dlb_cmd_response response; + struct dlb_cmd_response response = {0}; int ret; cfg.num = num; @@ -1352,7 +1352,7 @@ struct process_local_port_data { struct dlb_hw_dev *handle = &dlb->qm_instance; struct dlb_get_sn_occupancy_args cfg; - struct dlb_cmd_response response; + struct dlb_cmd_response response = {0}; int ret; cfg.group = group; @@ -1893,7 +1893,7 @@ static int dlb_num_dir_queues_setup(struct dlb_eventdev *dlb) uint8_t priority) { struct dlb_map_qid_args cfg; - struct dlb_cmd_response response; + struct dlb_cmd_response response = {0}; int32_t ret; if (handle == NULL) @@ -2121,7 +2121,7 @@ static int dlb_num_dir_queues_setup(struct dlb_eventdev *dlb) struct dlb_eventdev *dlb = dlb_pmd_priv(dev); struct dlb_hw_dev *handle = &dlb->qm_instance; struct dlb_start_domain_args cfg; - struct dlb_cmd_response response; + struct dlb_cmd_response response = {0}; int ret, i; rte_spinlock_lock(&dlb->qm_instance.resource_lock); -- 1.7.10