From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 8CF344C96 for ; Thu, 20 Dec 2018 09:30:22 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 2081222072; Thu, 20 Dec 2018 03:30:22 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Thu, 20 Dec 2018 03:30:22 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=dium/vQA2PmtOJCRcVB+gtPuagULAMYP0Kr1Y2Vh4/o=; b=TOx/hhwW1Lec yTMqxdlatpmwPadJeOD72E+s17q7YF80KXbQxuQJBQ8hKvzqCF2/eFuOCtynPkkj pkOhuYoicbWZsYgBLsYqBv8eO5TU3V2tbhjaCRG/lgAWy3CXEkSf4bJVmi+W6q/q c1LV9Epiow0BtkIXVbKmuPwn9m4DQzg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=dium/vQA2PmtOJCRcVB+gtPuagULAMYP0Kr1Y2Vh4 /o=; b=f3AXisgimJrR6dn2eC80u55UovoD0GURc5B24/CsXiadScXZKJjmoM5up COjTI6ua5N1Ix5wFcO3FSY+NWQTBi4Q8+dGBCSt6QRqMHx/zg7jPixDC8rciFYrV WjtdzzOndn+1gisV/lIEDgwtkGkXyHRPpQkKd9NIner/yd6VajXzeaGX2kGioWTa 4GB2RHzJ61c8jR4E/9Fr6C1TrnmdOuUjhLGMg1yf2LGxweSFjx+ctTb4x+vdbG/z p5UcW9KFP5qNwTkyqbApShsGeY/soUad73ei2ClgRMBbBCc701XFMoQ9FEp+mGyV azc04WGymXp3Z2SRvctqDM9iYlULQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedtkedrudejvddgudduvdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfhuthenuceurghilhhouhhtmecu fedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephffvufffkf gjfhgggfgtsehtqhertddttdejnecuhfhrohhmpefvhhhomhgrshcuofhonhhjrghlohhn uceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecuffhomhgrihhnpeguphgukh drohhrghdpohhuthhlohhokhdrtghomhenucfkphepjeejrddufeegrddvtdefrddukeeg necurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvg htnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 3E2BC100E5; Thu, 20 Dec 2018 03:30:21 -0500 (EST) From: Thomas Monjalon To: Yongseok Koh Cc: dpdk stable Date: Thu, 20 Dec 2018 09:30:18 +0100 Message-ID: <1615645.aKPVszkVBu@xps> In-Reply-To: <940F7AC1-0337-4491-82A9-87870485A7D7@mellanox.com> References: <20181129231202.30436-1-yskoh@mellanox.com> <20181129231202.30436-74-yskoh@mellanox.com> <940F7AC1-0337-4491-82A9-87870485A7D7@mellanox.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-stable] patch 'kni: fix build on Linux < 3.14' has been queued to LTS release 17.11.5 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Dec 2018 08:30:22 -0000 Sorry, it was a mistake to forget Cc:stable for this patch. If 711859cd0d07 is backported, then you should take this patch. 20/12/2018 01:19, Yongseok Koh: > Hi, >=20 > This patch is being removed from stable/17.11 as it was mistakenly merged. > Patches having 'fix' keyword in the title were merged even though those d= on't > have "Cc: stable@dpdk.org" tag in the commit message. >=20 > If you think this patch is still needed for stable/17.11, please let me k= now. > Then I'll take it back. >=20 >=20 > Thanks, > Yongseok >=20 >=20 > > On Nov 29, 2018, at 3:11 PM, Yongseok Koh wrote: > >=20 > > Hi, > >=20 > > FYI, your patch has been queued to LTS release 17.11.5 > >=20 > > Note it hasn't been pushed to https://emea01.safelinks.protection.outlo= ok.com/?url=3Dhttp%3A%2F%2Fdpdk.org%2Fbrowse%2Fdpdk-stable&data=3D02%7C= 01%7Cyskoh%40mellanox.com%7C28c79ab8cfbd4df2f1ef08d65650721a%7Ca652971c7d2e= 4d9ba6a4d149256f461b%7C0%7C0%7C636791300840098396&sdata=3DXq8J5JtAZDXWR= EX5qjIyy3F41SDfguHeuhUGn7ueG6s%3D&reserved=3D0 yet. > > It will be pushed if I get no objections before 12/01/18. So please > > shout if anyone has objections. > >=20 > > Also note that after the patch there's a diff of the upstream commit vs= the patch applied > > to the branch. If the code is different (ie: not only metadata diffs), = due for example to > > a change in context or macro names, please double check it. > >=20 > > Thanks. > >=20 > > Yongseok > >=20 > > --- > > From 49fd11c7c909599fc08d6d937d71ccc0e2afda55 Mon Sep 17 00:00:00 2001 > > From: Thomas Monjalon > > Date: Fri, 26 Oct 2018 23:23:36 +0200 > > Subject: [PATCH] kni: fix build on Linux < 3.14 > > MIME-Version: 1.0 > > Content-Type: text/plain; charset=3DUTF-8 > > Content-Transfer-Encoding: 8bit > >=20 > > [ upstream commit c6c36fe28a7bfd8ca21784b2b8b62241f89de06e ] > >=20 > > The atomic functions smp_load_acquire() and smp_store_release() > > were introduced in Linux 3.14. Older kernels miss the functions: > >=20 > > kni_fifo.h:19:2: error: > > implicit declaration of function =E2=80=98smp_load_acquire=E2=80=99 > > kni_fifo.h:30:2: error: > > implicit declaration of function =E2=80=98smp_store_release=E2=80=99 > >=20 > > The fallback is to drop the atomic barrier, as it was before > > the commit below. > >=20 > > Fixes: 711859cd0d07 ("kni: fix kernel FIFO synchronization") > >=20 > > Signed-off-by: Thomas Monjalon > > --- > > lib/librte_eal/linuxapp/kni/kni_fifo.h | 8 ++++++++ > > 1 file changed, 8 insertions(+) > >=20 > > diff --git a/lib/librte_eal/linuxapp/kni/kni_fifo.h b/lib/librte_eal/li= nuxapp/kni/kni_fifo.h > > index e4edab9f3..26208ae44 100644 > > --- a/lib/librte_eal/linuxapp/kni/kni_fifo.h > > +++ b/lib/librte_eal/linuxapp/kni/kni_fifo.h > > @@ -27,6 +27,14 @@ > >=20 > > #include > >=20 > > +/* Skip some memory barriers on Linux < 3.14 */ > > +#ifndef smp_load_acquire > > +#define smp_load_acquire(a) (*(a)) > > +#endif > > +#ifndef smp_store_release > > +#define smp_store_release(a, b) *(a) =3D (b) > > +#endif > > + > > /** > > * Adds num elements into the fifo. Return the number actually written > > */ > > --=20 > > 2.11.0 > >=20 > > --- > > Diff of the applied patch vs upstream commit (please double-check if n= on-empty: > > --- > > --- - 2018-11-29 15:01:48.485261122 -0800 > > +++ 0074-kni-fix-build-on-Linux-3.14.patch 2018-11-29 15:01:45.19095800= 0 -0800 > > @@ -1,4 +1,4 @@ > > -From c6c36fe28a7bfd8ca21784b2b8b62241f89de06e Mon Sep 17 00:00:00 2001 > > +From 49fd11c7c909599fc08d6d937d71ccc0e2afda55 Mon Sep 17 00:00:00 2001 > > From: Thomas Monjalon > > Date: Fri, 26 Oct 2018 23:23:36 +0200 > > Subject: [PATCH] kni: fix build on Linux < 3.14 > > @@ -6,6 +6,8 @@ > > Content-Type: text/plain; charset=3DUTF-8 > > Content-Transfer-Encoding: 8bit > >=20 > > +[ upstream commit c6c36fe28a7bfd8ca21784b2b8b62241f89de06e ] > > + > > The atomic functions smp_load_acquire() and smp_store_release() > > were introduced in Linux 3.14. Older kernels miss the functions: > >=20 > > @@ -21,14 +23,14 @@ > >=20 > > Signed-off-by: Thomas Monjalon > > --- > > - kernel/linux/kni/kni_fifo.h | 8 ++++++++ > > + lib/librte_eal/linuxapp/kni/kni_fifo.h | 8 ++++++++ > > 1 file changed, 8 insertions(+) > >=20 > > -diff --git a/kernel/linux/kni/kni_fifo.h b/kernel/linux/kni/kni_fifo.h > > -index 2cb3a4a7b..3f4781c2e 100644 > > ---- a/kernel/linux/kni/kni_fifo.h > > -+++ b/kernel/linux/kni/kni_fifo.h > > -@@ -8,6 +8,14 @@ > > +diff --git a/lib/librte_eal/linuxapp/kni/kni_fifo.h b/lib/librte_eal/l= inuxapp/kni/kni_fifo.h > > +index e4edab9f3..26208ae44 100644 > > +--- a/lib/librte_eal/linuxapp/kni/kni_fifo.h > > ++++ b/lib/librte_eal/linuxapp/kni/kni_fifo.h > > +@@ -27,6 +27,14 @@ > >=20 > > #include > >=20 >=20 >=20