* [dpdk-stable] [PATCH v2 1/4] vhost: fix uninitialized vhost queue [not found] ` <1617368642-131298-1-git-send-email-jiayu.hu@intel.com> @ 2021-04-02 13:03 ` Jiayu Hu 2021-04-13 11:30 ` Maxime Coquelin [not found] ` <1618909066-114980-1-git-send-email-jiayu.hu@intel.com> 1 sibling, 1 reply; 6+ messages in thread From: Jiayu Hu @ 2021-04-02 13:03 UTC (permalink / raw) To: dev Cc: maxime.coquelin, chenbo.xia, yinan.wang, sunil.pai.g, cheng1.jiang, Jiayu Hu, stable This patch allocates vhost queue by rte_zmalloc() to avoid undefined values. Fixes: a277c7159876 ("vhost: refactor code structure") Cc: stable@dpdk.org Signed-off-by: Jiayu Hu <jiayu.hu@intel.com> --- lib/librte_vhost/vhost.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_vhost/vhost.c b/lib/librte_vhost/vhost.c index c9d1371..8657bbe 100644 --- a/lib/librte_vhost/vhost.c +++ b/lib/librte_vhost/vhost.c @@ -609,7 +609,7 @@ alloc_vring_queue(struct virtio_net *dev, uint32_t vring_idx) if (dev->virtqueue[i]) continue; - vq = rte_malloc(NULL, sizeof(struct vhost_virtqueue), 0); + vq = rte_zmalloc(NULL, sizeof(struct vhost_virtqueue), 0); if (vq == NULL) { VHOST_LOG_CONFIG(ERR, "Failed to allocate memory for vring:%u.\n", i); -- 2.7.4 ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-stable] [PATCH v2 1/4] vhost: fix uninitialized vhost queue 2021-04-02 13:03 ` [dpdk-stable] [PATCH v2 1/4] vhost: fix uninitialized vhost queue Jiayu Hu @ 2021-04-13 11:30 ` Maxime Coquelin 0 siblings, 0 replies; 6+ messages in thread From: Maxime Coquelin @ 2021-04-13 11:30 UTC (permalink / raw) To: Jiayu Hu, dev; +Cc: chenbo.xia, yinan.wang, sunil.pai.g, cheng1.jiang, stable On 4/2/21 3:03 PM, Jiayu Hu wrote: > This patch allocates vhost queue by rte_zmalloc() to avoid > undefined values. > > Fixes: a277c7159876 ("vhost: refactor code structure") > Cc: stable@dpdk.org > > Signed-off-by: Jiayu Hu <jiayu.hu@intel.com> > --- > lib/librte_vhost/vhost.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/librte_vhost/vhost.c b/lib/librte_vhost/vhost.c > index c9d1371..8657bbe 100644 > --- a/lib/librte_vhost/vhost.c > +++ b/lib/librte_vhost/vhost.c > @@ -609,7 +609,7 @@ alloc_vring_queue(struct virtio_net *dev, uint32_t vring_idx) > if (dev->virtqueue[i]) > continue; > > - vq = rte_malloc(NULL, sizeof(struct vhost_virtqueue), 0); > + vq = rte_zmalloc(NULL, sizeof(struct vhost_virtqueue), 0); > if (vq == NULL) { > VHOST_LOG_CONFIG(ERR, > "Failed to allocate memory for vring:%u.\n", i); > Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com> Thanks, Maxime ^ permalink raw reply [flat|nested] 6+ messages in thread
[parent not found: <1618909066-114980-1-git-send-email-jiayu.hu@intel.com>]
* [dpdk-stable] [PATCH v3 1/4] vhost: fix uninitialized vhost queue [not found] ` <1618909066-114980-1-git-send-email-jiayu.hu@intel.com> @ 2021-04-20 8:57 ` Jiayu Hu 2021-04-20 8:57 ` [dpdk-stable] [PATCH v3 3/4] vhost: fix unnecessary vring_state_changed call Jiayu Hu 1 sibling, 0 replies; 6+ messages in thread From: Jiayu Hu @ 2021-04-20 8:57 UTC (permalink / raw) To: dev Cc: maxime.coquelin, chenbo.xia, yinan.wang, sunil.pai.g, cheng1.jiang, jiayu.hu, stable This patch allocates vhost queue by rte_zmalloc() to avoid undefined values. Fixes: a277c7159876 ("vhost: refactor code structure") Cc: stable@dpdk.org Signed-off-by: Jiayu Hu <jiayu.hu@intel.com> Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com> Tested-by: Yinan Wang <yinan.wang@intel.com> --- lib/librte_vhost/vhost.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_vhost/vhost.c b/lib/librte_vhost/vhost.c index a70fe01..ea38cf2 100644 --- a/lib/librte_vhost/vhost.c +++ b/lib/librte_vhost/vhost.c @@ -608,7 +608,7 @@ alloc_vring_queue(struct virtio_net *dev, uint32_t vring_idx) if (dev->virtqueue[i]) continue; - vq = rte_malloc(NULL, sizeof(struct vhost_virtqueue), 0); + vq = rte_zmalloc(NULL, sizeof(struct vhost_virtqueue), 0); if (vq == NULL) { VHOST_LOG_CONFIG(ERR, "Failed to allocate memory for vring:%u.\n", i); -- 2.7.4 ^ permalink raw reply [flat|nested] 6+ messages in thread
* [dpdk-stable] [PATCH v3 3/4] vhost: fix unnecessary vring_state_changed call [not found] ` <1618909066-114980-1-git-send-email-jiayu.hu@intel.com> 2021-04-20 8:57 ` [dpdk-stable] [PATCH v3 " Jiayu Hu @ 2021-04-20 8:57 ` Jiayu Hu 2021-04-20 9:39 ` Maxime Coquelin 1 sibling, 1 reply; 6+ messages in thread From: Jiayu Hu @ 2021-04-20 8:57 UTC (permalink / raw) To: dev Cc: maxime.coquelin, chenbo.xia, yinan.wang, sunil.pai.g, cheng1.jiang, jiayu.hu, stable When VHOST_USER_F_PROTOCOL_FEATURES is not negotiated, there is no need for vhost_user_set_vring_kick() to notify the application of vring enabled, as vhost_user_msg_handler() also notifies the application. This patch is to remove unnecessary vring_state_changed() call. Fixes: 966027b4b3a3 ("vhost: fix silent queue enabling with legacy guests") Cc: stable@dpdk.org Signed-off-by: Jiayu Hu <jiayu.hu@intel.com> Tested-by: Yinan Wang <yinan.wang@intel.com> --- lib/librte_vhost/vhost_user.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/lib/librte_vhost/vhost_user.c b/lib/librte_vhost/vhost_user.c index fa8929f..611ff20 100644 --- a/lib/librte_vhost/vhost_user.c +++ b/lib/librte_vhost/vhost_user.c @@ -1922,9 +1922,6 @@ vhost_user_set_vring_kick(struct virtio_net **pdev, struct VhostUserMsg *msg, */ if (!(dev->features & (1ULL << VHOST_USER_F_PROTOCOL_FEATURES))) { vq->enabled = true; - if (dev->notify_ops->vring_state_changed) - dev->notify_ops->vring_state_changed( - dev->vid, file.index, 1); } if (vq->ready) { -- 2.7.4 ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-stable] [PATCH v3 3/4] vhost: fix unnecessary vring_state_changed call 2021-04-20 8:57 ` [dpdk-stable] [PATCH v3 3/4] vhost: fix unnecessary vring_state_changed call Jiayu Hu @ 2021-04-20 9:39 ` Maxime Coquelin 2021-04-21 1:36 ` Xia, Chenbo 0 siblings, 1 reply; 6+ messages in thread From: Maxime Coquelin @ 2021-04-20 9:39 UTC (permalink / raw) To: Jiayu Hu, dev, chenbo.xia; +Cc: yinan.wang, sunil.pai.g, cheng1.jiang, stable On 4/20/21 10:57 AM, Jiayu Hu wrote: > When VHOST_USER_F_PROTOCOL_FEATURES is not negotiated, > there is no need for vhost_user_set_vring_kick() to > notify the application of vring enabled, as > vhost_user_msg_handler() also notifies the application. > > This patch is to remove unnecessary vring_state_changed() call. > > Fixes: 966027b4b3a3 ("vhost: fix silent queue enabling with legacy guests") Sorry, I thought the vring_state_changed cb was introduced when Matan did the rework last year, but it is actually older. If we backport the patch on v19.11, we will create a regression as it will revert Ilya's patch. I think that your fix is correct only once Matan's series is present, so we should have below Fixes tag: Fixes: d0fcc38f5fa4 ("vhost: improve device readiness notifications") > Cc: stable@dpdk.org > > Signed-off-by: Jiayu Hu <jiayu.hu@intel.com> > Tested-by: Yinan Wang <yinan.wang@intel.com> > --- > lib/librte_vhost/vhost_user.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/lib/librte_vhost/vhost_user.c b/lib/librte_vhost/vhost_user.c > index fa8929f..611ff20 100644 > --- a/lib/librte_vhost/vhost_user.c > +++ b/lib/librte_vhost/vhost_user.c > @@ -1922,9 +1922,6 @@ vhost_user_set_vring_kick(struct virtio_net **pdev, struct VhostUserMsg *msg, > */ > if (!(dev->features & (1ULL << VHOST_USER_F_PROTOCOL_FEATURES))) { > vq->enabled = true; > - if (dev->notify_ops->vring_state_changed) > - dev->notify_ops->vring_state_changed( > - dev->vid, file.index, 1); > } > > if (vq->ready) { > With the fixes tag changed: Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com> Chanbo, can you change the Fixes tag while applying or Jiayu needs to send a new revision? Thanks, Maxime ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-stable] [PATCH v3 3/4] vhost: fix unnecessary vring_state_changed call 2021-04-20 9:39 ` Maxime Coquelin @ 2021-04-21 1:36 ` Xia, Chenbo 0 siblings, 0 replies; 6+ messages in thread From: Xia, Chenbo @ 2021-04-21 1:36 UTC (permalink / raw) To: Maxime Coquelin, Hu, Jiayu, dev Cc: Wang, Yinan, Pai G, Sunil, Jiang, Cheng1, stable Hi Maxime & Jiayu, > -----Original Message----- > From: Maxime Coquelin <maxime.coquelin@redhat.com> > Sent: Tuesday, April 20, 2021 5:40 PM > To: Hu, Jiayu <jiayu.hu@intel.com>; dev@dpdk.org; Xia, Chenbo > <chenbo.xia@intel.com> > Cc: Wang, Yinan <yinan.wang@intel.com>; Pai G, Sunil <sunil.pai.g@intel.com>; > Jiang, Cheng1 <cheng1.jiang@intel.com>; stable@dpdk.org > Subject: Re: [PATCH v3 3/4] vhost: fix unnecessary vring_state_changed call > > > > On 4/20/21 10:57 AM, Jiayu Hu wrote: > > When VHOST_USER_F_PROTOCOL_FEATURES is not negotiated, > > there is no need for vhost_user_set_vring_kick() to > > notify the application of vring enabled, as > > vhost_user_msg_handler() also notifies the application. > > > > This patch is to remove unnecessary vring_state_changed() call. > > > > Fixes: 966027b4b3a3 ("vhost: fix silent queue enabling with legacy guests") > > Sorry, I thought the vring_state_changed cb was introduced when Matan > did the rework last year, but it is actually older. > > If we backport the patch on v19.11, we will create a regression as it > will revert Ilya's patch. > > I think that your fix is correct only once Matan's series is present, so > we should have below Fixes tag: > > Fixes: d0fcc38f5fa4 ("vhost: improve device readiness notifications") > > > Cc: stable@dpdk.org > > > > Signed-off-by: Jiayu Hu <jiayu.hu@intel.com> > > Tested-by: Yinan Wang <yinan.wang@intel.com> > > --- > > lib/librte_vhost/vhost_user.c | 3 --- > > 1 file changed, 3 deletions(-) > > > > diff --git a/lib/librte_vhost/vhost_user.c b/lib/librte_vhost/vhost_user.c > > index fa8929f..611ff20 100644 > > --- a/lib/librte_vhost/vhost_user.c > > +++ b/lib/librte_vhost/vhost_user.c > > @@ -1922,9 +1922,6 @@ vhost_user_set_vring_kick(struct virtio_net **pdev, > struct VhostUserMsg *msg, > > */ > > if (!(dev->features & (1ULL << VHOST_USER_F_PROTOCOL_FEATURES))) { > > vq->enabled = true; > > - if (dev->notify_ops->vring_state_changed) > > - dev->notify_ops->vring_state_changed( > > - dev->vid, file.index, 1); > > } > > > > if (vq->ready) { > > > > With the fixes tag changed: > Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com> > > Chanbo, can you change the Fixes tag while applying or Jiayu needs to > send a new revision? No worry. Will change fix tag while applying. Thanks! Chenbo > > Thanks, > Maxime ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-04-21 1:36 UTC | newest] Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- [not found] <1615985773-406787-1-git-send-email-jiayu.hu@intel.com> [not found] ` <1617368642-131298-1-git-send-email-jiayu.hu@intel.com> 2021-04-02 13:03 ` [dpdk-stable] [PATCH v2 1/4] vhost: fix uninitialized vhost queue Jiayu Hu 2021-04-13 11:30 ` Maxime Coquelin [not found] ` <1618909066-114980-1-git-send-email-jiayu.hu@intel.com> 2021-04-20 8:57 ` [dpdk-stable] [PATCH v3 " Jiayu Hu 2021-04-20 8:57 ` [dpdk-stable] [PATCH v3 3/4] vhost: fix unnecessary vring_state_changed call Jiayu Hu 2021-04-20 9:39 ` Maxime Coquelin 2021-04-21 1:36 ` Xia, Chenbo
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).