From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 26A0D1B5B3; Wed, 19 Dec 2018 21:28:51 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 99CD721BC4; Wed, 19 Dec 2018 15:28:50 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Wed, 19 Dec 2018 15:28:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=EsP18Vyx7zs/GzT6z2M2EMBi6RubisiNsUM73jMo5/A=; b=md2yYFdo24fi NiJQl2wxT80oq6z0m1nB8SFK+eVB9XhtCibCPAjLmy18OkOoYtlReo2WJEKwBY3e cZ8ipWPJrelvaovsNEz1QmNuig//t6TgfNYkr26s2SFCdJMZlq7547TtHphl7u9G QHwhBzGSx1bBeT30GGUMe5ZRMBrCfhw= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=EsP18Vyx7zs/GzT6z2M2EMBi6RubisiNsUM73jMo5 /A=; b=d61Dxc7iFPRxvuQcF3o4CDTSVPobcz9bRRyyY3O0qFn6eTwE15kBK9JyH vu4ZwrdGw6TvxSmg/ChiHKsge9xzZgFqKRfZCnsDsCVltNqwfPjWKV8U10MRQlW4 3ARFYlTr6j4IKcitJkwZ1yfGstpUJhjooNzEKyPhY5RAs9NxaELey/0+Ld6qpQs5 mIzyIhAV3nc6E7o2aN/2xr5rztCXRdwh8LabWsEGVhbdadj7S4gcNP9Vt1cLYiYC bGdM7qVBi0p1Na6PogWbywQVcyTPok1MXNghfY/q53POrnYWQQaZhVowJ890xcT2 4APJ7XYI1pghhORWYeYmhIxqTuqzw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedtkedrudejtddgudefkecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfhuthenuceurghilhhouhhtmecu fedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephffvufffkf gjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgrshcuofhonhhjrghlohhn uceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukfhppeejjedrudefgedrvd dtfedrudekgeenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgr lhhonhdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 092AF100BA; Wed, 19 Dec 2018 15:28:48 -0500 (EST) From: Thomas Monjalon To: Ferruh Yigit Cc: dev@dpdk.org, stable@dpdk.org, Tom Barbette , Yongseok Koh , Konstantin Ananyev , Bruce Richardson Date: Wed, 19 Dec 2018 21:28:48 +0100 Message-ID: <1618982.fK5yx7iQXf@xps> In-Reply-To: <0ee900c3-57eb-9c89-0b0f-7f724c095d6b@intel.com> References: <20181219192904.61934-1-ferruh.yigit@intel.com> <1772993.ZpFq8iN2Ki@xps> <0ee900c3-57eb-9c89-0b0f-7f724c095d6b@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-stable] [PATCH] mk: fix scope of disabling AVX512F support X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Dec 2018 20:28:51 -0000 19/12/2018 21:20, Ferruh Yigit: > On 12/19/2018 7:58 PM, Thomas Monjalon wrote: > > 19/12/2018 20:29, Ferruh Yigit: > >> AVX512 was disabled for GCC because of Bugzilla issue 97 [1], > >> the GCC defect submitted for the issue [2] highlighted that this is > >> a known binutils version 2.30 issue. > >> > >> Narrowed the scope of no-avx512 to the this specific binutils version. > > [...] > >> # disable AVX512F support of gcc as a workaround for Bug 97 > >> ifeq ($(CONFIG_RTE_TOOLCHAIN_GCC),y) > >> +ifneq ($(filter 2.30%,$(LD_VERSION)),) > >> MACHINE_CFLAGS += -mno-avx512f > > > > I think we should print a warning here. > > There is a function $(warning) or $(info) for such case. > > I can add but it prints warning per component, so it prints a lot. I think we can choose to print only when compiling EAL by checking $(findstring eal,$(lastword $(MAKEFILE_LIST))) One more comment: it would be good to have this fix with meson too.