From: Thomas Monjalon <thomas@monjalon.net>
To: Hongzhi Guo <guohongzhi1@huawei.com>
Cc: "Morten Brørup" <mb@smartsharesystems.com>,
stable@dpdk.org, dev@dpdk.org, stable@dpdk.org,
stephen@networkplumber.org, konstantin.ananyev@intel.com,
ferruh.yigit@intel.com, nicolas.chautru@intel.com,
zhoujingbin@huawei.com, chenchanghu@huawei.com,
jerry.lilijun@huawei.com, haifeng.lin@huawei.com
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] net: fix checksum on big endian CPUs
Date: Fri, 10 Jul 2020 23:11:31 +0200 [thread overview]
Message-ID: <1625950.jeTQybBuoM@thomas> (raw)
In-Reply-To: <20200710123722.GX5869@platinum>
10/07/2020 14:37, Olivier Matz:
> On Fri, Jul 10, 2020 at 02:20:08PM +0200, Morten Brørup wrote:
> > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Hongzhi Guo
> > > Sent: Friday, July 10, 2020 1:43 PM
> > >
> > > With current code, the checksum of odd-length buffers is wrong on
> > > big endian CPUs: the last byte is not properly summed to the
> > > accumulator.
> > >
> > > Fix this by left-shifting the remaining byte by 8. For instance,
> > > if the last byte is 0x42, we should add 0x4200 to the accumulator
> > > on big endian CPUs.
> > >
> > > This change is similar to what is suggested in Errata 3133 of
> > > RFC 1071.
> > >
> > > Fixes: 6006818cfb26("net: new checksum functions")
> > > Cc: stable@dpdk.org
> > >
> > > Signed-off-by: Hongzhi Guo <guohongzhi1@huawei.com>
> >
> > Reviewed-by: Morten Brørup <mb@smartsharesystems.com>
>
> Acked-by: Olivier Matz <olivier.matz@6wind.com>
Applied, thank you Hongzhi Guo, we want more patches like this :-)
prev parent reply other threads:[~2020-07-10 21:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-10 11:43 [dpdk-stable] " Hongzhi Guo
2020-07-10 12:20 ` [dpdk-stable] [dpdk-dev] " Morten Brørup
2020-07-10 12:37 ` Olivier Matz
2020-07-10 21:11 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1625950.jeTQybBuoM@thomas \
--to=thomas@monjalon.net \
--cc=chenchanghu@huawei.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=guohongzhi1@huawei.com \
--cc=haifeng.lin@huawei.com \
--cc=jerry.lilijun@huawei.com \
--cc=konstantin.ananyev@intel.com \
--cc=mb@smartsharesystems.com \
--cc=nicolas.chautru@intel.com \
--cc=stable@dpdk.org \
--cc=stephen@networkplumber.org \
--cc=zhoujingbin@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).