From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 62692A0548 for ; Thu, 11 Nov 2021 10:12:15 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 35FD540E28; Thu, 11 Nov 2021 10:12:15 +0100 (CET) Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) by mails.dpdk.org (Postfix) with ESMTP id C9D0B40E28 for ; Thu, 11 Nov 2021 10:12:13 +0100 (CET) Received: by mail-wr1-f54.google.com with SMTP id i5so8672724wrb.2 for ; Thu, 11 Nov 2021 01:12:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id; bh=TC2RiFfMPlGpiPUzJ/NFeW4D0yas2p0ZQ3y7DnNivzk=; b=m2IkcsnR/byt4q/XskclMpwueVKQRdpiyko+BiRC5y51xGmp7MsC9dMPa7dkW8+RoI KwDmm2PW/Bj6oVFw7jCHmf0xSj414fa6DcUJTftmihDAqdhl6bNQljoIFk8M5rEi/dOp JyHkRftmpw3ZYvpxv/x3jezObn4GTfFRbgYk8Edu2joi9+Aj+7RUufyMtcsmG8bxVcKq PpX+3jI86xbu5VweVatVZxIbCRkhW+nNM8SVXE+7saRNMBZthdG3yHtb1ePDl9c704kP OpstIl+iD6JRMYKNsNRquLpddaD4do3H9AKte5e7vh3ka4F5B4vuDf+H0GAahwo+oWvv /v6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=TC2RiFfMPlGpiPUzJ/NFeW4D0yas2p0ZQ3y7DnNivzk=; b=4KpC/3tT7lsv7hVerVcdCKDXsLA0UW6y8uj7jBIy3yix2OOQ5r1CHOPPs3EVNF4Lkc ZIe4GvIZCeZl5JOHHTcpEDrvMTsuNkOAnMowXTo4d4vaulhJZXXcfB/6sfN6yvJ9tFLb jeasvAnh9SKvO7pUhGZ07cmKTJDNngKxwhJXPesbAFsPIPLEfT1A6TrOjAF6SbEWvtnj ulQewDQ6k+zKXcBBbeu80d//yzNSZ3uqVqeJRujIGKM0JtVIZMLaq8Ezlqrlupf9E1Ki l+si1VYJuRranRiSmRM0eLss2vBCixobHmlf1o9tFRmVWa40LSWSI//KmyG4uUJzfJnq p3nQ== X-Gm-Message-State: AOAM531H4i/2yoLy8Wnz960cKAUQk/9VccRSUQH1RUIQu3OVt9CramEL 5dJU2Wc+Wlv0FFXNEiOU/QcD6fhhsyY= X-Google-Smtp-Source: ABdhPJwSpMhn+li0zCi2AQfFzhBDlBafddHKc2JmnaB4occ4iuGl8QCrDOzif0fnCI+fKbvlEjAPNQ== X-Received: by 2002:a5d:6d86:: with SMTP id l6mr6963501wrs.304.1636621933220; Thu, 11 Nov 2021 01:12:13 -0800 (PST) Received: from tucornea-dev-machine.localdomain ([193.226.172.42]) by smtp.gmail.com with ESMTPSA id d24sm2134381wmb.35.2021.11.11.01.12.11 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 11 Nov 2021 01:12:12 -0800 (PST) From: Tudor Cornea To: stable@dpdk.org Cc: xuemingl@nvidia.com, Tudor Cornea Subject: [PATCH 20.11] net/ixgbe: fix port initialization if MTU config fails Date: Thu, 11 Nov 2021 11:12:04 +0200 Message-Id: <1636621924-54546-1-git-send-email-tudor.cornea@gmail.com> X-Mailer: git-send-email 2.7.4 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org [ upstream commit 2108930be123ab83c837e7dd6eb3078ec3482ad4 ] On a VMware ESXi 6.0 setup with an Intel 82599 NIC the ports don't seem to initialize anymore, while running testpmd. Configuring Port 0 (socket 0) ixgbevf_dev_rx_init(): Set max packet length to 1518 failed. ixgbevf_dev_start(): Unable to initialize RX hardware (-22) Fail to start port 0: Invalid argument Configuring Port 1 (socket 0) ixgbevf_dev_rx_init(): Set max packet length to 1518 failed. ixgbevf_dev_start(): Unable to initialize RX hardware (-22) Fail to start port 1: Invalid argument Please stop the ports first If the call to ixgbevf_rlpml_set_vf fails and we return prematurely, we will not be able to initialize the ports correctly. Fixes: c77866a16904 ("net/ixgbe: detect failed VF MTU set") We can make this particular use case work correctly if we don't return an error, which seems to be consistent with the overall kernel ixgbevf implementation. [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/ drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c?h=v5.14#n2015 Signed-off-by: Tudor Cornea --- drivers/net/ixgbe/ixgbe_rxtx.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c b/drivers/net/ixgbe/ixgbe_rxtx.c index c0ab36a..6d27f67 100644 --- a/drivers/net/ixgbe/ixgbe_rxtx.c +++ b/drivers/net/ixgbe/ixgbe_rxtx.c @@ -5659,11 +5659,9 @@ ixgbevf_dev_rx_init(struct rte_eth_dev *dev) * VF packets received can work in all cases. */ if (ixgbevf_rlpml_set_vf(hw, - (uint16_t)dev->data->dev_conf.rxmode.max_rx_pkt_len)) { + (uint16_t)dev->data->dev_conf.rxmode.max_rx_pkt_len)) PMD_INIT_LOG(ERR, "Set max packet length to %d failed.", dev->data->dev_conf.rxmode.max_rx_pkt_len); - return -EINVAL; - } /* * Assume no header split and no VLAN strip support -- 2.7.4