Re: [dpdk-stable] please help backporting some patches to stable release 20.11.2

Re: [dpdk-stable] please help backporting some patches to stable release 20.11.2

[Elad Nachman]

Hi,

Sorry - 631217c761  Elad Nachman     kni: fix kernel deadlock with
bifurcated device is missing Depends-on:
It requires the following patches from main:
kni: support async user request commit
6b1f8e4f9b9337c81987336ae5204c7730b19d29
kni: refactor user request processing commit
740f3d20ee466814956efcf8d03a469b8a4c9abd

You need to apply the 3 above patches as a series on top of 20.11.

Apologies,

Elad.


On Tue, May 11, 2021 at 1:42 AM Xueming Li <xuemingl@nvidia.com> wrote:

> Hi commit authors (and maintainers),
>
> I didn't apply following commits from DPDK main to 20.11
> stable branch, as conflicts or build errors occur.
>
> Can authors check your patches in the following list and either:
>     - Backport your patches to the 20.11 branch, or
>     - Indicate that the patch should not be backported
>
> Please do either of the above by 05/17/21.
>
> You can find the a temporary work-in-progress branch of the coming 20.11.2
> release at:
>     https://github.com/steevenlee/dpdk
> It is recommended to backport on top of that to minimize further conflicts
> or
> misunderstandings.
>
> Some notes on stable backports:
>
> A backport should contain a reference to the DPDK main branch commit
> in it's commit message in the following fashion:
>     [ upstream commit <commit's dpdk main branch SHA-1 checksum> ]
>
> For example:
>
> https://git.dpdk.org/dpdk-stable/commit/?h=18.11&id=d90e6ae6f936ecdc2fd3811ff9f26aec7f3c06eb
>
> When sending the backported patch, please indicate the target branch in the
> subject line, as we have multiple branches, for example:
>     [PATCH 20.11] foo/bar: fix baz
>
> With git format-patch, this can be achieved by appending the parameter:
>     --subject-prefix='PATCH 20.11'
>
> Send the backported patch to "stable@dpdk.org" but not "dev@dpdk.org".
>
> FYI, branch 20.11 is located at tree:
>    https://git.dpdk.org/dpdk-stable
>
> Thanks.
>
> Xueming Li <xuemingl@nvidia.com>
>
> ---
> 1e28e842e0  Chengchang Tang  net/hns3: fix imprecise statistics
> d566bfcff0  Chengchang Tang  net/hns3: fix timing in mailbox
> ec2ed976ac  Chengwen Feng    net/hns3: delete mailbox arq ring
> c8dec72de0  Chengwen Feng    net/hns3: fix possible mismatched response of
> mailbox
> 55c038c2db  Chengwen Feng    net/hns3: fix PTP capability report
> 76a3836b98  Chengwen Feng    net/hns3: fix setting default MAC address in
> bonding of VF
> e40ad6fca4  Chengwen Feng    net/hns3: fix verification of NEON support
> dbbbad23e3  Chengwen Feng    net/hns3: fix VF handling LSC event in
> secondary process
> aa5baf47e1  Chengwen Feng    net/hns3: rename Rx burst function
> c53a5f3efb  Chengwen Feng    telemetry: check thread creations
> 3cd7290c16  David Marchand   ci: catch coredumps
> 631217c761  Elad Nachman     kni: fix kernel deadlock with bifurcated
> device
> f9f24ecd79  Hongbo Zheng     net/hns3: fix concurrent interrupt handling
> a2258ea1be  Huisong Li       doc: remove queue stats mapping from testpmd
> guide
> fdfde7a4a0  Huisong Li       net/hns3: fix mbuf leakage
> 23abee9dea  Ilya Maximets    net/virtio: fix interrupt unregistering for
> listening socket
> d8caafcbf9  Ivan Malov       net/sfc: fix outer rule and encap rollback on
> error
> 8f5ea6a464  Juraj Linkeš     config/arm: fix implementer and its SoCs
> 53f98141ee  Kalesh AP        net/bnxt: fix PTP support for Thor
> 25fefa2b17  Lance Richardson net/bnxt: fix Rx descriptor status
> 9f13e888ef  Lance Richardson net/bnxt: fix Rx queue count
> e6988afdc7  Matan Azrad      net/mlx5: fix imissed statistics
> 8e321f7df1  Min Hu (Connor)  doc: fix Rx burst function in hns3 guide
> 53ef1b3477  Min Hu (Connor)  ethdev: add sanity checks in control APIs
> 052a5d3867  Pavan Nikhilesh  event/octeontx2: fix XAQ pool reconfigure
> 83306d6c46  Shun Hao         net/mlx5: fix meter statistics
> 487cfc2437  Thomas Monjalon  app: fix exit messages
> 204a7f44bc  Thomas Monjalon  bus/pci: support I/O port operations with musl
> d61381ad46  Viacheslav Ovsiienko net/mlx5: support timestamp format
> dd25bd201d  Viacheslav Ovsiienko regex/mlx5: support timestamp format
> 687833fffa  Wei Huang        raw/ifpga/base: check size before assigning
> f2cb939365  Wisam Jaddo      app/flow-perf: fix IPv6 source address
> increment
>

Re: [dpdk-stable] please help backporting some patches to stable release 20.11.2

[Xueming(Steven) Li]

Hi Elad,

Thanks, added them all.

Best regards,
Xueming

From: Elad Nachman <eladv6@gmail.com>
Sent: Tuesday, May 11, 2021 2:43 PM
To: dpdk stable <stable@dpdk.org>; Xueming(Steven) Li <xuemingl@nvidia.com>
Subject: Re: please help backporting some patches to stable release 20.11.2

Hi,

Sorry - 631217c761  Elad Nachman     kni: fix kernel deadlock with bifurcated device is missing Depends-on:
It requires the following patches from main:
kni: support async user request commit 6b1f8e4f9b9337c81987336ae5204c7730b19d29
kni: refactor user request processing commit 740f3d20ee466814956efcf8d03a469b8a4c9abd

You need to apply the 3 above patches as a series on top of 20.11.

Apologies,

Elad.


On Tue, May 11, 2021 at 1:42 AM Xueming Li <xuemingl@nvidia.com<mailto:xuemingl@nvidia.com>> wrote:
Hi commit authors (and maintainers),

I didn't apply following commits from DPDK main to 20.11
stable branch, as conflicts or build errors occur.

Can authors check your patches in the following list and either:
    - Backport your patches to the 20.11 branch, or
    - Indicate that the patch should not be backported

Please do either of the above by 05/17/21.

You can find the a temporary work-in-progress branch of the coming 20.11.2
release at:
    https://github.com/steevenlee/dpdk
It is recommended to backport on top of that to minimize further conflicts or
misunderstandings.

Some notes on stable backports:

A backport should contain a reference to the DPDK main branch commit
in it's commit message in the following fashion:
    [ upstream commit <commit's dpdk main branch SHA-1 checksum> ]

For example:
    https://git.dpdk.org/dpdk-stable/commit/?h=18.11&id=d90e6ae6f936ecdc2fd3811ff9f26aec7f3c06eb

When sending the backported patch, please indicate the target branch in the
subject line, as we have multiple branches, for example:
    [PATCH 20.11] foo/bar: fix baz

With git format-patch, this can be achieved by appending the parameter:
    --subject-prefix='PATCH 20.11'

Send the backported patch to "stable@dpdk.org<mailto:stable@dpdk.org>" but not "dev@dpdk.org<mailto:dev@dpdk.org>".

FYI, branch 20.11 is located at tree:
   https://git.dpdk.org/dpdk-stable

Thanks.

Xueming Li <xuemingl@nvidia.com<mailto:xuemingl@nvidia.com>>

---
1e28e842e0  Chengchang Tang  net/hns3: fix imprecise statistics
d566bfcff0  Chengchang Tang  net/hns3: fix timing in mailbox
ec2ed976ac  Chengwen Feng    net/hns3: delete mailbox arq ring
c8dec72de0  Chengwen Feng    net/hns3: fix possible mismatched response of mailbox
55c038c2db  Chengwen Feng    net/hns3: fix PTP capability report
76a3836b98  Chengwen Feng    net/hns3: fix setting default MAC address in bonding of VF
e40ad6fca4  Chengwen Feng    net/hns3: fix verification of NEON support
dbbbad23e3  Chengwen Feng    net/hns3: fix VF handling LSC event in secondary process
aa5baf47e1  Chengwen Feng    net/hns3: rename Rx burst function
c53a5f3efb  Chengwen Feng    telemetry: check thread creations
3cd7290c16  David Marchand   ci: catch coredumps
631217c761  Elad Nachman     kni: fix kernel deadlock with bifurcated device
f9f24ecd79  Hongbo Zheng     net/hns3: fix concurrent interrupt handling
a2258ea1be  Huisong Li       doc: remove queue stats mapping from testpmd guide
fdfde7a4a0  Huisong Li       net/hns3: fix mbuf leakage
23abee9dea  Ilya Maximets    net/virtio: fix interrupt unregistering for listening socket
d8caafcbf9  Ivan Malov       net/sfc: fix outer rule and encap rollback on error
8f5ea6a464  Juraj Linkeš     config/arm: fix implementer and its SoCs
53f98141ee  Kalesh AP        net/bnxt: fix PTP support for Thor
25fefa2b17  Lance Richardson net/bnxt: fix Rx descriptor status
9f13e888ef  Lance Richardson net/bnxt: fix Rx queue count
e6988afdc7  Matan Azrad      net/mlx5: fix imissed statistics
8e321f7df1  Min Hu (Connor)  doc: fix Rx burst function in hns3 guide
53ef1b3477  Min Hu (Connor)  ethdev: add sanity checks in control APIs
052a5d3867  Pavan Nikhilesh  event/octeontx2: fix XAQ pool reconfigure
83306d6c46  Shun Hao         net/mlx5: fix meter statistics
487cfc2437  Thomas Monjalon  app: fix exit messages
204a7f44bc  Thomas Monjalon  bus/pci: support I/O port operations with musl
d61381ad46  Viacheslav Ovsiienko net/mlx5: support timestamp format
dd25bd201d  Viacheslav Ovsiienko regex/mlx5: support timestamp format
687833fffa  Wei Huang        raw/ifpga/base: check size before assigning
f2cb939365  Wisam Jaddo      app/flow-perf: fix IPv6 source address increment

Re: [dpdk-stable] please help backporting some patches to stable release 20.11.2

[David Marchand]

On Tue, May 11, 2021 at 12:42 AM Xueming Li <xuemingl@nvidia.com> wrote:
> 3cd7290c16  David Marchand   ci: catch coredumps

I can provide the backport for this.

But instead:

Since Travis is almost unusable, 20.11 stable maintainers won't be
able to run non regression tests.
I would recommend backporting GHA support in 20.11.

Another thing is that the 20.11 does not have ABI checks enabled.
At the moment, backports are easy and won't break ABI, but later, once
v21.11 is out, we must be careful not to backport anything breaking
ABI.


I did the test, cherry-picking needed patches for the suggestions above.

87009585e2 - ci: hook to GitHub Actions (5 months ago) <David Marchand>
443267090e - ci: enable v21 ABI checks (5 months ago) <David Marchand>
9d620630ea - ci: fix package installation in GitHub Actions (5 months
ago) <David Marchand>
1e90d1b67b - ci: ignore APT update failure in GitHub Actions (3 months
ago) <David Marchand>
3cd7290c16 - ci: catch coredumps (10 weeks ago) <David Marchand>
aa9cb78f66 - doc: fix sphinx rtd theme import in GHA (6 weeks ago)
<David Marchand>

https://github.com/david-marchand/dpdk/actions/runs/831111482


What do you think?

-- 
David Marchand

Re: [dpdk-stable] please help backporting some patches to stable release 20.11.2

[Luca Boccassi]

On Tue, 2021-05-11 at 11:34 +0200, David Marchand wrote:
> On Tue, May 11, 2021 at 12:42 AM Xueming Li <xuemingl@nvidia.com> wrote:
> > 3cd7290c16  David Marchand   ci: catch coredumps
> 
> I can provide the backport for this.
> 
> But instead:
> 
> Since Travis is almost unusable, 20.11 stable maintainers won't be
> able to run non regression tests.
> I would recommend backporting GHA support in 20.11.
> 
> Another thing is that the 20.11 does not have ABI checks enabled.
> At the moment, backports are easy and won't break ABI, but later, once
> v21.11 is out, we must be careful not to backport anything breaking
> ABI.
> 
> 
> I did the test, cherry-picking needed patches for the suggestions above.
> 
> 87009585e2 - ci: hook to GitHub Actions (5 months ago) <David Marchand>
> 443267090e - ci: enable v21 ABI checks (5 months ago) <David Marchand>
> 9d620630ea - ci: fix package installation in GitHub Actions (5 months
> ago) <David Marchand>
> 1e90d1b67b - ci: ignore APT update failure in GitHub Actions (3 months
> ago) <David Marchand>
> 3cd7290c16 - ci: catch coredumps (10 weeks ago) <David Marchand>
> aa9cb78f66 - doc: fix sphinx rtd theme import in GHA (6 weeks ago)
> <David Marchand>
> 
> https://github.com/david-marchand/dpdk/actions/runs/831111482
> 
> 
> What do you think?

Sounds like a great idea to me - but we also need the coredump stuff,
as these tests are ran as package builds too, where that is needed, not
only on Travis.

-- 
Kind regards,
Luca Boccassi

Re: [dpdk-stable] please help backporting some patches to stable release 20.11.2

[David Marchand]

On Tue, May 11, 2021 at 12:36 PM Luca Boccassi <bluca@debian.org> wrote:
> > I did the test, cherry-picking needed patches for the suggestions above.
> >
> > 87009585e2 - ci: hook to GitHub Actions (5 months ago) <David Marchand>
> > 443267090e - ci: enable v21 ABI checks (5 months ago) <David Marchand>
> > 9d620630ea - ci: fix package installation in GitHub Actions (5 months
> > ago) <David Marchand>
> > 1e90d1b67b - ci: ignore APT update failure in GitHub Actions (3 months
> > ago) <David Marchand>
> > 3cd7290c16 - ci: catch coredumps (10 weeks ago) <David Marchand>

^^

> > aa9cb78f66 - doc: fix sphinx rtd theme import in GHA (6 weeks ago)
> > <David Marchand>
> >
> > https://github.com/david-marchand/dpdk/actions/runs/831111482
> >
> >
> > What do you think?
>
> Sounds like a great idea to me - but we also need the coredump stuff,
> as these tests are ran as package builds too, where that is needed, not
> only on Travis.

I included in my test, all good then?


-- 
David Marchand

Re: [dpdk-stable] please help backporting some patches to stable release 20.11.2

[Aaron Conole]

David Marchand <david.marchand@redhat.com> writes:

> On Tue, May 11, 2021 at 12:42 AM Xueming Li <xuemingl@nvidia.com> wrote:
>> 3cd7290c16  David Marchand   ci: catch coredumps
>
> I can provide the backport for this.
>
> But instead:
>
> Since Travis is almost unusable, 20.11 stable maintainers won't be
> able to run non regression tests.
> I would recommend backporting GHA support in 20.11.

+1

> Another thing is that the 20.11 does not have ABI checks enabled.
> At the moment, backports are easy and won't break ABI, but later, once
> v21.11 is out, we must be careful not to backport anything breaking
> ABI.
>
>
> I did the test, cherry-picking needed patches for the suggestions above.
>
> 87009585e2 - ci: hook to GitHub Actions (5 months ago) <David Marchand>
> 443267090e - ci: enable v21 ABI checks (5 months ago) <David Marchand>
> 9d620630ea - ci: fix package installation in GitHub Actions (5 months
> ago) <David Marchand>
> 1e90d1b67b - ci: ignore APT update failure in GitHub Actions (3 months
> ago) <David Marchand>
> 3cd7290c16 - ci: catch coredumps (10 weeks ago) <David Marchand>
> aa9cb78f66 - doc: fix sphinx rtd theme import in GHA (6 weeks ago)
> <David Marchand>
>
> https://github.com/david-marchand/dpdk/actions/runs/831111482
>
>
> What do you think?

LGTM

Re: [dpdk-stable] please help backporting some patches to stable release 20.11.2

[Xueming(Steven) Li]

> -----Original Message-----
> From: Aaron Conole <aconole@redhat.com>
> Sent: Tuesday, May 11, 2021 10:44 PM
> To: David Marchand <david.marchand@redhat.com>
> Cc: Xueming(Steven) Li <xuemingl@nvidia.com>; Luca Boccassi <bluca@debian.org>; dpdk stable <stable@dpdk.org>; Yigit, Ferruh
> <ferruh.yigit@intel.com>; NBU-Contact-Thomas Monjalon <thomas@monjalon.net>; Kevin Traynor <ktraynor@redhat.com>;
> Christian Ehrhardt <christian.ehrhardt@canonical.com>
> Subject: Re: please help backporting some patches to stable release 20.11.2
> 
> David Marchand <david.marchand@redhat.com> writes:
> 
> > On Tue, May 11, 2021 at 12:42 AM Xueming Li <xuemingl@nvidia.com> wrote:
> >> 3cd7290c16  David Marchand   ci: catch coredumps
> >
> > I can provide the backport for this.
> >
> > But instead:
> >
> > Since Travis is almost unusable, 20.11 stable maintainers won't be
> > able to run non regression tests.
> > I would recommend backporting GHA support in 20.11.
> 
> +1
> 
> > Another thing is that the 20.11 does not have ABI checks enabled.
> > At the moment, backports are easy and won't break ABI, but later, once
> > v21.11 is out, we must be careful not to backport anything breaking
> > ABI.
> >
> >
> > I did the test, cherry-picking needed patches for the suggestions above.
> >
> > 87009585e2 - ci: hook to GitHub Actions (5 months ago) <David
> > Marchand> 443267090e - ci: enable v21 ABI checks (5 months ago) <David
> > Marchand> 9d620630ea - ci: fix package installation in GitHub Actions
> > (5 months
> > ago) <David Marchand>
> > 1e90d1b67b - ci: ignore APT update failure in GitHub Actions (3 months
> > ago) <David Marchand>
> > 3cd7290c16 - ci: catch coredumps (10 weeks ago) <David Marchand>
> > aa9cb78f66 - doc: fix sphinx rtd theme import in GHA (6 weeks ago)
> > <David Marchand>
> >
> > https://github.com/david-marchand/dpdk/actions/runs/831111482
> >
> >
> > What do you think?
> 
> LGTM

Cherry-picked to 20.11 branch, CI built successfully, thanks!
https://github.com/steevenlee/dpdk/actions

Re: [dpdk-stable] please help backporting some patches to stable release 20.11.2

[Thomas Monjalon]

11/05/2021 00:41, Xueming Li:
> Hi commit authors (and maintainers),
> 
> I didn't apply following commits from DPDK main to 20.11
> stable branch, as conflicts or build errors occur.
> 
[...]
> 487cfc2437  Thomas Monjalon  app: fix exit messages

I could try to backport this one.
It is not critical but should not be too difficult.

> 204a7f44bc  Thomas Monjalon  bus/pci: support I/O port operations with musl

There can be more issues with musl in 20.11.
There is no commitment to support musl in 20.11, so we can probably give up.

[dpdk-stable] Fwd: please help backporting some patches to stable release 20.11.2

[Ferruh Yigit]

Initial mail is not in the mail list, forwarding to mail list again for archive.

-------- Forwarded Message --------
Subject: please help backporting some patches to stable release 20.11.2
Date: Tue, 11 May 2021 06:41:53 +0800
From: Xueming Li <xuemingl@nvidia.com>

Hi commit authors (and maintainers),

I didn't apply following commits from DPDK main to 20.11
stable branch, as conflicts or build errors occur.

Can authors check your patches in the following list and either:
    - Backport your patches to the 20.11 branch, or
    - Indicate that the patch should not be backported

Please do either of the above by 05/17/21.

You can find the a temporary work-in-progress branch of the coming 20.11.2
release at:
    https://github.com/steevenlee/dpdk
It is recommended to backport on top of that to minimize further conflicts or
misunderstandings.

Some notes on stable backports:

A backport should contain a reference to the DPDK main branch commit
in it's commit message in the following fashion:
    [ upstream commit <commit's dpdk main branch SHA-1 checksum> ]

For example:

https://git.dpdk.org/dpdk-stable/commit/?h=18.11&id=d90e6ae6f936ecdc2fd3811ff9f26aec7f3c06eb

When sending the backported patch, please indicate the target branch in the
subject line, as we have multiple branches, for example:
    [PATCH 20.11] foo/bar: fix baz

With git format-patch, this can be achieved by appending the parameter:
    --subject-prefix='PATCH 20.11'

Send the backported patch to "stable@dpdk.org" but not "dev@dpdk.org".

FYI, branch 20.11 is located at tree:
   https://git.dpdk.org/dpdk-stable

Thanks.

Xueming Li <xuemingl@nvidia.com>

---
1e28e842e0  Chengchang Tang  net/hns3: fix imprecise statistics
d566bfcff0  Chengchang Tang  net/hns3: fix timing in mailbox
ec2ed976ac  Chengwen Feng    net/hns3: delete mailbox arq ring
c8dec72de0  Chengwen Feng    net/hns3: fix possible mismatched response of mailbox
55c038c2db  Chengwen Feng    net/hns3: fix PTP capability report
76a3836b98  Chengwen Feng    net/hns3: fix setting default MAC address in
bonding of VF
e40ad6fca4  Chengwen Feng    net/hns3: fix verification of NEON support
dbbbad23e3  Chengwen Feng    net/hns3: fix VF handling LSC event in secondary
process
aa5baf47e1  Chengwen Feng    net/hns3: rename Rx burst function
c53a5f3efb  Chengwen Feng    telemetry: check thread creations
3cd7290c16  David Marchand   ci: catch coredumps
631217c761  Elad Nachman     kni: fix kernel deadlock with bifurcated device
f9f24ecd79  Hongbo Zheng     net/hns3: fix concurrent interrupt handling
a2258ea1be  Huisong Li       doc: remove queue stats mapping from testpmd guide
fdfde7a4a0  Huisong Li       net/hns3: fix mbuf leakage
23abee9dea  Ilya Maximets    net/virtio: fix interrupt unregistering for
listening socket
d8caafcbf9  Ivan Malov       net/sfc: fix outer rule and encap rollback on error
8f5ea6a464  Juraj Linkeš     config/arm: fix implementer and its SoCs
53f98141ee  Kalesh AP        net/bnxt: fix PTP support for Thor
25fefa2b17  Lance Richardson net/bnxt: fix Rx descriptor status
9f13e888ef  Lance Richardson net/bnxt: fix Rx queue count
e6988afdc7  Matan Azrad      net/mlx5: fix imissed statistics
8e321f7df1  Min Hu (Connor)  doc: fix Rx burst function in hns3 guide
53ef1b3477  Min Hu (Connor)  ethdev: add sanity checks in control APIs
052a5d3867  Pavan Nikhilesh  event/octeontx2: fix XAQ pool reconfigure
83306d6c46  Shun Hao         net/mlx5: fix meter statistics
487cfc2437  Thomas Monjalon  app: fix exit messages
204a7f44bc  Thomas Monjalon  bus/pci: support I/O port operations with musl
d61381ad46  Viacheslav Ovsiienko net/mlx5: support timestamp format
dd25bd201d  Viacheslav Ovsiienko regex/mlx5: support timestamp format
687833fffa  Wei Huang        raw/ifpga/base: check size before assigning
f2cb939365  Wisam Jaddo      app/flow-perf: fix IPv6 source address increment