* [dpdk-stable] [PATCH] net/ixgbe: fix calling null function of VF
@ 2017-05-10 7:00 Wei Dai
2017-05-10 9:34 ` [dpdk-stable] [dpdk-dev] " Gregory Etelson
2017-05-10 9:50 ` [dpdk-stable] " Ferruh Yigit
0 siblings, 2 replies; 6+ messages in thread
From: Wei Dai @ 2017-05-10 7:00 UTC (permalink / raw)
To: wenzhuo.lu, konstantin.ananyev; +Cc: dev, Wei Dai, stable
hw->mac.ops.get_media-type() of ixgbe VF is NULL and should not
be called directly. It had better be replaced by calling
ixgbe_get_media_type( ) to avoid crash.
Fixes: c12d22f65b13 ("net/ixgbe: ensure link status is updated")
Cc: stable@dpdk.org
Signed-off-by: Wei Dai <wei.dai@intel.com>
---
drivers/net/ixgbe/ixgbe_ethdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
index ec667d8..ed2baec 100644
--- a/drivers/net/ixgbe/ixgbe_ethdev.c
+++ b/drivers/net/ixgbe/ixgbe_ethdev.c
@@ -3799,7 +3799,7 @@ ixgbe_dev_link_update(struct rte_eth_dev *dev, int wait_to_complete)
hw->mac.get_link_status = true;
if ((intr->flags & IXGBE_FLAG_NEED_LINK_CONFIG) &&
- hw->mac.ops.get_media_type(hw) == ixgbe_media_type_fiber) {
+ ixgbe_get_media_type(hw) == ixgbe_media_type_fiber) {
speed = hw->phy.autoneg_advertised;
if (!speed)
ixgbe_get_link_capabilities(hw, &speed, &autoneg);
--
2.7.4
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dpdk-stable] [dpdk-dev] [PATCH] net/ixgbe: fix calling null function of VF 2017-05-10 7:00 [dpdk-stable] [PATCH] net/ixgbe: fix calling null function of VF Wei Dai @ 2017-05-10 9:34 ` Gregory Etelson 2017-05-10 9:49 ` Ferruh Yigit 2017-05-10 9:50 ` [dpdk-stable] " Ferruh Yigit 1 sibling, 1 reply; 6+ messages in thread From: Gregory Etelson @ 2017-05-10 9:34 UTC (permalink / raw) To: dev; +Cc: Wei Dai, wenzhuo.lu, konstantin.ananyev, stable Hello, The patch you proposed fixed a crash I experienced in IXGBE VF. However, there's still another crash possibility if the code will proceed with speed == 0 condition to ixgbe_get_link_capabilities VF mac.ops.get_link_capabilities is also set to NULL; Regards, Gregory On Wednesday, 10 May 2017 10:00:02 IDT Wei Dai wrote: > hw->mac.ops.get_media-type() of ixgbe VF is NULL and should not > be called directly. It had better be replaced by calling > ixgbe_get_media_type( ) to avoid crash. > > Fixes: c12d22f65b13 ("net/ixgbe: ensure link status is updated") > Cc: stable@dpdk.org > > Signed-off-by: Wei Dai <wei.dai@intel.com> > --- > drivers/net/ixgbe/ixgbe_ethdev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c > index ec667d8..ed2baec 100644 > --- a/drivers/net/ixgbe/ixgbe_ethdev.c > +++ b/drivers/net/ixgbe/ixgbe_ethdev.c > @@ -3799,7 +3799,7 @@ ixgbe_dev_link_update(struct rte_eth_dev *dev, int wait_to_complete) > hw->mac.get_link_status = true; > > if ((intr->flags & IXGBE_FLAG_NEED_LINK_CONFIG) && > - hw->mac.ops.get_media_type(hw) == ixgbe_media_type_fiber) { > + ixgbe_get_media_type(hw) == ixgbe_media_type_fiber) { > speed = hw->phy.autoneg_advertised; > if (!speed) > ixgbe_get_link_capabilities(hw, &speed, &autoneg); > ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-stable] [dpdk-dev] [PATCH] net/ixgbe: fix calling null function of VF 2017-05-10 9:34 ` [dpdk-stable] [dpdk-dev] " Gregory Etelson @ 2017-05-10 9:49 ` Ferruh Yigit 0 siblings, 0 replies; 6+ messages in thread From: Ferruh Yigit @ 2017-05-10 9:49 UTC (permalink / raw) To: Gregory Etelson, dev; +Cc: Wei Dai, wenzhuo.lu, konstantin.ananyev, stable On 5/10/2017 10:34 AM, Gregory Etelson wrote: > Hello, > > The patch you proposed fixed a crash I experienced in IXGBE VF. > However, there's still another crash possibility > if the code will proceed with speed == 0 condition to ixgbe_get_link_capabilities > VF mac.ops.get_link_capabilities is also set to NULL; There seems a NULL check in that path, so it should be OK, can you please check: ixgbe_get_link_capabilities() return ixgbe_call_func(hw, hw->mac.ops.get_link_capabilities, .) ... #define ixgbe_call_func(hw, func, params, error) \ (func != NULL) ? func params : error So, if hw->mac.ops.get_link_capabilities == NULL, this will return IXGBE_NOT_IMPLEMENTED > > Regards, > Gregory > > > On Wednesday, 10 May 2017 10:00:02 IDT Wei Dai wrote: >> hw->mac.ops.get_media-type() of ixgbe VF is NULL and should not >> be called directly. It had better be replaced by calling >> ixgbe_get_media_type( ) to avoid crash. >> >> Fixes: c12d22f65b13 ("net/ixgbe: ensure link status is updated") >> Cc: stable@dpdk.org >> >> Signed-off-by: Wei Dai <wei.dai@intel.com> >> --- >> drivers/net/ixgbe/ixgbe_ethdev.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c >> index ec667d8..ed2baec 100644 >> --- a/drivers/net/ixgbe/ixgbe_ethdev.c >> +++ b/drivers/net/ixgbe/ixgbe_ethdev.c >> @@ -3799,7 +3799,7 @@ ixgbe_dev_link_update(struct rte_eth_dev *dev, int wait_to_complete) >> hw->mac.get_link_status = true; >> >> if ((intr->flags & IXGBE_FLAG_NEED_LINK_CONFIG) && >> - hw->mac.ops.get_media_type(hw) == ixgbe_media_type_fiber) { >> + ixgbe_get_media_type(hw) == ixgbe_media_type_fiber) { >> speed = hw->phy.autoneg_advertised; >> if (!speed) >> ixgbe_get_link_capabilities(hw, &speed, &autoneg); >> > ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-stable] [PATCH] net/ixgbe: fix calling null function of VF 2017-05-10 7:00 [dpdk-stable] [PATCH] net/ixgbe: fix calling null function of VF Wei Dai 2017-05-10 9:34 ` [dpdk-stable] [dpdk-dev] " Gregory Etelson @ 2017-05-10 9:50 ` Ferruh Yigit 2017-05-10 12:20 ` Roger B. Melton 1 sibling, 1 reply; 6+ messages in thread From: Ferruh Yigit @ 2017-05-10 9:50 UTC (permalink / raw) To: Wei Dai, wenzhuo.lu, konstantin.ananyev Cc: dev, stable, Roger B Melton, Laurent Hardy On 5/10/2017 8:00 AM, Wei Dai wrote: > hw->mac.ops.get_media-type() of ixgbe VF is NULL and should not > be called directly. It had better be replaced by calling > ixgbe_get_media_type( ) to avoid crash. > > Fixes: c12d22f65b13 ("net/ixgbe: ensure link status is updated") > Cc: stable@dpdk.org > > Signed-off-by: Wei Dai <wei.dai@intel.com> Hi Roger and Laurent, This is very close the release, can you please support verifying this defect? An explicit Acked-by and/or Tested-by would help a lot. Thanks, ferruh > --- > drivers/net/ixgbe/ixgbe_ethdev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c > index ec667d8..ed2baec 100644 > --- a/drivers/net/ixgbe/ixgbe_ethdev.c > +++ b/drivers/net/ixgbe/ixgbe_ethdev.c > @@ -3799,7 +3799,7 @@ ixgbe_dev_link_update(struct rte_eth_dev *dev, int wait_to_complete) > hw->mac.get_link_status = true; > > if ((intr->flags & IXGBE_FLAG_NEED_LINK_CONFIG) && > - hw->mac.ops.get_media_type(hw) == ixgbe_media_type_fiber) { > + ixgbe_get_media_type(hw) == ixgbe_media_type_fiber) { > speed = hw->phy.autoneg_advertised; > if (!speed) > ixgbe_get_link_capabilities(hw, &speed, &autoneg); > ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-stable] [PATCH] net/ixgbe: fix calling null function of VF 2017-05-10 9:50 ` [dpdk-stable] " Ferruh Yigit @ 2017-05-10 12:20 ` Roger B. Melton 2017-05-10 12:33 ` Laurent Hardy 0 siblings, 1 reply; 6+ messages in thread From: Roger B. Melton @ 2017-05-10 12:20 UTC (permalink / raw) To: Ferruh Yigit, Wei Dai, wenzhuo.lu, konstantin.ananyev Cc: dev, stable, Laurent Hardy On 5/10/17 5:50 AM, Ferruh Yigit wrote: > On 5/10/2017 8:00 AM, Wei Dai wrote: >> hw->mac.ops.get_media-type() of ixgbe VF is NULL and should not >> be called directly. It had better be replaced by calling >> ixgbe_get_media_type( ) to avoid crash. >> >> Fixes: c12d22f65b13 ("net/ixgbe: ensure link status is updated") >> Cc: stable@dpdk.org >> >> Signed-off-by: Wei Dai <wei.dai@intel.com> > Hi Roger and Laurent, > > This is very close the release, can you please support verifying this > defect? > > An explicit Acked-by and/or Tested-by would help a lot. > > Thanks, > ferruh Hi Ferruh, Happy to test it. I'll get back to you shortly. Regards, Roger > > >> --- >> drivers/net/ixgbe/ixgbe_ethdev.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c >> index ec667d8..ed2baec 100644 >> --- a/drivers/net/ixgbe/ixgbe_ethdev.c >> +++ b/drivers/net/ixgbe/ixgbe_ethdev.c >> @@ -3799,7 +3799,7 @@ ixgbe_dev_link_update(struct rte_eth_dev *dev, int wait_to_complete) >> hw->mac.get_link_status = true; >> >> if ((intr->flags & IXGBE_FLAG_NEED_LINK_CONFIG) && >> - hw->mac.ops.get_media_type(hw) == ixgbe_media_type_fiber) { >> + ixgbe_get_media_type(hw) == ixgbe_media_type_fiber) { >> speed = hw->phy.autoneg_advertised; >> if (!speed) >> ixgbe_get_link_capabilities(hw, &speed, &autoneg); >> > . > ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-stable] [PATCH] net/ixgbe: fix calling null function of VF 2017-05-10 12:20 ` Roger B. Melton @ 2017-05-10 12:33 ` Laurent Hardy 0 siblings, 0 replies; 6+ messages in thread From: Laurent Hardy @ 2017-05-10 12:33 UTC (permalink / raw) To: Roger B. Melton, Ferruh Yigit, Wei Dai, wenzhuo.lu, konstantin.ananyev Cc: dev, stable Hi Ferruh, Wei, Roger, PSB I also redo test plan provided through http://dpdk.org/dev/patchwork/patch/20502/ Thanks & regards, Laurent On 05/10/2017 02:20 PM, Roger B. Melton wrote: > > > On 5/10/17 5:50 AM, Ferruh Yigit wrote: >> On 5/10/2017 8:00 AM, Wei Dai wrote: >>> hw->mac.ops.get_media-type() of ixgbe VF is NULL and should not >>> be called directly. It had better be replaced by calling >>> ixgbe_get_media_type( ) to avoid crash. >>> >>> Fixes: c12d22f65b13 ("net/ixgbe: ensure link status is updated") >>> Cc: stable@dpdk.org >>> >>> Signed-off-by: Wei Dai <wei.dai@intel.com> Acked-by: Laurent Hardy <laurent.hardy@6wind.com> >> Hi Roger and Laurent, >> >> This is very close the release, can you please support verifying this >> defect? >> >> An explicit Acked-by and/or Tested-by would help a lot. >> >> Thanks, >> ferruh > > Hi Ferruh, > > Happy to test it. I'll get back to you shortly. > > Regards, > Roger > >> >> >>> --- >>> drivers/net/ixgbe/ixgbe_ethdev.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c >>> b/drivers/net/ixgbe/ixgbe_ethdev.c >>> index ec667d8..ed2baec 100644 >>> --- a/drivers/net/ixgbe/ixgbe_ethdev.c >>> +++ b/drivers/net/ixgbe/ixgbe_ethdev.c >>> @@ -3799,7 +3799,7 @@ ixgbe_dev_link_update(struct rte_eth_dev *dev, >>> int wait_to_complete) >>> hw->mac.get_link_status = true; >>> if ((intr->flags & IXGBE_FLAG_NEED_LINK_CONFIG) && >>> - hw->mac.ops.get_media_type(hw) == ixgbe_media_type_fiber) { >>> + ixgbe_get_media_type(hw) == ixgbe_media_type_fiber) { >>> speed = hw->phy.autoneg_advertised; >>> if (!speed) >>> ixgbe_get_link_capabilities(hw, &speed, &autoneg); >>> >> . >> > ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-05-10 12:33 UTC | newest] Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2017-05-10 7:00 [dpdk-stable] [PATCH] net/ixgbe: fix calling null function of VF Wei Dai 2017-05-10 9:34 ` [dpdk-stable] [dpdk-dev] " Gregory Etelson 2017-05-10 9:49 ` Ferruh Yigit 2017-05-10 9:50 ` [dpdk-stable] " Ferruh Yigit 2017-05-10 12:20 ` Roger B. Melton 2017-05-10 12:33 ` Laurent Hardy
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).