* [dpdk-stable] [PATCH] devtools: fix incorrect shell assignment
@ 2019-03-04 9:57 David Marchand
2019-03-04 10:12 ` Thomas Monjalon
0 siblings, 1 reply; 3+ messages in thread
From: David Marchand @ 2019-03-04 9:57 UTC (permalink / raw)
To: dev; +Cc: thomas, stable
No space needed here:
./devtools/checkpatches.sh: line 65: res: command not found
Fixes: dafc04c15174 ("devtools: fix return of forbidden addition checks")
Cc: stable@dpdk.org
Signed-off-by: David Marchand <david.marchand@redhat.com>
---
devtools/checkpatches.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh
index 3b03b7e..02d1c30 100755
--- a/devtools/checkpatches.sh
+++ b/devtools/checkpatches.sh
@@ -62,7 +62,7 @@ check_forbidden_additions() { # <patch>
-v RET_ON_FAIL=1 \
-v MESSAGE='Using explicit .svg extension instead of .*' \
-f $(dirname $(readlink -e $0))/check-forbidden-tokens.awk \
- "$1" || res = 1
+ "$1" || res=1
return $res
}
--
1.8.3.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-stable] [PATCH] devtools: fix incorrect shell assignment
2019-03-04 9:57 [dpdk-stable] [PATCH] devtools: fix incorrect shell assignment David Marchand
@ 2019-03-04 10:12 ` Thomas Monjalon
2019-03-04 10:17 ` David Marchand
0 siblings, 1 reply; 3+ messages in thread
From: Thomas Monjalon @ 2019-03-04 10:12 UTC (permalink / raw)
To: David Marchand; +Cc: dev, stable
04/03/2019 10:57, David Marchand:
> No space needed here:
> ./devtools/checkpatches.sh: line 65: res: command not found
>
> Fixes: dafc04c15174 ("devtools: fix return of forbidden addition checks")
> Cc: stable@dpdk.org
> Signed-off-by: David Marchand <david.marchand@redhat.com>
Thank you
It is already submitted:
https://patches.dpdk.org/patch/50727/
It is part of a patchset, waiting for a new version (for codespell feature).
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-stable] [PATCH] devtools: fix incorrect shell assignment
2019-03-04 10:12 ` Thomas Monjalon
@ 2019-03-04 10:17 ` David Marchand
0 siblings, 0 replies; 3+ messages in thread
From: David Marchand @ 2019-03-04 10:17 UTC (permalink / raw)
To: Thomas Monjalon; +Cc: dev, dpdk stable
On Mon, Mar 4, 2019 at 11:13 AM Thomas Monjalon <thomas@monjalon.net> wrote:
> 04/03/2019 10:57, David Marchand:
> > No space needed here:
> > ./devtools/checkpatches.sh: line 65: res: command not found
> >
> > Fixes: dafc04c15174 ("devtools: fix return of forbidden addition checks")
> > Cc: stable@dpdk.org
> > Signed-off-by: David Marchand <david.marchand@redhat.com>
>
> Thank you
> It is already submitted:
> https://patches.dpdk.org/patch/50727/
> It is part of a patchset, waiting for a new version (for codespell
> feature).
>
Indeed, thanks.
--
David Marchand
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-03-04 10:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-04 9:57 [dpdk-stable] [PATCH] devtools: fix incorrect shell assignment David Marchand
2019-03-04 10:12 ` Thomas Monjalon
2019-03-04 10:17 ` David Marchand
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).