From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Yajun Wu <yajunw@nvidia.com>,
matan@nvidia.com, Viacheslav Ovsiienko <viacheslavo@nvidia.com>,
Li Zhang <lizh@nvidia.com>
Cc: dev@dpdk.org, thomas@monjalon.net, rasland@nvidia.com,
roniba@nvidia.com, stable@dpdk.org
Subject: Re: [PATCH] vdpa/mlx5: fix unregister kick handler order
Date: Thu, 12 Oct 2023 15:44:52 +0200 [thread overview]
Message-ID: <166bee66-2be8-5850-deaf-6e00dd9b38ea@redhat.com> (raw)
In-Reply-To: <20230808113221.227319-1-yajunw@nvidia.com>
On 8/8/23 13:32, Yajun Wu wrote:
> The mlx5_vdpa_virtq_kick_handler function may still be running and waiting
> on virtq->virtq_lock while mlx5_vdpa_cqe_event_unset function is trying to
> re-initialize the virtq->virtq_lock.
>
> This causes mlx5_vdpa_virtq_kick_handler thread can't be wake up and can't
> be unregister. Following print may loop forever when calling
> rte_vhost_driver_unregister(socket_path):
>
> mlx5_vdpa: Try again to unregister fd 154 of virtq 11 interrupt
> mlx5_vdpa: Try again to unregister fd 154 of virtq 11 interrupt
> ...
>
> The fix is to move mlx5_vdpa_virtq_unregister_intr_handle before
> mlx5_vdpa_cqe_event_unset.
>
> Fixes: 057f7d2084 ("vdpa/mlx5: optimize datapath-control synchronization")
> Cc: stable@dpdk.org
>
> Signed-off-by: Yajun Wu <yajunw@nvidia.com>
> Acked-by: Matan Azrad <matan@nvidia.com>
> ---
> drivers/vdpa/mlx5/mlx5_vdpa.c | 1 +
> drivers/vdpa/mlx5/mlx5_vdpa_cthread.c | 1 -
> 2 files changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/vdpa/mlx5/mlx5_vdpa.c b/drivers/vdpa/mlx5/mlx5_vdpa.c
> index f1737f82a8..8b1de8bd62 100644
> --- a/drivers/vdpa/mlx5/mlx5_vdpa.c
> +++ b/drivers/vdpa/mlx5/mlx5_vdpa.c
> @@ -282,6 +282,7 @@ _internal_mlx5_vdpa_dev_close(struct mlx5_vdpa_priv *priv,
> int ret = 0;
> int vid = priv->vid;
>
> + mlx5_vdpa_virtq_unreg_intr_handle_all(priv);
> mlx5_vdpa_cqe_event_unset(priv);
> if (priv->state == MLX5_VDPA_STATE_CONFIGURED) {
> ret |= mlx5_vdpa_lm_log(priv);
> diff --git a/drivers/vdpa/mlx5/mlx5_vdpa_cthread.c b/drivers/vdpa/mlx5/mlx5_vdpa_cthread.c
> index 6e6624e5a3..1d84e422d4 100644
> --- a/drivers/vdpa/mlx5/mlx5_vdpa_cthread.c
> +++ b/drivers/vdpa/mlx5/mlx5_vdpa_cthread.c
> @@ -190,7 +190,6 @@ mlx5_vdpa_c_thread_handle(void *arg)
> pthread_mutex_unlock(&virtq->virtq_lock);
> break;
> case MLX5_VDPA_TASK_DEV_CLOSE_NOWAIT:
> - mlx5_vdpa_virtq_unreg_intr_handle_all(priv);
> pthread_mutex_lock(&priv->steer_update_lock);
> mlx5_vdpa_steer_unset(priv);
> pthread_mutex_unlock(&priv->steer_update_lock);
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Thanks,
Maxime
next prev parent reply other threads:[~2023-10-12 13:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-08 11:32 Yajun Wu
2023-10-12 13:44 ` Maxime Coquelin [this message]
2023-10-12 13:50 ` Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=166bee66-2be8-5850-deaf-6e00dd9b38ea@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=dev@dpdk.org \
--cc=lizh@nvidia.com \
--cc=matan@nvidia.com \
--cc=rasland@nvidia.com \
--cc=roniba@nvidia.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
--cc=viacheslavo@nvidia.com \
--cc=yajunw@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).