From: Thomas Monjalon <thomas@monjalon.net>
To: Raja Zidane <rzidane@nvidia.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
stable@dpdk.org, Matan Azrad <matan@nvidia.com>,
asafp@nvidia.com
Subject: Re: [dpdk-stable] [PATCH] compress/mlx5: fix level translation in xform API
Date: Tue, 03 Aug 2021 14:11:44 +0200 [thread overview]
Message-ID: <1675444.xmRWqXiWyl@thomas> (raw)
In-Reply-To: <DM4PR12MB5389D77C84A248DA89C832E0DFEE9@DM4PR12MB5389.namprd12.prod.outlook.com>
01/08/2021 08:13, Matan Azrad:
> From: Raja Zidane
> > Compression Level is interpreted by each PMD differently.
> > However, lower numbers give faster compression at the expense of
> > compression ratio, while higher numbers may give better compression ratios
> > but are likely slower.
> > The level affects the block size, which affects performance, the bigger the
> > block, the faster the compression is.
> >
> > The problem was that higher levels caused bigger blocks:
> > size = min_block_size - 1 + level.
> >
> > the solution is to reverse the above:
> > size = max_block_size + 1 - level.
> >
> > Fixes: 39a2c8715f8f ("compress/mlx5: add transformation operations")
> > Cc: matan@nvidia.com
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Raja Zidane <rzidane@nvidia.com>
>
> Congrats on your first patch, Raja!
The explanation above is very clear, thank you and
congratulations!
> Acked-by: Matan Azrad <matan@nvidia.com>
Applied, thanks.
prev parent reply other threads:[~2021-08-03 12:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-29 14:11 Raja Zidane
2021-07-31 17:57 ` [dpdk-stable] [EXT] [dpdk-dev] " Akhil Goyal
2021-08-01 6:13 ` [dpdk-stable] " Matan Azrad
2021-08-03 12:11 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1675444.xmRWqXiWyl@thomas \
--to=thomas@monjalon.net \
--cc=asafp@nvidia.com \
--cc=dev@dpdk.org \
--cc=matan@nvidia.com \
--cc=rzidane@nvidia.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).