From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E5A4FA0C40 for ; Tue, 3 Aug 2021 14:11:49 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DD4E7411D6; Tue, 3 Aug 2021 14:11:49 +0200 (CEST) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by mails.dpdk.org (Postfix) with ESMTP id 27A9540E3C; Tue, 3 Aug 2021 14:11:47 +0200 (CEST) Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 7BE995C00C2; Tue, 3 Aug 2021 08:11:46 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Tue, 03 Aug 2021 08:11:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= 6PaytX5I9o0Y2cRsGcE2FBDSDnthHK/WYpKnZcJKhsQ=; b=P7HyNOaV46HXS8ny NE6cvEczXPILSXMgGVx5vKOAGiSWrQr3vTaMsR4tO9w59Id8LSc87TkRyBjzZJa0 acIQ5zCTddaNq1+/elY4g5P3JWPfuJBitOGnaJlB9nLa/XVvMB6z2sHaLz9ihRiU pJO41EUu8MPvXze3JpXkNIMAF27OUav4Vg/o/Ar0JiLq+fZm4ZwCSsa1PomEjcjE KOIEgIvETYg7Qz65e+xkOeZeTRLyhmQRtlmgA+CZ1d3rl3FArcmBlnPPNxPGZ2SF sbIM0ODrrxQyn2I1QeWoAbiI92MOR9G/TwZqbucZHBsldTTqQgs4PKpEdwxKgK4X uLOxGA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=6PaytX5I9o0Y2cRsGcE2FBDSDnthHK/WYpKnZcJKh sQ=; b=DGOD/sRvooFgQQfiSzpd3uSF39NWF6W7jrvTgZPYxnQxjnOFvwJmsOzZh Za6FZBYE/yPLSqKmo3NbcniRG4XZo5Gi7Ki0TBlfGsTPlw3UJNuUke1KGq3JmkFH b90lNSN+MKjVfn9OlC4fvW/xL5DMSc6YLJYXpXxwlObbfOguUtW4U5zGoFu4SWXp kUKc0aXx4OLZ4Af6+fUiDSDjf5P8xf3G744wf1haYm1B3T9DneDO8CCuijeQ+fb5 n9nOI5q3Tyq4vu8yTrLNHWeS6KiDpLgWbMB8PqdOFftRTFc71sFgMNTgJMuygV2w mLc3QcirV1zDgQtpO01P/wmy+/dJA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrieeggdegjecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhroh hmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 3 Aug 2021 08:11:45 -0400 (EDT) From: Thomas Monjalon To: Raja Zidane Cc: "dev@dpdk.org" , stable@dpdk.org, Matan Azrad , asafp@nvidia.com Date: Tue, 03 Aug 2021 14:11:44 +0200 Message-ID: <1675444.xmRWqXiWyl@thomas> In-Reply-To: References: <20210729141108.20908-1-rzidane@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-stable] [PATCH] compress/mlx5: fix level translation in xform API X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" 01/08/2021 08:13, Matan Azrad: > From: Raja Zidane > > Compression Level is interpreted by each PMD differently. > > However, lower numbers give faster compression at the expense of > > compression ratio, while higher numbers may give better compression ratios > > but are likely slower. > > The level affects the block size, which affects performance, the bigger the > > block, the faster the compression is. > > > > The problem was that higher levels caused bigger blocks: > > size = min_block_size - 1 + level. > > > > the solution is to reverse the above: > > size = max_block_size + 1 - level. > > > > Fixes: 39a2c8715f8f ("compress/mlx5: add transformation operations") > > Cc: matan@nvidia.com > > Cc: stable@dpdk.org > > > > Signed-off-by: Raja Zidane > > Congrats on your first patch, Raja! The explanation above is very clear, thank you and congratulations! > Acked-by: Matan Azrad Applied, thanks.