patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Gavin Hu <gavin.hu@arm.com>
Cc: stable@dpdk.org, dev@dpdk.org, nd@arm.com
Subject: Re: [dpdk-stable] [PATCH v13 4/6] devtools: fix the missing ninja command error
Date: Wed, 27 Jun 2018 23:13:58 +0200	[thread overview]
Message-ID: <1678634.Uv4K4bE778@xps> (raw)
In-Reply-To: <20180625024913.17219-5-gavin.hu@arm.com>

25/06/2018 04:49, Gavin Hu:
> On some linux distributions, eg: CentOS, the ninja executable has a
> different name: ninja-build, this patch is to check and adapt to it
> accordingly.
> 
> ./devtools/test-meson-builds.sh: line 24: ninja: command not found
> 
> Fixes: a55277a788 ("devtools: add test script for meson builds")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Gavin Hu <gavin.hu@arm.com>
> Reviewed-by: Phil Yang <phil.yang@arm.com>
> Reviewed-by: Song Zhu <song.zhu@arm.com>
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
> --- a/devtools/test-meson-builds.sh
> +++ b/devtools/test-meson-builds.sh
> +if command -v ninja >/dev/null 2>&1 ; then
> +    ninja_cmd=ninja
> +elif command -v ninja-build >/dev/null 2>&1 ; then
> +    ninja_cmd=ninja-build
> +else
> +    echo "## ERROR: ninja is missing, please install..."

No need of double hash to get attention as it is the last printed line.
Matter of taste, but I prefer more simple (not interpreted) message like:
	"ERROR: ninja is not found"

Or even simpler, no message at all and try with ninja_cmd=ninja as default:

if command -v ninja-build >/dev/null 2>&1 ; then
	ninja_cmd=ninja-build
else
	ninja_cmd=ninja
fi

Will still have the shell message in case of ninja not installed:
	ninja: command not found

  reply	other threads:[~2018-06-27 21:14 UTC|newest]

Thread overview: 61+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20180614095127.16245-1-git-send-email-gavin.hu@arm.com>
     [not found] ` <20180615070811.18686-1-gavin.hu@arm.com>
2018-06-15  7:08   ` [dpdk-stable] [PATCH v7 1/7] mk: fix cross build errors Gavin Hu
2018-06-15  7:08   ` [dpdk-stable] [PATCH v7 3/7] devtools: fix the Exec format error Gavin Hu
2018-06-15  7:08   ` [dpdk-stable] [PATCH v7 4/7] build: fix the meson build warning Gavin Hu
2018-06-15  7:08   ` [dpdk-stable] [PATCH v7 5/7] devtools: fix the missing ninja command error on CentOS Gavin Hu
2018-06-15  7:08   ` [dpdk-stable] [PATCH v7 6/7] build: fix the meson cross compile error Gavin Hu
2018-06-15  7:08   ` [dpdk-stable] [PATCH v7 7/7] devtools: expand meson cross compiling coverage Gavin Hu
     [not found]   ` <20180615080120.29253-1-gavin.hu@arm.com>
2018-06-15  8:01     ` [dpdk-stable] [PATCH v8 1/6] mk: fix cross build errors Gavin Hu
2018-06-15  8:01     ` [dpdk-stable] [PATCH v8 3/6] build: fix the meson build warning Gavin Hu
2018-06-15  8:01     ` [dpdk-stable] [PATCH v8 4/6] devtools: fix the missing ninja command error on CentOS Gavin Hu
2018-06-15  8:24       ` [dpdk-stable] [dpdk-dev] " Bruce Richardson
2018-06-15  8:01     ` [dpdk-stable] [PATCH v8 5/6] build: fix the meson cross compile error Gavin Hu
2018-06-15  8:01     ` [dpdk-stable] [PATCH v8 6/6] devtools: expand meson cross compiling coverage Gavin Hu
2018-06-15  8:28       ` [dpdk-stable] [dpdk-dev] " Bruce Richardson
2018-06-15  9:31         ` Gavin Hu
     [not found]     ` <20180615092605.12043-1-gavin.hu@arm.com>
2018-06-15  9:26       ` [dpdk-stable] [PATCH v9 1/6] mk: fix makefile based cross build errors Gavin Hu
2018-06-15  9:26       ` [dpdk-stable] [PATCH v9 3/6] build: fix the meson build warning Gavin Hu
2018-06-15  9:26       ` [dpdk-stable] [PATCH v9 4/6] devtools: fix the missing ninja command error Gavin Hu
2018-06-15  9:59         ` [dpdk-stable] [dpdk-dev] " Bruce Richardson
2018-06-15  9:26       ` [dpdk-stable] [PATCH v9 5/6] build: fix the meson cross compile error Gavin Hu
2018-06-15  9:26       ` [dpdk-stable] [PATCH v9 6/6] devtools: expand meson cross compiling test coverage Gavin Hu
2018-06-15 10:01         ` [dpdk-stable] [dpdk-dev] " Bruce Richardson
     [not found]       ` <20180615102143.12778-1-gavin.hu@arm.com>
2018-06-15 10:21         ` [dpdk-stable] [PATCH v10 1/6] mk: fix makefile based cross build errors Gavin Hu
2018-06-15 10:21         ` [dpdk-stable] [PATCH v10 3/6] build: fix the meson build warning Gavin Hu
2018-06-15 10:21         ` [dpdk-stable] [PATCH v10 4/6] devtools: fix the missing ninja command error Gavin Hu
2018-06-15 13:27           ` [dpdk-stable] [dpdk-dev] " Bruce Richardson
2018-06-15 10:21         ` [dpdk-stable] [PATCH v10 5/6] build: fix the meson cross compile error Gavin Hu
2018-06-15 10:21         ` [dpdk-stable] [PATCH v10 6/6] devtools: expand meson cross compiling test coverage Gavin Hu
2018-06-15 14:14           ` [dpdk-stable] [dpdk-dev] " Bruce Richardson
2018-06-19  1:44             ` Gavin Hu
     [not found]         ` <20180619013746.13268-1-gavin.hu@arm.com>
2018-06-19  1:37           ` [dpdk-stable] [PATCH v11 1/6] mk: fix makefile based cross build errors Gavin Hu
2018-06-19  1:37           ` [dpdk-stable] [PATCH v11 3/6] build: fix the meson build warning Gavin Hu
2018-06-19  1:37           ` [dpdk-stable] [PATCH v11 4/6] devtools: fix the missing ninja command error Gavin Hu
2018-06-19 10:12             ` [dpdk-stable] [dpdk-dev] " Bruce Richardson
2018-06-19 10:41               ` Gavin Hu
2018-06-19 12:30                 ` Bruce Richardson
2018-06-19 23:58                   ` Gavin Hu
2018-06-19  1:37           ` [dpdk-stable] [PATCH v11 5/6] build: fix the meson cross compile error Gavin Hu
2018-06-19  1:37           ` [dpdk-stable] [PATCH v11 6/6] devtools: expand meson cross compiling test coverage Gavin Hu
2018-06-19 10:14             ` [dpdk-stable] [dpdk-dev] " Bruce Richardson
2018-06-19 10:15             ` Bruce Richardson
     [not found]           ` <20180619103657.19186-1-gavin.hu@arm.com>
2018-06-19 10:36             ` [dpdk-stable] [PATCH v12 1/6] mk: fix makefile based cross build errors Gavin Hu
2018-06-19 10:36             ` [dpdk-stable] [PATCH v12 3/6] build: fix the meson build warning Gavin Hu
2018-06-24 11:05               ` [dpdk-stable] [dpdk-dev] " Jerin Jacob
2018-06-19 10:36             ` [dpdk-stable] [PATCH v12 4/6] devtools: fix the missing ninja command error Gavin Hu
2018-06-19 10:36             ` [dpdk-stable] [PATCH v12 5/6] build: fix the meson cross compile error Gavin Hu
2018-06-19 10:36             ` [dpdk-stable] [PATCH v12 6/6] devtools: expand meson cross compiling test coverage Gavin Hu
2018-06-19 12:31               ` [dpdk-stable] [dpdk-dev] " Bruce Richardson
     [not found]             ` <20180625024913.17219-1-gavin.hu@arm.com>
2018-06-25  2:49               ` [dpdk-stable] [PATCH v13 1/6] mk: fix makefile based cross build errors Gavin Hu
2018-06-25 16:10                 ` [dpdk-stable] [dpdk-dev] " Ali Alnubani
2018-06-27 21:00                 ` [dpdk-stable] " Thomas Monjalon
2018-06-25  2:49               ` [dpdk-stable] [PATCH v13 3/6] build: fix the meson build warning Gavin Hu
2018-06-25 16:11                 ` [dpdk-stable] [dpdk-dev] " Ali Alnubani
2018-06-25  2:49               ` [dpdk-stable] [PATCH v13 4/6] devtools: fix the missing ninja command error Gavin Hu
2018-06-27 21:13                 ` Thomas Monjalon [this message]
2018-06-25  2:49               ` [dpdk-stable] [PATCH v13 5/6] build: fix the meson cross compile error Gavin Hu
2018-06-25  2:49               ` [dpdk-stable] [PATCH v13 6/6] devtools: expand meson cross compiling test coverage Gavin Hu
     [not found]               ` <20180629172738.2121-1-gavin.hu@arm.com>
2018-06-29 17:27                 ` [dpdk-stable] [PATCH v14 1/6] mk: fix makefile based cross build errors Gavin Hu
2018-06-29 17:27                 ` [dpdk-stable] [PATCH v14 3/6] build: fix the meson build warning Gavin Hu
2018-06-29 17:27                 ` [dpdk-stable] [PATCH v14 4/6] devtools: fix the missing ninja command error Gavin Hu
2018-06-29 17:27                 ` [dpdk-stable] [PATCH v14 5/6] build: fix the meson cross compile error Gavin Hu
2018-06-29 17:27                 ` [dpdk-stable] [PATCH v14 6/6] devtools: expand meson cross compiling test coverage Gavin Hu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1678634.Uv4K4bE778@xps \
    --to=thomas@monjalon.net \
    --cc=dev@dpdk.org \
    --cc=gavin.hu@arm.com \
    --cc=nd@arm.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).