From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stable-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 1D4DA43A2C
	for <public@inbox.dpdk.org>; Thu,  1 Feb 2024 03:31:41 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 12CE9402E4;
	Thu,  1 Feb 2024 03:31:41 +0100 (CET)
Received: from szxga04-in.huawei.com (szxga04-in.huawei.com [45.249.212.190])
 by mails.dpdk.org (Postfix) with ESMTP id A8E4F4028A;
 Thu,  1 Feb 2024 03:31:38 +0100 (CET)
Received: from mail.maildlp.com (unknown [172.19.88.214])
 by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4TQNDX0G7Gz1xmwM;
 Thu,  1 Feb 2024 10:30:36 +0800 (CST)
Received: from dggpeml500024.china.huawei.com (unknown [7.185.36.10])
 by mail.maildlp.com (Postfix) with ESMTPS id AFFE61A016B;
 Thu,  1 Feb 2024 10:31:36 +0800 (CST)
Received: from [10.67.121.161] (10.67.121.161) by
 dggpeml500024.china.huawei.com (7.185.36.10) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2507.35; Thu, 1 Feb 2024 10:31:36 +0800
Subject: Re: [PATCH 2/2] app/graph: fix build reason
To: David Marchand <david.marchand@redhat.com>, <dev@dpdk.org>
CC: <stable@dpdk.org>, Sunil Kumar Kori <skori@marvell.com>, Rakesh
 Kudurumalla <rkudurumalla@marvell.com>, Nithin Dabilpuram
 <ndabilpuram@marvell.com>
References: <20240131174552.2601531-1-david.marchand@redhat.com>
 <20240131174552.2601531-2-david.marchand@redhat.com>
From: fengchengwen <fengchengwen@huawei.com>
Message-ID: <1691cf7d-35d4-b6f6-5925-154fcc743d3e@huawei.com>
Date: Thu, 1 Feb 2024 10:31:36 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.11.0
MIME-Version: 1.0
In-Reply-To: <20240131174552.2601531-2-david.marchand@redhat.com>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.67.121.161]
X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To
 dggpeml500024.china.huawei.com (7.185.36.10)
X-BeenThere: stable@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: patches for DPDK stable branches <stable.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/stable>,
 <mailto:stable-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/stable/>
List-Post: <mailto:stable@dpdk.org>
List-Help: <mailto:stable-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/stable>,
 <mailto:stable-request@dpdk.org?subject=subscribe>
Errors-To: stable-bounces@dpdk.org

Acked-by: Chengwen Feng <fengchengwen@huawei.com>

On 2024/2/1 1:45, David Marchand wrote:
> When a component is disabled, the reason meson variable must be set to
> provide an explanation why.
> 
> Since epoll is a Linux thing, report that the graph application is only
> supported on Linux.
> 
> Fixes: 5b21ffb23308 ("app/graph: add CLI framework")
> Cc: stable@dpdk.org
> 
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
>  app/graph/meson.build | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/app/graph/meson.build b/app/graph/meson.build
> index 5b0f966d99..8aefdf505c 100644
> --- a/app/graph/meson.build
> +++ b/app/graph/meson.build
> @@ -5,6 +5,7 @@
>  name = 'graph'
>  build = cc.has_header('sys/epoll.h')
>  if not build
> +    reason = 'only supported on Linux'
>      subdir_done()
>  endif
>  
>