From: Thomas Monjalon <thomas@monjalon.net>
To: "Zhao1, Wei" <wei.zhao1@intel.com>
Cc: stable@dpdk.org, "Wang, Dong1" <dong1.wang@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"Zhang, Qi Z" <qi.z.zhang@intel.com>,
"Yigit, Ferruh" <ferruh.yigit@intel.com>
Subject: Re: [dpdk-stable] [PATCH] examples/ipv4_multicast: enable multicast promiscuous for all port
Date: Mon, 29 Oct 2018 03:01:35 +0100 [thread overview]
Message-ID: <1715298.C9zz0hs5BT@xps> (raw)
In-Reply-To: <3E2E5017C928014B90FD7864A64F0B5514F64677@SHSMSX103.ccr.corp.intel.com>
24/10/2018 10:50, Wang, Dong1:
> Tested it with 82599 PF.
>
> Acked-by: Wang Dong <dong1.wang@intel.com>
The correct tag is probably Tested-by
> From: Zhao1, Wei
>
> Add Wang Dong in the mailing list, he has test this patch.
>
> > > This example has not been enable for receiving multicast packet, so
> > > it will drop multicast packet. Users must send packet with ether MAC
> > > destination address the same as pf port MAC address, in order to
> > > forward packet successfully, but this is an example for forwarding
> > > ipv4 multicastpacket. So calling function
> > > rte_eth_promiscuous_enable() or rte_eth_allmulticast_enable() can
> > > enable promiscuous mode of all multicast packet. And aslo, DPDK has
> > > rte API function of rte_eth_dev_set_mc_addr_list() for setting
> > > specific multicast filter table for specific multicast IP address,
> > > but this example do not support this configuration, so it need to be
> > > enable multicast promiscuous mode instead.
> > >
> > > Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
Applied, thanks
prev parent reply other threads:[~2018-10-29 2:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-17 7:41 Wei Zhao
2018-10-17 8:09 ` Zhao1, Wei
2018-10-24 8:11 ` Zhao1, Wei
2018-10-24 8:50 ` Wang, Dong1
2018-10-25 2:07 ` Zhao1, Wei
2018-10-29 2:01 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1715298.C9zz0hs5BT@xps \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=dong1.wang@intel.com \
--cc=ferruh.yigit@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=stable@dpdk.org \
--cc=wei.zhao1@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).