patches for DPDK stable branches
 help / color / Atom feed
* [dpdk-stable] [dpdk-dev] [PATCH] raw/dpaa2_qdma: fix missing parentheses
@ 2020-09-07 13:41 wangyunjian
  2020-09-09  1:11 ` [dpdk-stable] [dpdk-dev] [PATCH v2] " wangyunjian
  0 siblings, 1 reply; 5+ messages in thread
From: wangyunjian @ 2020-09-07 13:41 UTC (permalink / raw)
  To: dev; +Cc: nipun.gupta, jerry.lilijun, xudingke, Yunjian Wang, stable

From: Yunjian Wang <wangyunjian@huawei.com>

Thist issue detected by coverity, CID#279443(Structurally dead code).

Coverity issue: 279443
Fixes: c22fab9a6c34 ("raw/dpaa2_qdma: support configuration APIs")
Cc: stable@dpdk.org

Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>
---
 drivers/raw/dpaa2_qdma/dpaa2_qdma.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/raw/dpaa2_qdma/dpaa2_qdma.c b/drivers/raw/dpaa2_qdma/dpaa2_qdma.c
index 0b9c4e3d7..4b8474951 100644
--- a/drivers/raw/dpaa2_qdma/dpaa2_qdma.c
+++ b/drivers/raw/dpaa2_qdma/dpaa2_qdma.c
@@ -452,9 +452,10 @@ rte_qdma_reset(void)
 	/* In case there are pending jobs on any VQ, return -EBUSY */
 	for (i = 0; i < qdma_dev.max_vqs; i++) {
 		if (qdma_vqs[i].in_use && (qdma_vqs[i].num_enqueues !=
-		    qdma_vqs[i].num_dequeues))
+		    qdma_vqs[i].num_dequeues)) {
 			DPAA2_QDMA_ERR("Jobs are still pending on VQ: %d", i);
 			return -EBUSY;
+		}
 	}
 
 	/* Reset HW queues */
-- 
2.18.1



^ permalink raw reply	[flat|nested] 5+ messages in thread

* [dpdk-stable] [dpdk-dev] [PATCH v2] raw/dpaa2_qdma: fix missing parentheses
  2020-09-07 13:41 [dpdk-stable] [dpdk-dev] [PATCH] raw/dpaa2_qdma: fix missing parentheses wangyunjian
@ 2020-09-09  1:11 ` " wangyunjian
  2020-10-06 21:33   ` Thomas Monjalon
  2020-10-07  5:35   ` Nipun Gupta
  0 siblings, 2 replies; 5+ messages in thread
From: wangyunjian @ 2020-09-09  1:11 UTC (permalink / raw)
  To: dev; +Cc: nipun.gupta, jerry.lilijun, xudingke, Yunjian Wang, stable

From: Yunjian Wang <wangyunjian@huawei.com>

This issue detected by coverity, CID#279443(Structurally dead code).

Coverity issue: 279443
Fixes: c22fab9a6c34 ("raw/dpaa2_qdma: support configuration APIs")
Cc: stable@dpdk.org

Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>
---
v2: fix spelling in commit log
---
 drivers/raw/dpaa2_qdma/dpaa2_qdma.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/raw/dpaa2_qdma/dpaa2_qdma.c b/drivers/raw/dpaa2_qdma/dpaa2_qdma.c
index 0b9c4e3d7..4b8474951 100644
--- a/drivers/raw/dpaa2_qdma/dpaa2_qdma.c
+++ b/drivers/raw/dpaa2_qdma/dpaa2_qdma.c
@@ -452,9 +452,10 @@ rte_qdma_reset(void)
 	/* In case there are pending jobs on any VQ, return -EBUSY */
 	for (i = 0; i < qdma_dev.max_vqs; i++) {
 		if (qdma_vqs[i].in_use && (qdma_vqs[i].num_enqueues !=
-		    qdma_vqs[i].num_dequeues))
+		    qdma_vqs[i].num_dequeues)) {
 			DPAA2_QDMA_ERR("Jobs are still pending on VQ: %d", i);
 			return -EBUSY;
+		}
 	}
 
 	/* Reset HW queues */
-- 
2.18.1



^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dpdk-stable] [dpdk-dev] [PATCH v2] raw/dpaa2_qdma: fix missing parentheses
  2020-09-09  1:11 ` [dpdk-stable] [dpdk-dev] [PATCH v2] " wangyunjian
@ 2020-10-06 21:33   ` Thomas Monjalon
  2020-10-07  5:35   ` Nipun Gupta
  1 sibling, 0 replies; 5+ messages in thread
From: Thomas Monjalon @ 2020-10-06 21:33 UTC (permalink / raw)
  To: nipun.gupta
  Cc: dev, jerry.lilijun, xudingke, Yunjian Wang, stable, wangyunjian,
	hemant.agrawal

Nipun, could you review please?

09/09/2020 03:11, wangyunjian:
> From: Yunjian Wang <wangyunjian@huawei.com>
> 
> This issue detected by coverity, CID#279443(Structurally dead code).
> 
> Coverity issue: 279443
> Fixes: c22fab9a6c34 ("raw/dpaa2_qdma: support configuration APIs")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>
> ---
> v2: fix spelling in commit log
> ---
>  drivers/raw/dpaa2_qdma/dpaa2_qdma.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/raw/dpaa2_qdma/dpaa2_qdma.c b/drivers/raw/dpaa2_qdma/dpaa2_qdma.c
> index 0b9c4e3d7..4b8474951 100644
> --- a/drivers/raw/dpaa2_qdma/dpaa2_qdma.c
> +++ b/drivers/raw/dpaa2_qdma/dpaa2_qdma.c
> @@ -452,9 +452,10 @@ rte_qdma_reset(void)
>  	/* In case there are pending jobs on any VQ, return -EBUSY */
>  	for (i = 0; i < qdma_dev.max_vqs; i++) {
>  		if (qdma_vqs[i].in_use && (qdma_vqs[i].num_enqueues !=
> -		    qdma_vqs[i].num_dequeues))
> +		    qdma_vqs[i].num_dequeues)) {
>  			DPAA2_QDMA_ERR("Jobs are still pending on VQ: %d", i);
>  			return -EBUSY;
> +		}
>  	}
>  
>  	/* Reset HW queues */
> 






^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dpdk-stable] [dpdk-dev] [PATCH v2] raw/dpaa2_qdma: fix missing parentheses
  2020-09-09  1:11 ` [dpdk-stable] [dpdk-dev] [PATCH v2] " wangyunjian
  2020-10-06 21:33   ` Thomas Monjalon
@ 2020-10-07  5:35   ` Nipun Gupta
  2020-10-11 20:06     ` Thomas Monjalon
  1 sibling, 1 reply; 5+ messages in thread
From: Nipun Gupta @ 2020-10-07  5:35 UTC (permalink / raw)
  To: wangyunjian, dev; +Cc: jerry.lilijun, xudingke, stable

Acked by: Nipun Gupta <nipun.gupta@nxp.com>

> -----Original Message-----
> From: wangyunjian <wangyunjian@huawei.com>
> Sent: Wednesday, September 9, 2020 6:42 AM
> To: dev@dpdk.org
> Cc: Nipun Gupta <nipun.gupta@nxp.com>; jerry.lilijun@huawei.com;
> xudingke@huawei.com; Yunjian Wang <wangyunjian@huawei.com>;
> stable@dpdk.org
> Subject: [dpdk-dev] [PATCH v2] raw/dpaa2_qdma: fix missing parentheses
> 
> From: Yunjian Wang <wangyunjian@huawei.com>
> 
> This issue detected by coverity, CID#279443(Structurally dead code).
> 
> Coverity issue: 279443
> Fixes: c22fab9a6c34 ("raw/dpaa2_qdma: support configuration APIs")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>
> ---
> v2: fix spelling in commit log
> ---
>  drivers/raw/dpaa2_qdma/dpaa2_qdma.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/raw/dpaa2_qdma/dpaa2_qdma.c
> b/drivers/raw/dpaa2_qdma/dpaa2_qdma.c
> index 0b9c4e3d7..4b8474951 100644
> --- a/drivers/raw/dpaa2_qdma/dpaa2_qdma.c
> +++ b/drivers/raw/dpaa2_qdma/dpaa2_qdma.c
> @@ -452,9 +452,10 @@ rte_qdma_reset(void)
>  	/* In case there are pending jobs on any VQ, return -EBUSY */
>  	for (i = 0; i < qdma_dev.max_vqs; i++) {
>  		if (qdma_vqs[i].in_use && (qdma_vqs[i].num_enqueues !=
> -		    qdma_vqs[i].num_dequeues))
> +		    qdma_vqs[i].num_dequeues)) {
>  			DPAA2_QDMA_ERR("Jobs are still pending on VQ: %d",
> i);
>  			return -EBUSY;
> +		}
>  	}
> 
>  	/* Reset HW queues */
> --
> 2.18.1
> 


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dpdk-stable] [dpdk-dev] [PATCH v2] raw/dpaa2_qdma: fix missing parentheses
  2020-10-07  5:35   ` Nipun Gupta
@ 2020-10-11 20:06     ` Thomas Monjalon
  0 siblings, 0 replies; 5+ messages in thread
From: Thomas Monjalon @ 2020-10-11 20:06 UTC (permalink / raw)
  To: wangyunjian, Nipun Gupta; +Cc: dev, stable, jerry.lilijun, xudingke

> > This issue detected by coverity, CID#279443(Structurally dead code).
> > 
> > Coverity issue: 279443
> > Fixes: c22fab9a6c34 ("raw/dpaa2_qdma: support configuration APIs")
> > Cc: stable@dpdk.org
> > 
> > Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>
> > ---
> > --- a/drivers/raw/dpaa2_qdma/dpaa2_qdma.c
> > +++ b/drivers/raw/dpaa2_qdma/dpaa2_qdma.c
> > @@ -452,9 +452,10 @@ rte_qdma_reset(void)
> >  	/* In case there are pending jobs on any VQ, return -EBUSY */
> >  	for (i = 0; i < qdma_dev.max_vqs; i++) {
> >  		if (qdma_vqs[i].in_use && (qdma_vqs[i].num_enqueues !=
> > -		    qdma_vqs[i].num_dequeues))
> > +		    qdma_vqs[i].num_dequeues)) {
> >  			DPAA2_QDMA_ERR("Jobs are still pending on VQ: %d",
> > i);
> >  			return -EBUSY;
> > +		}
> >  	}

Acked by: Nipun Gupta <nipun.gupta@nxp.com>

I don't understand how it could work before in simplest case.
Changed title to "fix reset".

Applied, thanks



^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, back to index

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-07 13:41 [dpdk-stable] [dpdk-dev] [PATCH] raw/dpaa2_qdma: fix missing parentheses wangyunjian
2020-09-09  1:11 ` [dpdk-stable] [dpdk-dev] [PATCH v2] " wangyunjian
2020-10-06 21:33   ` Thomas Monjalon
2020-10-07  5:35   ` Nipun Gupta
2020-10-11 20:06     ` Thomas Monjalon

patches for DPDK stable branches

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ http://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/ public-inbox