From: Thomas Monjalon <thomas@monjalon.net>
To: Zhiyong Yang <zhiyong.yang@intel.com>
Cc: dev@dpdk.org, stable@dpdk.org, jianfeng.tan@intel.com,
yliu@fridaylinux.org, maxime.coquelin@redhat.com
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v6] net/virtio: fix rxq intr config fails using vfio-pci
Date: Sat, 11 Nov 2017 15:34:13 +0100 [thread overview]
Message-ID: <1724984.eyEFnyz4nt@xps> (raw)
In-Reply-To: <20171109092124.54380-1-zhiyong.yang@intel.com>
09/11/2017 10:21, Zhiyong Yang:
> When running l3fwd-power to test virtio rxq interrupt using vfio
> pci noiommu mode, startup fails. In the function virtio_read_caps,
> the code if (flags & PCI_MSIX_ENABLE) intends to double check
> if vfio msix is enabled or not. However, it is not enable at that
> time. So use_msix is assigned to "0", not "1", which causes the
> failure of configuring rxq intr in l3fwd-power.
> This patch adds the function "vtpci_msix_detect" to detect the status
> of msix when interrupt changes happen.
> In the meanwhile, virtio_intr_enable/disable are introduced to wrap
> rte_intr_enable/disable to enhance the ability to detect msix.
> use_msix can indicate three different msix status by:
> VIRTIO_MSIX_NONE (0)
> VIRTIO_MSIX_DISABLED (1)
> VIRTIO_MSIX_ENABLED (2)
>
> CC: stable@dpdk.org
> CC: jianfeng.tan@intel.com
> CC: yliu@fridaylinux.org
> CC: maxime.coquelin@redhat.com
>
> Fixes: cb482cb3a305 ("net/virtio: fix MAC address read")
> Signed-off-by: Zhiyong Yang <zhiyong.yang@intel.com>
> Acked-by: Jianfeng Tan <jianfeng.tan@intel.com>
> Acked-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Applied, thanks
prev parent reply other threads:[~2017-11-11 14:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20171109031818.31040-1-zhiyong.yang@intel.com>
2017-11-09 4:46 ` [dpdk-stable] [PATCH v4] " Zhiyong Yang
2017-11-09 6:51 ` Tan, Jianfeng
2017-11-09 8:18 ` Maxime Coquelin
2017-11-09 8:55 ` [dpdk-stable] [PATCH v5] " Zhiyong Yang
2017-11-09 9:08 ` Maxime Coquelin
2017-11-09 9:16 ` Yang, Zhiyong
2017-11-09 9:21 ` [dpdk-stable] [PATCH v6] " Zhiyong Yang
2017-11-11 14:34 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1724984.eyEFnyz4nt@xps \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=jianfeng.tan@intel.com \
--cc=maxime.coquelin@redhat.com \
--cc=stable@dpdk.org \
--cc=yliu@fridaylinux.org \
--cc=zhiyong.yang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).