* [dpdk-stable] [DPDK] bus/ifpga: fix ifpga afu driver probe failure handler [not found] <1547430043-62302-1-git-send-email-andy.pei@intel.com> @ 2019-01-17 5:36 ` Andy Pei 2019-01-18 11:12 ` [dpdk-stable] [PATCH v2] " Ferruh Yigit 0 siblings, 1 reply; 3+ messages in thread From: Andy Pei @ 2019-01-17 5:36 UTC (permalink / raw) To: dev; +Cc: rosen.xu, andy.pei, stable From: AndyPei <andy.pei@intel.com> In the original code, when an AFU device probe a driver, if the first driver in the driver list does not support this device or some error happens, an error is returned. With this patch, a device wil try to match driver in the driver list one by one until an appropriate driver is found. If some error happens, the error is returned. If the current driver does not support the device, just try the next driver in the list. If all the drivers in the list are tried and no driver matches, 0 is returned. Otherwise, the error code is returned. Fixes: 05fa3d4a6539 ("bus/ifpga: add Intel FPGA bus library") Cc: stable@dpdk.org Signed-off-by: AndyPei <andy.pei@intel.com> --- drivers/bus/ifpga/ifpga_bus.c | 17 ++++++++++++----- 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/drivers/bus/ifpga/ifpga_bus.c b/drivers/bus/ifpga/ifpga_bus.c index e4b7b6f..55d3abf 100644 --- a/drivers/bus/ifpga/ifpga_bus.c +++ b/drivers/bus/ifpga/ifpga_bus.c @@ -306,12 +306,19 @@ void rte_ifpga_driver_unregister(struct rte_afu_driver *driver) } TAILQ_FOREACH(drv, &ifpga_afu_drv_list, next) { - if (ifpga_probe_one_driver(drv, afu_dev)) { - ret = -1; - break; - } + ret = ifpga_probe_one_driver(drv, afu_dev); + if (ret < 0) + /* negative value is an error */ + return ret; + if (ret > 0) + /* positive value means driver doesn't support it */ + continue; + return 0; } - return ret; + if ((ret > 0) && (afu_dev->driver == NULL)) + return 0; + else + return ret; } /* -- 1.8.3.1 ^ permalink raw reply [flat|nested] 3+ messages in thread
* [dpdk-stable] [PATCH v2] bus/ifpga: fix ifpga afu driver probe failure handler 2019-01-17 5:36 ` [dpdk-stable] [DPDK] bus/ifpga: fix ifpga afu driver probe failure handler Andy Pei @ 2019-01-18 11:12 ` Ferruh Yigit 2019-01-18 19:06 ` Thomas Monjalon 0 siblings, 1 reply; 3+ messages in thread From: Ferruh Yigit @ 2019-01-18 11:12 UTC (permalink / raw) To: dev, Rosen Xu; +Cc: Andy Pei, stable From: Andy Pei <andy.pei@intel.com> In the original code, when an AFU device probe a driver, if the first driver in the driver list does not support this device or some error happens, bus probe returns an error. With this patch, a device will try to match driver in the driver list one by one until an appropriate driver is found. If some error happens, the error is returned. If the current driver does not support the device, just try the next driver in the list. If all the drivers in the list are tried and no driver matches, 0 is returned. Otherwise, the error code is returned. Fixes: 05fa3d4a6539 ("bus/ifpga: add Intel FPGA bus library") Cc: stable@dpdk.org Signed-off-by: Andy Pei <andy.pei@intel.com> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com> Acked-by: Rosen Xu <rosen.xu@intel.com> --- drivers/bus/ifpga/ifpga_bus.c | 17 ++++++++++++----- 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/drivers/bus/ifpga/ifpga_bus.c b/drivers/bus/ifpga/ifpga_bus.c index e4b7b6f50..55d3abf9f 100644 --- a/drivers/bus/ifpga/ifpga_bus.c +++ b/drivers/bus/ifpga/ifpga_bus.c @@ -306,12 +306,19 @@ ifpga_probe_all_drivers(struct rte_afu_device *afu_dev) } TAILQ_FOREACH(drv, &ifpga_afu_drv_list, next) { - if (ifpga_probe_one_driver(drv, afu_dev)) { - ret = -1; - break; - } + ret = ifpga_probe_one_driver(drv, afu_dev); + if (ret < 0) + /* negative value is an error */ + return ret; + if (ret > 0) + /* positive value means driver doesn't support it */ + continue; + return 0; } - return ret; + if ((ret > 0) && (afu_dev->driver == NULL)) + return 0; + else + return ret; } /* -- 2.17.2 ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-stable] [PATCH v2] bus/ifpga: fix ifpga afu driver probe failure handler 2019-01-18 11:12 ` [dpdk-stable] [PATCH v2] " Ferruh Yigit @ 2019-01-18 19:06 ` Thomas Monjalon 0 siblings, 0 replies; 3+ messages in thread From: Thomas Monjalon @ 2019-01-18 19:06 UTC (permalink / raw) To: Ferruh Yigit, Andy Pei; +Cc: stable, dev, Rosen Xu 18/01/2019 12:12, Ferruh Yigit: > From: Andy Pei <andy.pei@intel.com> > > In the original code, when an AFU device probe a driver, > if the first driver in the driver list does not support > this device or some error happens, bus probe returns an error. > > With this patch, a device will try to match driver in the driver > list one by one until an appropriate driver is found. > > If some error happens, the error is returned. If the current driver > does not support the device, just try the next driver in the list. > > If all the drivers in the list are tried and no driver matches, > 0 is returned. Otherwise, the error code is returned. > > Fixes: 05fa3d4a6539 ("bus/ifpga: add Intel FPGA bus library") > Cc: stable@dpdk.org > > Signed-off-by: Andy Pei <andy.pei@intel.com> > Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com> > Acked-by: Rosen Xu <rosen.xu@intel.com> Applied, thanks ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-01-18 19:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1547430043-62302-1-git-send-email-andy.pei@intel.com>
2019-01-17 5:36 ` [dpdk-stable] [DPDK] bus/ifpga: fix ifpga afu driver probe failure handler Andy Pei
2019-01-18 11:12 ` [dpdk-stable] [PATCH v2] " Ferruh Yigit
2019-01-18 19:06 ` Thomas Monjalon
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).