From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 77D0AA0A0F for ; Tue, 29 Jun 2021 15:41:31 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 661724120C; Tue, 29 Jun 2021 15:41:31 +0200 (CEST) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by mails.dpdk.org (Postfix) with ESMTP id 3DC0640E01; Tue, 29 Jun 2021 15:41:28 +0200 (CEST) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 8BDA65C01BC; Tue, 29 Jun 2021 09:41:27 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Tue, 29 Jun 2021 09:41:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= sqBR5Zqm+q9f4GuNEqDx+RPCDk/HaSllVEgZOs47NBE=; b=sMZyXTNofWPOU3NF 6MmTK1hDyuR4CPHY9itgOqfIhqLlFwKEzO1KFoP9i0/QePX4sbT27eKztTgGU2Jf 2cI21fu9pbm9ONUMJuz3jDKHNA9Ook3GK/M9Fx1s1ItZ0DCCGTMeeL0pZWrCQShb El6f5cRTiLCLCmSNBXpwcQUetxqveHQebCLN6Ruc+1g5PyQANGORp/6zF6SG/3Oh 3ZH3sUB10HLuYnfMqpX9j5+ZEqGgOhtbtcdZR8Xzz+5VsBlXYDwYN8DukenChqne yeBkTmBEwt28XgbBdbjjcV+vDgmDAdJf+404jY1yfRcAHp+zAwxnyRK1vY2iBLem Xw7HgA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=sqBR5Zqm+q9f4GuNEqDx+RPCDk/HaSllVEgZOs47N BE=; b=kjWlW78aJmbcWvqBApRHthmxgE9Nt+6SAROeyh2BEH+0xs0ZZZe5hOMTy whNO1s93/WGpJMgGUokQWC2HzfNZIRuJjMjTrGlPIsLKRIq3YVIvfJ83Uz/7LT+v neRxHuwUQYrVzIKiXpMAVYaYDQphDYji/QnW7Ky2ADJyBhGauVh++m+0UBiM1Iu9 6RC+CwHyLGzMjTQKeQO2JnttfO8bqOJ6QrL5ppDta+uaWl/7wOyjIguwoLJccFsX E0pWmBkjMQp9bN7StfU/7QgnrDHOiq4+HX8bMtraLjH/THPzdq8M6B8oFfsfSZt2 TiNV0ibw86Si5f00Ak4zXGH9Gio5g== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrfeeitddgfeeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 29 Jun 2021 09:41:26 -0400 (EDT) From: Thomas Monjalon To: "Dumitrescu, Cristian" , Thierry Herbelot Cc: "dev@dpdk.org" , "stable@dpdk.org" , david.marchand@redhat.com Date: Tue, 29 Jun 2021 15:41:24 +0200 Message-ID: <1770440.SLloOXSvDy@thomas> In-Reply-To: References: <20210524085341.15184-1-thierry.herbelot@6wind.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-stable] [PATCH v2] table: fix typo X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" 29/06/2021 13:35, Dumitrescu, Cristian: > From: dev On Behalf Of Dumitrescu, Cristian > > From: Thomas Monjalon > > > 21/06/2021 17:54, Thierry Herbelot: > > > > On 6/21/21 5:44 PM, Dumitrescu, Cristian wrote: > > > > > From: Thierry Herbelot > > > > >> On 6/17/21 9:01 AM, Thomas Monjalon wrote: > > > > >>>>> Check Bucket key for all possible indices. > > > > >>>>> > > > > >>>>> Fixes: d0a00966618ba ("table: add exact match SWX table") > > > > >>>>> Cc: stable@dpdk.org > > > > >>>>> Cc: Cristian Dumitrescu > > > > >>>>> > > > > >>>>> Signed-off-by: Thierry Herbelot > > > > >>> [...] > > > > >>>>> - return (!bkt->sig[0] && !bkt->sig[1] && !bkt->sig[2] && !bkt- > > > >sig[2]) > > > > >>>>> + return (!bkt->sig[0] && !bkt->sig[1] && !bkt->sig[2] && !bkt- > > > >sig[3]) > > > > >>>> > > > > >>>> Acked-by: Cristian Dumitrescu > > > > >>>> > > > > >>>> Thierry, thanks again, you could have actually added my ack from V1 > > > :) > > > > >>> > > > > >>> The root cause looks to be a typo indeed, > > > > >>> but the impact or the scope of the issue > > > > >>> should stated in few words in the title please. > > > > >>> No need to send a v3, please suggest a title and I will apply. > > > > >> > > > > >> table: check a bucket is empty for all bucket keys > > > > >> > > > > >> Thierry > > > > >> > > > > > > > > > > Hi Thierry, > > > > > > > > > > I think Thomas is asking for you to send a new version of this patch with > > > the title updated. Is this OK with you? > > > > > > No need to send a v3. > > > > OK, so you're going to fix the title while applying? Thanks, Thomas. > > Hi Thomas, > > I see this fix is not yet applied, is there any action required? The proposed title is not fantastic. Last one is: table: all keys must be checked to declare that a bucket is empty I just need a title showing what is fixed. What is the impact of the bug in bkt_is_empty()?