From: Thomas Monjalon <thomas@monjalon.net>
To: David Marchand <david.marchand@redhat.com>
Cc: dev@dpdk.org, anatoly.burakov@intel.com,
alex.williamson@redhat.com, maxime.coquelin@redhat.com,
stephen@networkplumber.org, igor.russkikh@aquantia.com,
pavel.belous@aquantia.com, allain.legacy@windriver.com,
matt.peters@windriver.com, ravi1.kumar@amd.com,
rmody@marvell.com, shshaikh@marvell.com,
ajit.khaparde@broadcom.com, somnath.kotur@broadcom.com,
hemant.agrawal@nxp.com, shreyansh.jain@nxp.com,
wenzhuo.lu@intel.com, mw@semihalf.com, mk@semihalf.com,
gtzalik@amazon.com, evgenys@amazon.com, johndale@cisco.com,
hyonkim@cisco.com, qi.z.zhang@intel.com, xiao.w.wang@intel.com,
xuanziyang2@huawei.com, cloud.wangxiaoyun@huawei.com,
zhouguoyang@huawei.com, beilei.xing@intel.com,
jingjing.wu@intel.com, qiming.yang@intel.com,
konstantin.ananyev@intel.com, alejandro.lucero@netronome.com,
arybchenko@solarflare.com, tiwei.bie@intel.com,
zhihong.wang@intel.com, yongwang@vmware.com, stable@dpdk.org
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] vfio: fix interrupts race condition
Date: Wed, 10 Jul 2019 23:20:51 +0200 [thread overview]
Message-ID: <1796500.5oFe8j95cd@xps> (raw)
In-Reply-To: <1562762020-8259-1-git-send-email-david.marchand@redhat.com>
10/07/2019 14:33, David Marchand:
> Populating the eventfd in rte_intr_enable in each request to vfio
> triggers a reconfiguration of the interrupt handler on the kernel side.
> The problem is that rte_intr_enable is often used to re-enable masked
> interrupts from drivers interrupt handlers.
>
> This reconfiguration leaves a window during which a device could send
> an interrupt and then the kernel logs this (unsolicited from the kernel
> point of view) interrupt:
> [158764.159833] do_IRQ: 9.34 No irq handler for vector
>
> VFIO api makes it possible to set the fd at setup time.
> Make use of this and then we only need to ask for masking/unmasking
> legacy interrupts and we have nothing to do for MSI/MSIX.
>
> "rxtx" interrupts are left untouched but are most likely subject to the
> same issue.
>
> Fixes: 5c782b3928b8 ("vfio: interrupts")
> Cc: stable@dpdk.org
>
> Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=1654824
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> Tested-by: Shahed Shaikh <shshaikh@marvell.com>
This is a real bug which should be fixed in this release.
As the patch is quite big and needs a strong validation,
I prefer merging it quickly to give a lot of time before
releasing 19.08-rc2.
The maintainers of all concerned PMDs are Cc.
Please make sure the interrupts are still working well with VFIO.
Applied, thanks
next prev parent reply other threads:[~2019-07-10 21:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1562071706-11009-1-git-send-email-david.marchand@redhat.com>
2019-07-10 12:33 ` [dpdk-stable] " David Marchand
2019-07-10 21:20 ` Thomas Monjalon [this message]
2019-07-14 5:10 ` [dpdk-stable] [dpdk-dev] " Hyong Youb Kim (hyonkim)
2019-07-14 11:19 ` Thomas Monjalon
2019-07-15 5:35 ` Jerin Jacob Kollanukkaran
2019-07-15 7:20 ` Hyong Youb Kim (hyonkim)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1796500.5oFe8j95cd@xps \
--to=thomas@monjalon.net \
--cc=ajit.khaparde@broadcom.com \
--cc=alejandro.lucero@netronome.com \
--cc=alex.williamson@redhat.com \
--cc=allain.legacy@windriver.com \
--cc=anatoly.burakov@intel.com \
--cc=arybchenko@solarflare.com \
--cc=beilei.xing@intel.com \
--cc=cloud.wangxiaoyun@huawei.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=evgenys@amazon.com \
--cc=gtzalik@amazon.com \
--cc=hemant.agrawal@nxp.com \
--cc=hyonkim@cisco.com \
--cc=igor.russkikh@aquantia.com \
--cc=jingjing.wu@intel.com \
--cc=johndale@cisco.com \
--cc=konstantin.ananyev@intel.com \
--cc=matt.peters@windriver.com \
--cc=maxime.coquelin@redhat.com \
--cc=mk@semihalf.com \
--cc=mw@semihalf.com \
--cc=pavel.belous@aquantia.com \
--cc=qi.z.zhang@intel.com \
--cc=qiming.yang@intel.com \
--cc=ravi1.kumar@amd.com \
--cc=rmody@marvell.com \
--cc=shreyansh.jain@nxp.com \
--cc=shshaikh@marvell.com \
--cc=somnath.kotur@broadcom.com \
--cc=stable@dpdk.org \
--cc=stephen@networkplumber.org \
--cc=tiwei.bie@intel.com \
--cc=wenzhuo.lu@intel.com \
--cc=xiao.w.wang@intel.com \
--cc=xuanziyang2@huawei.com \
--cc=yongwang@vmware.com \
--cc=zhihong.wang@intel.com \
--cc=zhouguoyang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).