From: Thomas Monjalon <thomas@monjalon.net>
To: Michael Santana <msantana@redhat.com>
Cc: stable@dpdk.org, dev@dpdk.org,
Bruce Richardson <bruce.richardson@intel.com>,
Van Haaren Harry <harry.van.haaren@intel.com>,
ramirose@gmail.com
Subject: Re: [dpdk-stable] [PATCH v3 1/2] Enable codespell by default. Can be disabled from config file.
Date: Fri, 01 Mar 2019 18:43:33 +0100 [thread overview]
Message-ID: <1799922.WJ13kK0DMs@xps> (raw)
In-Reply-To: <20190301170806.3547-2-msantana@redhat.com>
01/03/2019 18:08, Michael Santana:
> +# Enable codespell by default. This can be overwritten from a config file.
> +# You can also enable codespell by setting DPDK_CHECKPATCH_CODESPELL to a valid path
> +# to a dictionary.txt file if your dictionary.txt is not in the default location.
Better to avoid "you" form in such comment.
> +DPDK_CHECKPATCH_CODESPELL=enable
> # Load config options:
> # - DPDK_CHECKPATCH_PATH
> # - DPDK_CHECKPATCH_LINE_LENGTH
> +# - DPDK_CHECKPATCH_CODESPELL
> . $(dirname $(readlink -e $0))/load-devel-config
>
> VALIDATE_NEW_API=$(dirname $(readlink -e $0))/check-symbol-change.sh
> @@ -13,6 +18,12 @@ length=${DPDK_CHECKPATCH_LINE_LENGTH:-80}
>
> # override default Linux options
> options="--no-tree"
> +if [ "$DPDK_CHECKPATCH_CODESPELL" == "enable" ]; then
This is a bashism.
Standard sh uses a simple =
No need for a v4, I can fix it.
next prev parent reply other threads:[~2019-03-01 17:43 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190214193547.30783-1-msantana@redhat.com>
2019-03-01 17:08 ` [dpdk-stable] [PATCH v3 0/2] Minor changes to checkpatches Michael Santana
2019-03-01 17:08 ` [dpdk-stable] [PATCH v3 1/2] Enable codespell by default. Can be disabled from config file Michael Santana
2019-03-01 17:43 ` Thomas Monjalon [this message]
2019-03-01 17:51 ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon
2019-03-01 20:24 ` Michael Santana Francisco
2019-03-01 21:08 ` Thomas Monjalon
2019-03-04 16:59 ` Michael Santana Francisco
2019-03-01 17:08 ` [dpdk-stable] [PATCH v3 2/2] devtools: fix result of svg include check Michael Santana
2019-03-01 17:52 ` Thomas Monjalon
2019-03-04 10:17 ` David Marchand
2019-03-04 19:07 ` [dpdk-stable] [PATCH v4 0/2] Minor changes to checkpatches Michael Santana
2019-03-04 19:07 ` [dpdk-stable] [PATCH v4 1/2] Enable codespell by default. Can be disabled from config file Michael Santana
2019-03-04 19:07 ` [dpdk-stable] [PATCH v4 2/2] devtools: fix result of svg include check Michael Santana
2019-03-04 21:46 ` [dpdk-stable] [PATCH v4 0/2] Minor changes to checkpatches Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1799922.WJ13kK0DMs@xps \
--to=thomas@monjalon.net \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=harry.van.haaren@intel.com \
--cc=msantana@redhat.com \
--cc=ramirose@gmail.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).