From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 81EFA37B4; Fri, 1 Mar 2019 18:43:52 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 0361122709; Fri, 1 Mar 2019 12:43:52 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Fri, 01 Mar 2019 12:43:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=RP3d5GaWvbUcjpFUYiZPKP9tZSMhZukRUMZyErVqiLQ=; b=d4Mfs53XnDNJ eutwPa4TJHxvSSenSpRm3sU33w4YpIKbphJiHQBtdjC0v4nIGWhFM2QgoD4LiF6J e/Gd5D8z4O+XJ67xUb+pMeHztWbm+MHaIn9zz76cGhuSPSiM9BXtU/FEFxuwSwQl yWtlZH/84ikUaevbN07E+SHk0y8IBQA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=RP3d5GaWvbUcjpFUYiZPKP9tZSMhZukRUMZyErVqi LQ=; b=IQ6PVvPn+6qE2uRst1ynDlIY8gA0/eVU5fskuEzIsVoQ0wL4ULRHhdHTl +xD6PKr+iPYkawYbzXJz4VIOaxKZRZFanjDeOrUvBM+TZUki0xGEjvkV7uKJ/qew ComTERtcIlbIDGraC97Zl/cSRitBzJIdgbYrRBQZNagM6AXCkQovv0jfpHRC04Dw tavp+VeKEyeu1qULL0B3pgwtQzGJK3+BGTMwM4w0c+v2VyB7KdIAbMOhwoaieEkH FYteYUd+fRkK6k9wq8WQL5w8GWSQ4Lctyu1O/gsRd0qV5il4rFOGHUuFjQA9tLVC zHW30XQ7VKrJOHdjyNXe7rDFtKvEQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedutddrvdehgddutdegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukf hppeejjedrudefiedrgedurdejtdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhm rghssehmohhnjhgrlhhonhdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (70.41.136.77.rev.sfr.net [77.136.41.70]) by mail.messagingengine.com (Postfix) with ESMTPA id 9C137E427E; Fri, 1 Mar 2019 12:43:42 -0500 (EST) From: Thomas Monjalon To: Michael Santana Cc: stable@dpdk.org, dev@dpdk.org, Bruce Richardson , Van Haaren Harry , ramirose@gmail.com Date: Fri, 01 Mar 2019 18:43:33 +0100 Message-ID: <1799922.WJ13kK0DMs@xps> In-Reply-To: <20190301170806.3547-2-msantana@redhat.com> References: <20190214193547.30783-1-msantana@redhat.com> <20190301170806.3547-1-msantana@redhat.com> <20190301170806.3547-2-msantana@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-stable] [PATCH v3 1/2] Enable codespell by default. Can be disabled from config file. X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Mar 2019 17:43:52 -0000 01/03/2019 18:08, Michael Santana: > +# Enable codespell by default. This can be overwritten from a config file. > +# You can also enable codespell by setting DPDK_CHECKPATCH_CODESPELL to a valid path > +# to a dictionary.txt file if your dictionary.txt is not in the default location. Better to avoid "you" form in such comment. > +DPDK_CHECKPATCH_CODESPELL=enable > # Load config options: > # - DPDK_CHECKPATCH_PATH > # - DPDK_CHECKPATCH_LINE_LENGTH > +# - DPDK_CHECKPATCH_CODESPELL > . $(dirname $(readlink -e $0))/load-devel-config > > VALIDATE_NEW_API=$(dirname $(readlink -e $0))/check-symbol-change.sh > @@ -13,6 +18,12 @@ length=${DPDK_CHECKPATCH_LINE_LENGTH:-80} > > # override default Linux options > options="--no-tree" > +if [ "$DPDK_CHECKPATCH_CODESPELL" == "enable" ]; then This is a bashism. Standard sh uses a simple = No need for a v4, I can fix it.