From: Thomas Monjalon <thomas@monjalon.net>
To: "Zhang, Helin" <helin.zhang@intel.com>, "Su, Simei" <simei.su@intel.com>
Cc: David Marchand <david.marchand@redhat.com>,
dev@dpdk.org, "Zhang, Yuying" <yuying.zhang@intel.com>,
"Xing, Beilei" <beilei.xing@intel.com>,
"Mcnamara, John" <john.mcnamara@intel.com>,
"stable@dpdk.org" <stable@dpdk.org>,
"Zhang, Qi Z" <qi.z.zhang@intel.com>,
Dapeng Yu <dapengx.yu@intel.com>,
Wenxuan Wu <wenxuanx.wu@intel.com>
Subject: Re: [PATCH v2] net/i40e: don't check link status on device start
Date: Tue, 07 Feb 2023 12:31:47 +0100 [thread overview]
Message-ID: <18020950.sWSEgdgrri@thomas> (raw)
In-Reply-To: <SA1PR11MB66133A13BF6FD15CF50714CA9CC19@SA1PR11MB6613.namprd11.prod.outlook.com>
16/01/2023 12:02, Su, Simei:
> From: David Marchand <david.marchand@redhat.com>
> > On Fri, Jan 13, 2023 at 2:51 PM Zhang, Helin <helin.zhang@intel.com> wrote:
> > > From: David Marchand <david.marchand@redhat.com>
> > > > On Fri, Jan 13, 2023 at 2:39 PM Zhang, Helin <helin.zhang@intel.com>
> > > > > From: David Marchand <david.marchand@redhat.com>
> > > > > > Hello i40e maintainers, John,
> > > > > >
> > > > > > On Mon, Jan 9, 2023 at 10:21 AM David Marchand
> > > > > > <david.marchand@redhat.com> wrote:
> > > > > > > On Tue, Jan 3, 2023 at 3:02 PM David Marchand
> > > > > > <david.marchand@redhat.com> wrote:
> > > > > > > > Hi i40e maintainers,
> > > > > > > >
> > > > > > > > On Tue, Dec 13, 2022 at 10:19 AM David Marchand
> > > > > > > > <david.marchand@redhat.com> wrote:
> > > > > > > > >
> > > > > > > > > The mentioned changes broke existing applications when the
> > > > > > > > > link status of i40e ports is down at the time the port is started.
> > > > > > > > > Revert those changes, the original issue will need a different fix.
> > > > > Hi David
> > > > >
> > > > > Does it break all the application or just a specific application?
> > > >
> > > > I don't see how it would not affect all applications seeing how the
> > > > original patch is dumb.
> > > >
> > > > > We may need to understand the issue you met, and try to fix it later.
> > > >
> > > > Just unplug the cable or fake a link down on your i40e port, start
> > > > your application or port, then plug the cable back.
> > > > The max frame size will never get applied to hw.
> > >
> > > Got it, I will forward to a right expert to check. Thank you very much for
> > reaching out to us!
> >
> > I hope I get a reply _soon_.
> > Or I will just apply those reverts.
>
> If applying those reverts, some issues still exist on our side. I sent one patch to patchwork:
> https://patchwork.dpdk.org/project/dpdk/patch/20230116105318.19412-1-simei.su@intel.com/.
> You can try this patch to see whether it can solve the issue on your side.
> At the same time, on our side, we need to do regression test further to check if this patch will affect other
> cases, the regression takes some time.
>
> Thanks,
> Simei
Simei, do you have any update in this thread?
Last reply was 3 weeks ago. I hope regression test don't take so much time.
next prev parent reply other threads:[~2023-02-07 11:32 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-07 8:59 [PATCH] net/i40e: enable max frame size at port level dapengx.yu
[not found] ` <BYAPR11MB2711AB91F380189FB6AFCC52FE359@BYAPR11MB2711.namprd11.prod.outlook.com>
[not found] ` <BYAPR11MB27110434B9262C0E2BED3AD3FE3A9@BYAPR11MB2711.namprd11.prod.outlook.com>
2022-02-21 10:42 ` Zhang, Peng1X
2022-02-21 11:22 ` Zhang, Qi Z
2022-02-22 9:52 ` Kevin Traynor
2022-12-12 13:53 ` David Marchand
2022-12-12 13:58 ` David Marchand
2022-12-12 14:37 ` [PATCH] net/i40e: drop link check when configuring frame size David Marchand
2022-12-13 9:18 ` [PATCH v2] net/i40e: don't check link status on device start David Marchand
2023-01-03 14:02 ` David Marchand
2023-01-09 9:21 ` David Marchand
2023-01-13 13:33 ` David Marchand
2023-01-13 13:39 ` Zhang, Helin
2023-01-13 13:46 ` David Marchand
2023-01-13 13:50 ` Zhang, Helin
2023-01-13 13:53 ` David Marchand
2023-01-16 11:02 ` Su, Simei
2023-02-07 11:31 ` Thomas Monjalon [this message]
2023-02-07 14:05 ` Su, Simei
2023-03-06 6:53 ` Su, Simei
2023-03-06 11:05 ` Zhang, Qi Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18020950.sWSEgdgrri@thomas \
--to=thomas@monjalon.net \
--cc=beilei.xing@intel.com \
--cc=dapengx.yu@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=helin.zhang@intel.com \
--cc=john.mcnamara@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=simei.su@intel.com \
--cc=stable@dpdk.org \
--cc=wenxuanx.wu@intel.com \
--cc=yuying.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).