* [PATCH] net/qede/base: fix 32-bit build with GCC 12
@ 2022-10-04 11:18 Thomas Monjalon
2022-10-05 19:28 ` David Marchand
2022-10-06 10:27 ` Thomas Monjalon
0 siblings, 2 replies; 3+ messages in thread
From: Thomas Monjalon @ 2022-10-04 11:18 UTC (permalink / raw)
To: dev; +Cc: stable, Rasesh Mody, Devendra Singh Rawat
A pointer is passed to a macro and it seems mistakenly referenced.
This issue is seen only when compiling with GCC 12 for 32-bit:
drivers/net/qede/base/ecore_init_fw_funcs.c:1418:25:
error: array subscript 1 is outside array bounds of ‘u32[1]’
{aka ‘unsigned int[1]’} [-Werror=array-bounds]
1418 | ecore_wr(dev, ptt, ((addr) + (4 * i)), \
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1419 | ((u32 *)&(arr))[i]); \
| ~~~~~~~~~~~~~~~~~~~
drivers/net/qede/base/ecore_init_fw_funcs.c:1465:17:
note: in expansion of macro ‘ARR_REG_WR’
1465 | ARR_REG_WR(p_hwfn, p_ptt, addr, pData, len_in_dwords);
| ^~~~~~~~~~
drivers/net/qede/base/ecore_init_fw_funcs.c:1439:35:
note: at offset 4 into object ‘pData’ of size 4
1439 | u32 *pData,
| ~~~~~^~~~~
Fixes: 3b307c55f2ac ("net/qede/base: update FW to 8.40.25.0")
Cc: stable@dpdk.org
Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
---
drivers/net/qede/base/ecore_init_fw_funcs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/qede/base/ecore_init_fw_funcs.c b/drivers/net/qede/base/ecore_init_fw_funcs.c
index 6a52f32cc9..0aa7f85567 100644
--- a/drivers/net/qede/base/ecore_init_fw_funcs.c
+++ b/drivers/net/qede/base/ecore_init_fw_funcs.c
@@ -1416,7 +1416,7 @@ void ecore_init_brb_ram(struct ecore_hwfn *p_hwfn,
u32 i; \
for (i = 0; i < (arr_size); i++) \
ecore_wr(dev, ptt, ((addr) + (4 * i)), \
- ((u32 *)&(arr))[i]); \
+ ((u32 *)arr)[i]); \
} while (0)
#ifndef DWORDS_TO_BYTES
--
2.36.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] net/qede/base: fix 32-bit build with GCC 12
2022-10-04 11:18 [PATCH] net/qede/base: fix 32-bit build with GCC 12 Thomas Monjalon
@ 2022-10-05 19:28 ` David Marchand
2022-10-06 10:27 ` Thomas Monjalon
1 sibling, 0 replies; 3+ messages in thread
From: David Marchand @ 2022-10-05 19:28 UTC (permalink / raw)
To: Thomas Monjalon; +Cc: dev, stable, Rasesh Mody, Devendra Singh Rawat
On Tue, Oct 4, 2022 at 1:18 PM Thomas Monjalon <thomas@monjalon.net> wrote:
>
> A pointer is passed to a macro and it seems mistakenly referenced.
> This issue is seen only when compiling with GCC 12 for 32-bit:
>
> drivers/net/qede/base/ecore_init_fw_funcs.c:1418:25:
> error: array subscript 1 is outside array bounds of ‘u32[1]’
> {aka ‘unsigned int[1]’} [-Werror=array-bounds]
> 1418 | ecore_wr(dev, ptt, ((addr) + (4 * i)), \
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 1419 | ((u32 *)&(arr))[i]); \
> | ~~~~~~~~~~~~~~~~~~~
> drivers/net/qede/base/ecore_init_fw_funcs.c:1465:17:
> note: in expansion of macro ‘ARR_REG_WR’
> 1465 | ARR_REG_WR(p_hwfn, p_ptt, addr, pData, len_in_dwords);
> | ^~~~~~~~~~
> drivers/net/qede/base/ecore_init_fw_funcs.c:1439:35:
> note: at offset 4 into object ‘pData’ of size 4
> 1439 | u32 *pData,
> | ~~~~~^~~~~
>
> Fixes: 3b307c55f2ac ("net/qede/base: update FW to 8.40.25.0")
> Cc: stable@dpdk.org
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
Reproduced and tested build fix.
Tested-by: David Marchand <david.marchand@redhat.com>
--
David Marchand
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] net/qede/base: fix 32-bit build with GCC 12
2022-10-04 11:18 [PATCH] net/qede/base: fix 32-bit build with GCC 12 Thomas Monjalon
2022-10-05 19:28 ` David Marchand
@ 2022-10-06 10:27 ` Thomas Monjalon
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2022-10-06 10:27 UTC (permalink / raw)
To: Rasesh Mody, Devendra Singh Rawat, amitprakashs; +Cc: dev, stable
04/10/2022 13:18, Thomas Monjalon:
> A pointer is passed to a macro and it seems mistakenly referenced.
> This issue is seen only when compiling with GCC 12 for 32-bit:
>
> drivers/net/qede/base/ecore_init_fw_funcs.c:1418:25:
> error: array subscript 1 is outside array bounds of ‘u32[1]’
> {aka ‘unsigned int[1]’} [-Werror=array-bounds]
> 1418 | ecore_wr(dev, ptt, ((addr) + (4 * i)), \
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 1419 | ((u32 *)&(arr))[i]); \
> | ~~~~~~~~~~~~~~~~~~~
> drivers/net/qede/base/ecore_init_fw_funcs.c:1465:17:
> note: in expansion of macro ‘ARR_REG_WR’
> 1465 | ARR_REG_WR(p_hwfn, p_ptt, addr, pData, len_in_dwords);
> | ^~~~~~~~~~
> drivers/net/qede/base/ecore_init_fw_funcs.c:1439:35:
> note: at offset 4 into object ‘pData’ of size 4
> 1439 | u32 *pData,
> | ~~~~~^~~~~
>
> Fixes: 3b307c55f2ac ("net/qede/base: update FW to 8.40.25.0")
> Cc: stable@dpdk.org
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
A similar patch was sent 6 weeks ago by Amit Prakash Shukla.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-10-06 10:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-04 11:18 [PATCH] net/qede/base: fix 32-bit build with GCC 12 Thomas Monjalon
2022-10-05 19:28 ` David Marchand
2022-10-06 10:27 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).