From: Thomas Monjalon <thomas@monjalon.net>
To: Slava Ovsiienko <viacheslavo@nvidia.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"dmitry.kozliuk@gmail.com" <dmitry.kozliuk@gmail.com>,
"stable@dpdk.org" <stable@dpdk.org>,
Tal Shnaiderman <talshn@nvidia.com>,
Narcisa Vasile <navasile@linux.microsoft.com>,
Ranjit Menon <ranjit.menon@intel.com>,
John Alexander <john.alexander@datapath.co.uk>,
Pallavi Kadam <pallavi.kadam@intel.com>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] bus/pci: fix Windows kernel driver categories
Date: Thu, 18 Mar 2021 11:45:45 +0100 [thread overview]
Message-ID: <1804735.jvUaWJhmuk@thomas> (raw)
In-Reply-To: <DM6PR12MB3753A0C29DECBE67ACD6484DDF699@DM6PR12MB3753.namprd12.prod.outlook.com>
18/03/2021 09:36, Slava Ovsiienko:
> From: Thomas Monjalon
> > In Windows probing, the value RTE_PCI_KDRV_NONE was used instead of
> > RTE_PCI_KDRV_UNKNOWN (mlx case), and RTE_PCI_KDRV_NIC_UIO
> > (FreeBSD) was re-used instead of having a new RTE_PCI_KDRV_NET_UIO for
> > Windows NetUIO.
>
> As far as I understand - under Windows there is always some kernel driver
> backing the device, hence, RTE_PCI_KDRV_NONE is not an option and
> RTE_PCI_KDRV_UNKNOWN is more appropriate. I would add this extra
> explanation in commit message.
The reason is that NONE is not appropriate because there *is* a kernel
driver backing the device in mlx case.
And it is aligning with Linux.
I will improve the message and comments.
next prev parent reply other threads:[~2021-03-18 10:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-16 23:11 [dpdk-stable] " Thomas Monjalon
2021-03-17 22:43 ` Dmitry Kozlyuk
2021-03-18 7:43 ` Thomas Monjalon
2021-03-17 23:17 ` Ranjit Menon
2021-03-18 7:49 ` Thomas Monjalon
2021-03-18 22:00 ` Ranjit Menon
2021-03-18 8:36 ` [dpdk-stable] [dpdk-dev] " Slava Ovsiienko
2021-03-18 10:45 ` Thomas Monjalon [this message]
2021-03-18 10:48 ` [dpdk-stable] [PATCH v2] " Thomas Monjalon
2021-03-18 12:00 ` Tal Shnaiderman
2021-03-18 22:07 ` Ranjit Menon
2021-03-19 15:24 ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1804735.jvUaWJhmuk@thomas \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=john.alexander@datapath.co.uk \
--cc=navasile@linux.microsoft.com \
--cc=pallavi.kadam@intel.com \
--cc=ranjit.menon@intel.com \
--cc=stable@dpdk.org \
--cc=talshn@nvidia.com \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).