* [PATCH] ring: fix the variable name error
@ 2023-04-07 8:48 Feifei Wang
2023-04-07 10:32 ` Morten Brørup
0 siblings, 1 reply; 3+ messages in thread
From: Feifei Wang @ 2023-04-07 8:48 UTC (permalink / raw)
To: Honnappa Nagarahalli, Konstantin Ananyev, Ruifeng Wang, Feifei Wang
Cc: dev, nd, stable
Ring dequeue operation's parameters name should be 'cons_xx',
rather than 'prod_xxx'.
Fixes: 1fc73390bcf5 ("ring: refactor exported headers")
Cc: stable@dpdk.org
Signed-off-by: Feifei Wang <feifei.wang2@arm.com>
Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
---
lib/ring/rte_ring_elem_pvt.h | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/lib/ring/rte_ring_elem_pvt.h b/lib/ring/rte_ring_elem_pvt.h
index e24e4492ff..4b80f58980 100644
--- a/lib/ring/rte_ring_elem_pvt.h
+++ b/lib/ring/rte_ring_elem_pvt.h
@@ -194,12 +194,12 @@ __rte_ring_dequeue_elems_32(struct rte_ring *r, const uint32_t size,
}
static __rte_always_inline void
-__rte_ring_dequeue_elems_64(struct rte_ring *r, uint32_t prod_head,
+__rte_ring_dequeue_elems_64(struct rte_ring *r, uint32_t cons_head,
void *obj_table, uint32_t n)
{
unsigned int i;
const uint32_t size = r->size;
- uint32_t idx = prod_head & r->mask;
+ uint32_t idx = cons_head & r->mask;
uint64_t *ring = (uint64_t *)&r[1];
unaligned_uint64_t *obj = (unaligned_uint64_t *)obj_table;
if (likely(idx + n <= size)) {
@@ -227,12 +227,12 @@ __rte_ring_dequeue_elems_64(struct rte_ring *r, uint32_t prod_head,
}
static __rte_always_inline void
-__rte_ring_dequeue_elems_128(struct rte_ring *r, uint32_t prod_head,
+__rte_ring_dequeue_elems_128(struct rte_ring *r, uint32_t cons_head,
void *obj_table, uint32_t n)
{
unsigned int i;
const uint32_t size = r->size;
- uint32_t idx = prod_head & r->mask;
+ uint32_t idx = cons_head & r->mask;
rte_int128_t *ring = (rte_int128_t *)&r[1];
rte_int128_t *obj = (rte_int128_t *)obj_table;
if (likely(idx + n <= size)) {
--
2.25.1
^ permalink raw reply [flat|nested] 3+ messages in thread* RE: [PATCH] ring: fix the variable name error
2023-04-07 8:48 [PATCH] ring: fix the variable name error Feifei Wang
@ 2023-04-07 10:32 ` Morten Brørup
2023-05-24 21:00 ` Thomas Monjalon
0 siblings, 1 reply; 3+ messages in thread
From: Morten Brørup @ 2023-04-07 10:32 UTC (permalink / raw)
To: Feifei Wang, Honnappa Nagarahalli, Konstantin Ananyev, Ruifeng Wang
Cc: dev, nd, stable
> From: Feifei Wang [mailto:feifei.wang2@arm.com]
> Sent: Friday, 7 April 2023 10.48
>
> Ring dequeue operation's parameters name should be 'cons_xx',
> rather than 'prod_xxx'.
>
> Fixes: 1fc73390bcf5 ("ring: refactor exported headers")
> Cc: stable@dpdk.org
>
> Signed-off-by: Feifei Wang <feifei.wang2@arm.com>
> Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
> ---
Acked-by: Morten Brørup <mb@smartsharesystems.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] ring: fix the variable name error
2023-04-07 10:32 ` Morten Brørup
@ 2023-05-24 21:00 ` Thomas Monjalon
0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2023-05-24 21:00 UTC (permalink / raw)
To: Feifei Wang
Cc: Honnappa Nagarahalli, Konstantin Ananyev, Ruifeng Wang, stable,
dev, nd, Morten Brørup
07/04/2023 12:32, Morten Brørup:
> > From: Feifei Wang [mailto:feifei.wang2@arm.com]
> > Sent: Friday, 7 April 2023 10.48
> >
> > Ring dequeue operation's parameters name should be 'cons_xx',
> > rather than 'prod_xxx'.
> >
> > Fixes: 1fc73390bcf5 ("ring: refactor exported headers")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Feifei Wang <feifei.wang2@arm.com>
> > Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
>
> Acked-by: Morten Brørup <mb@smartsharesystems.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-05-24 21:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-04-07 8:48 [PATCH] ring: fix the variable name error Feifei Wang
2023-04-07 10:32 ` Morten Brørup
2023-05-24 21:00 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).