From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Cc: dpdk stable <stable@dpdk.org>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] kni: fix crash for KNI interface remove
Date: Mon, 26 Sep 2016 13:26:20 +0100 [thread overview]
Message-ID: <184f1ca8-2404-ebf7-367d-1b6f36c2da5c@intel.com> (raw)
In-Reply-To: <20160926121520.GD20278@yliu-dev.sh.intel.com>
On 9/26/2016 1:15 PM, Yuanhan Liu wrote:
> On Mon, Sep 26, 2016 at 10:21:12AM +0100, Ferruh Yigit wrote:
>> On 9/26/2016 9:34 AM, Yuanhan Liu wrote:
>>> On Fri, Sep 09, 2016 at 03:46:01PM +0200, Thomas Monjalon wrote:
>>>> 2016-08-31 14:06, Ferruh Yigit:
>>>>> Removing KNI interface that has no PCI driver for ethtool support cause
>>>>> kernel crash.
>>>>>
>>>>> Fixes: 109febfe58f9 ("net/igb: move PCI device IDs from EAL")
>>>>> Fixes: 221fba3b987c ("net/ixgbe: move PCI device IDs from EAL")
>>>>>
>>>>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
>>>>
>>>> Applied, thanks
>>>
>>> FYI, this patch has been applied to stable branch v16.07.
>>>
>>> It hasn't been pushed to http://dpdk.org/browse/dpdk-stable/ yet.
>>> It will be pushed if I get no objections in around TWO days. So
>>> please shutout if you have objections.
>>
>> If the patches mentioned in Fixes line applied to stable branch, this
>> one also should be applied.
>
> Thanks for the response.
>
> It might address the conflict issue,
Which conflict issue?
> but with a simple glimpse, the
> build issue might still remain. Say, commit 109febfe58f9 ("net/igb: move
> PCI device IDs from EAL") will not be applied (as there is no fixline),
109febfe58f9 & 221fba3b987c are in fixes line of this patch.
> but it is required by commit 5544a453b4ac ("kni: fix crash when removing
> interface"), if I'm not mistaken.
I am not clear with question but, the issue is:
109febfe58f9 & 221fba3b987c creates a defect and this patch fixes it.
If both 109febfe58f9 or 221fba3b987c get into stable tree, this patch
needs to get in to fix crash. If you prefer to get one of them (although
that doesn't make much sense), a backported version of this patch needs
to be applied.
>
> Or, I'm wrong?
>
> --yliu
>
next prev parent reply other threads:[~2016-09-26 12:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1472648786-32404-1-git-send-email-ferruh.yigit@intel.com>
[not found] ` <6154238.UfqKImgbgb@xps13>
2016-09-26 8:34 ` Yuanhan Liu
2016-09-26 8:54 ` Yuanhan Liu
2016-09-26 9:21 ` Ferruh Yigit
2016-09-26 12:15 ` Yuanhan Liu
2016-09-26 12:26 ` Ferruh Yigit [this message]
2016-09-26 12:56 ` Yuanhan Liu
2016-09-26 13:00 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=184f1ca8-2404-ebf7-367d-1b6f36c2da5c@intel.com \
--to=ferruh.yigit@intel.com \
--cc=stable@dpdk.org \
--cc=yuanhan.liu@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).