patches for DPDK stable branches
 help / color / mirror / Atom feed
* [dpdk-stable] [PATCH] Revert "bonding: use existing enslaved device queues"
@ 2016-09-07 12:28 Ilya Maximets
       [not found] ` <CGME20160916050359eucas1p22998d07e190781e165082cdd9c917470@eucas1p2.samsung.com>
                   ` (3 more replies)
  0 siblings, 4 replies; 28+ messages in thread
From: Ilya Maximets @ 2016-09-07 12:28 UTC (permalink / raw)
  To: dev, Declan Doherty
  Cc: Heetae Ahn, Yuanhan Liu, Eric Kinzie, Bernard Iremonger,
	Ilya Maximets, stable

This reverts commit 5b7bb2bda5519b7800f814df64d4e015282140e5.

It is necessary to reconfigure all queues every time because configuration
can be changed.

For example, if we're reconfiguring bonding device with new memory pool,
already configured queues will still use the old one. And if the old
mempool be freed, application likely will panic in attempt to use
freed mempool.

This happens when we use the bonding device with OVS 2.6 while MTU
reconfiguration:

PANIC in rte_mempool_get_ops():
assert "(ops_index >= 0) && (ops_index < RTE_MEMPOOL_MAX_OPS_IDX)" failed

Cc: <stable@dpdk.org>
Signed-off-by: Ilya Maximets <i.maximets@samsung.com>
---
 drivers/net/bonding/rte_eth_bond_pmd.c | 10 ++--------
 1 file changed, 2 insertions(+), 8 deletions(-)

diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c
index b20a272..eb5b6d1 100644
--- a/drivers/net/bonding/rte_eth_bond_pmd.c
+++ b/drivers/net/bonding/rte_eth_bond_pmd.c
@@ -1305,8 +1305,6 @@ slave_configure(struct rte_eth_dev *bonded_eth_dev,
 	struct bond_rx_queue *bd_rx_q;
 	struct bond_tx_queue *bd_tx_q;
 
-	uint16_t old_nb_tx_queues = slave_eth_dev->data->nb_tx_queues;
-	uint16_t old_nb_rx_queues = slave_eth_dev->data->nb_rx_queues;
 	int errval;
 	uint16_t q_id;
 
@@ -1347,9 +1345,7 @@ slave_configure(struct rte_eth_dev *bonded_eth_dev,
 	}
 
 	/* Setup Rx Queues */
-	/* Use existing queues, if any */
-	for (q_id = old_nb_rx_queues;
-	     q_id < bonded_eth_dev->data->nb_rx_queues; q_id++) {
+	for (q_id = 0; q_id < bonded_eth_dev->data->nb_rx_queues; q_id++) {
 		bd_rx_q = (struct bond_rx_queue *)bonded_eth_dev->data->rx_queues[q_id];
 
 		errval = rte_eth_rx_queue_setup(slave_eth_dev->data->port_id, q_id,
@@ -1365,9 +1361,7 @@ slave_configure(struct rte_eth_dev *bonded_eth_dev,
 	}
 
 	/* Setup Tx Queues */
-	/* Use existing queues, if any */
-	for (q_id = old_nb_tx_queues;
-	     q_id < bonded_eth_dev->data->nb_tx_queues; q_id++) {
+	for (q_id = 0; q_id < bonded_eth_dev->data->nb_tx_queues; q_id++) {
 		bd_tx_q = (struct bond_tx_queue *)bonded_eth_dev->data->tx_queues[q_id];
 
 		errval = rte_eth_tx_queue_setup(slave_eth_dev->data->port_id, q_id,
-- 
2.7.4

^ permalink raw reply	[flat|nested] 28+ messages in thread

end of thread, other threads:[~2016-11-23 20:35 UTC | newest]

Thread overview: 28+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-07 12:28 [dpdk-stable] [PATCH] Revert "bonding: use existing enslaved device queues" Ilya Maximets
     [not found] ` <CGME20160916050359eucas1p22998d07e190781e165082cdd9c917470@eucas1p2.samsung.com>
2016-09-16  5:03   ` Ilya Maximets
2016-10-06 14:32 ` Declan Doherty
2016-10-19  9:55   ` [dpdk-stable] [dpdk-dev] " Bruce Richardson
2016-10-25 13:59     ` Bruce Richardson
2016-10-07  2:02 ` [dpdk-stable] " Eric Kinzie
2016-10-12 13:24   ` Ilya Maximets
2016-10-12 15:24     ` [dpdk-stable] [dpdk-dev] " Bruce Richardson
2016-10-13 23:37       ` Eric Kinzie
2016-10-24 11:02         ` Declan Doherty
2016-10-24 14:51           ` Jan Blunck
2016-10-24 15:07             ` Declan Doherty
2016-10-25 12:57               ` Bruce Richardson
2016-10-25 13:48                 ` Declan Doherty
2016-10-25 14:00                   ` Bruce Richardson
2016-11-21 11:30                     ` Ferruh Yigit
2016-11-21 11:39                       ` Jan Blunck
2016-11-21 12:49                         ` Ilya Maximets
2016-11-21 13:11                           ` Ilya Maximets
2016-11-23 20:35                             ` Jan Blunck
2016-10-18 12:28 ` Jan Blunck
2016-10-18 12:49   ` Ilya Maximets
2016-10-18 15:19     ` Jan Blunck
2016-10-19  9:47       ` Ilya Maximets
2016-10-24 14:54         ` Jan Blunck
2016-10-25  6:26           ` Ilya Maximets
2016-10-28  6:14             ` Ilya Maximets
2016-11-11  9:16               ` Ilya Maximets

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).