From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
[66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 71C561B1AB;
Fri, 6 Oct 2017 00:16:08 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
by mailout.nyi.internal (Postfix) with ESMTP id 0E98320F2B;
Thu, 5 Oct 2017 18:16:08 -0400 (EDT)
Received: from frontend1 ([10.202.2.160])
by compute1.internal (MEProxy); Thu, 05 Oct 2017 18:16:08 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
cc:content-transfer-encoding:content-type:date:from:in-reply-to
:message-id:mime-version:references:subject:to:x-me-sender
:x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=1fYBeg/o7ZrFFnu
hUZJrGJKvZ8W+IxUcxMElmOOfR8k=; b=IzPmd5jbU9ayx60g23VEwnTVq/TRa73
VFwMd8HYRNgktkxzVnFIvG8fMLU113Io/GqbA9GUlwa7HgLZA6hatMwCBXcc9y6q
KRPsHiMUXtHpPvgP1XScQxMpgkIXDNBq53y/6ARKwLkyvNbwsjpqf6K2HESDo61W
yfHDnx7SsijU=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:content-transfer-encoding:content-type
:date:from:in-reply-to:message-id:mime-version:references
:subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s=
fm1; bh=1fYBeg/o7ZrFFnuhUZJrGJKvZ8W+IxUcxMElmOOfR8k=; b=cOF/mlDP
vL8933mGXwrD/G2iEOgJGNPmWHbNIg3tV18IrtObbMs8x0LfRTxqfWDCaWWrHwHj
IjpNdnIlYjcLdOBPEV9il6rVmNBIJmwf8AhfTJ1P1A8IA2sptuQ1c1ovoSHVTvdL
rnd0fOwDoFrRh7eBCoYXwxr0NAVUuEbXXbQQG2JchyC0R4Lg/EnrcEhsUsazSGoa
F8AcuU08Z2xIsLnQ42cjE/Pbxoct/CmDxrrTZb4uqXgHl69W4QOnWbxlbfrdmyUZ
7ovOoGQshjRwZBz/Q/pf5D8fyeuSkLTMHQSoZMkwU6Y45LsMD/JZZSH4kobyKu1A
P9WIJImqZ8g3Aw==
X-ME-Sender: <xms:J6_WWaax0bcgcj3B5g3JtlOwYoEybe14Q4zsykUW8hs1O9bmLi-O_w>
X-Sasl-enc: NJneNHfJfexWVNMH5WDfjcm4K686GK9Kx4cnkbEXWi2F 1507241767
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
by mail.messagingengine.com (Postfix) with ESMTPA id AF1B67FAC5;
Thu, 5 Oct 2017 18:16:07 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Lukasz Majczak <lma@semihalf.com>
Cc: dev@dpdk.org, stable@dpdk.org
Date: Fri, 06 Oct 2017 00:16:06 +0200
Message-ID: <1861830.ytJZ7dK9I5@xps>
In-Reply-To: <20170928065459.6616-1-lma@semihalf.com>
References: <20170925073441.23494-1-lma@semihalf.com>
<20170928065459.6616-1-lma@semihalf.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v4] librte_eal: fix wrong
assert for arm and ppc
X-BeenThere: stable@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches for DPDK stable branches <stable.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/stable>,
<mailto:stable-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/stable/>
List-Post: <mailto:stable@dpdk.org>
List-Help: <mailto:stable-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/stable>,
<mailto:stable-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 05 Oct 2017 22:16:08 -0000
28/09/2017 08:54, Lukasz Majczak:
> The assertion of return value from the open() function is done against
> 0, while it is a correct value - open() returns -1 in case of an error.
> It causes problems while trying to run as a daemon, in which case, this
> call to open() will return 0 as a valid descriptor.
>
> Fixes: b94e5c9406b5 ("eal/arm: add CPU flags for ARMv7")
> Fixes: 97523f822ba9 ("eal/arm: add CPU flags for ARMv8")
> Fixes: 9ae155385686 ("eal/ppc: cpu flag checks for IBM Power")
Cc: stable@dpdk.org
> Signed-off-by: Lukasz Majczak <lma@semihalf.com>
> Acked-by: Jan Viktorin <viktorin@rehivetech.com>
> Acked-by: Chao Zhu <chaozhu@linux.vnet.ibm.com>
Applied, thanks