From: Thomas Monjalon <thomas@monjalon.net>
To: David Marchand <david.marchand@redhat.com>
Cc: dpdk stable <stable@dpdk.org>, dev <dev@dpdk.org>,
Matan Azrad <matan@mellanox.com>,
Shahaf Shuler <shahafs@mellanox.com>,
Viacheslav Ovsiienko <viacheslavo@mellanox.com>,
Raslan <rasland@mellanox.com>, Luca Boccassi <bluca@debian.org>,
Ray Kinsella <mdr@ashroe.eu>
Subject: Re: [dpdk-stable] [PATCH] drivers/net: fix mlx* glue libraries ABI version
Date: Thu, 07 May 2020 22:04:05 +0200 [thread overview]
Message-ID: <1877030.kXSN5OTJKJ@thomas> (raw)
In-Reply-To: <CAJFAV8y5FBDea2-dm8z=DdnyuHJQ-_-Fjr_juEC=MfQXynSeQQ@mail.gmail.com>
07/05/2020 14:35, David Marchand:
> On Thu, Dec 12, 2019 at 11:18 PM Thomas Monjalon <thomas@monjalon.net> wrote:
> >
> > 04/12/2019 11:05, David Marchand:
> > > Those libraries have been missed when switching to global ABI version.
> >
> > The versioning of the glue libraries are for compatibility checks
> > between the PMD and its dependency (rdma-core) packaged as a plugin,
> > called glue library.
> >
> > This versioning is updated when there is a change in the verbs glue
> > interface, in order to avoid issues in case of PMD and glue
> > updated separately with a non-compatible version.
> > I don't think the mlx glue libraries are part of the ABI policy
> > which acts at the application level.
> >
> > Am I missing something?
>
> Sorry, this patch fell into the cracks.
>
> I agree that this is not part of the ABI policy.
> This version only indicates something internal.
>
> But what I am proposing here is just to remove this special case.
> What is the point of exposing a special version, while the net drivers
> are the only one depending on those glue libs?
> Do you expect separate packaging for the net driver and its associated glue lib?
>
> This special version also makes it impossible to install two versions
> of dpdk if those versions of dpdk need the same glue version.
Yes I'm OK with using DPDK version for glue versioning.
prev parent reply other threads:[~2020-05-07 20:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-04 10:05 David Marchand
2019-12-12 22:17 ` Thomas Monjalon
2020-05-07 12:35 ` David Marchand
2020-05-07 20:04 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1877030.kXSN5OTJKJ@thomas \
--to=thomas@monjalon.net \
--cc=bluca@debian.org \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=matan@mellanox.com \
--cc=mdr@ashroe.eu \
--cc=rasland@mellanox.com \
--cc=shahafs@mellanox.com \
--cc=stable@dpdk.org \
--cc=viacheslavo@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).