From: Thomas Monjalon <thomas@monjalon.net>
To: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Cc: dev@dpdk.org, Fan Zhang <roy.fan.zhang@intel.com>,
"ferruh.yigit@intel.com" <ferruh.yigit@intel.com>,
"Jacob, Jerin" <Jerin.JacobKollanukkaran@cavium.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] crypto/scheduler: fix build with gcc 8.2
Date: Sun, 04 Nov 2018 22:01:00 +0100 [thread overview]
Message-ID: <1884211.o4Xx1SxZqB@xps> (raw)
In-Reply-To: <20181103145828.24564-1-jerin.jacob@caviumnetworks.com>
03/11/2018 15:58, Jerin Jacob:
> build_error:
>
> drivers/crypto/scheduler/scheduler_pmd.c: In function ‘parse_name_arg’:
> drivers/crypto/scheduler/scheduler_pmd.c:372:2: error: ‘strncpy’
> specified bound 64 equals destination size [-Werror=stringop-truncation]
> strncpy(params->name, value, RTE_CRYPTODEV_NAME_MAX_LEN);
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> strncpy may result a not null-terminated string,
> replaced it with strlcpy
>
> Fixes: 503e9c5afb38 ("crypto/scheduler: register as vdev driver")
> Cc: stable@dpdk.org
>
> Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Applied, thanks
prev parent reply other threads:[~2018-11-04 21:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-03 14:58 Jerin Jacob
2018-11-04 21:01 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1884211.o4Xx1SxZqB@xps \
--to=thomas@monjalon.net \
--cc=Jerin.JacobKollanukkaran@cavium.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=jerin.jacob@caviumnetworks.com \
--cc=roy.fan.zhang@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).