* Re: [dpdk-stable] [dpdk-dev] [PATCH] test: fix incorrect cast in pipeline unit test
[not found] <20180510073815.76926-1-david.hunt@intel.com>
@ 2018-05-11 15:42 ` De Lara Guarch, Pablo
2018-05-13 21:25 ` Thomas Monjalon
0 siblings, 1 reply; 2+ messages in thread
From: De Lara Guarch, Pablo @ 2018-05-11 15:42 UTC (permalink / raw)
To: Hunt, David, dev; +Cc: Dumitrescu, Cristian, Hunt, David, stable
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of David Hunt
> Sent: Thursday, May 10, 2018 8:38 AM
> To: dev@dpdk.org
> Cc: Dumitrescu, Cristian <cristian.dumitrescu@intel.com>; Hunt, David
> <david.hunt@intel.com>
> Subject: [dpdk-dev] [PATCH] test: fix incorrect cast in pipeline unit test
>
> New warning with gcc 8.1:
> The table_action_stub_miss() function was incorrectly declared as returning a
> typedef of rte_pipeline_table_action_handler_miss, instead of what it should
> have been, an int.
> Changed this to declare the function as returning an int, and now when the
> action_handler_miss is set to table_action_stub_miss (cast as
> rte_pipeline_table_action_handler_miss), gcc 8.1 no longer complains about the
> cast.
>
> Fixes: 5205954791cb ("app/test: packet framework unit tests")
>
> Signed-off-by: David Hunt <david.hunt@intel.com>
Missing "Cc: stable@dpdk.org".
Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-stable] [dpdk-dev] [PATCH] test: fix incorrect cast in pipeline unit test
2018-05-11 15:42 ` [dpdk-stable] [dpdk-dev] [PATCH] test: fix incorrect cast in pipeline unit test De Lara Guarch, Pablo
@ 2018-05-13 21:25 ` Thomas Monjalon
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Monjalon @ 2018-05-13 21:25 UTC (permalink / raw)
To: Hunt, David; +Cc: dev, De Lara Guarch, Pablo, Dumitrescu, Cristian, stable
> > New warning with gcc 8.1:
> > The table_action_stub_miss() function was incorrectly declared as returning a
> > typedef of rte_pipeline_table_action_handler_miss, instead of what it should
> > have been, an int.
> > Changed this to declare the function as returning an int, and now when the
> > action_handler_miss is set to table_action_stub_miss (cast as
> > rte_pipeline_table_action_handler_miss), gcc 8.1 no longer complains about the
> > cast.
> >
> > Fixes: 5205954791cb ("app/test: packet framework unit tests")
> >
> > Signed-off-by: David Hunt <david.hunt@intel.com>
>
> Missing "Cc: stable@dpdk.org".
>
> Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Applied, thanks
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-05-13 21:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20180510073815.76926-1-david.hunt@intel.com>
2018-05-11 15:42 ` [dpdk-stable] [dpdk-dev] [PATCH] test: fix incorrect cast in pipeline unit test De Lara Guarch, Pablo
2018-05-13 21:25 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).