patches for DPDK stable branches
 help / color / mirror / Atom feed
* [dpdk-stable] [PATCH] ring: fix comment for __rte_ring_move_cons_head()
@ 2021-08-23 17:28 Cian Ferriter
  2021-08-24 19:32 ` Honnappa Nagarahalli
  0 siblings, 1 reply; 3+ messages in thread
From: Cian Ferriter @ 2021-08-23 17:28 UTC (permalink / raw)
  To: Honnappa Nagarahalli, Konstantin Ananyev
  Cc: dev, Cian Ferriter, bruce.richardson, stable

Change "enqueue" to "dequeue" because the __rte_ring_move_cons_head()
function is updating the consumer head for dequeue.

Fixes: 0dfc98c507b1 ("ring: separate out head index manipulation")
Cc: bruce.richardson@intel.com
Cc: stable@dpdk.org

Signed-off-by: Cian Ferriter <cian.ferriter@intel.com>
---
 lib/ring/rte_ring_c11_pvt.h     | 2 +-
 lib/ring/rte_ring_generic_pvt.h | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/ring/rte_ring_c11_pvt.h b/lib/ring/rte_ring_c11_pvt.h
index 37e0b2afd6..f895950df4 100644
--- a/lib/ring/rte_ring_c11_pvt.h
+++ b/lib/ring/rte_ring_c11_pvt.h
@@ -111,7 +111,7 @@ __rte_ring_move_prod_head(struct rte_ring *r, unsigned int is_sp,
  * @param is_sc
  *   Indicates whether multi-consumer path is needed or not
  * @param n
- *   The number of elements we will want to enqueue, i.e. how far should the
+ *   The number of elements we will want to dequeue, i.e. how far should the
  *   head be moved
  * @param behavior
  *   RTE_RING_QUEUE_FIXED:    Dequeue a fixed number of items from a ring
diff --git a/lib/ring/rte_ring_generic_pvt.h b/lib/ring/rte_ring_generic_pvt.h
index c95ad7e12c..5acb6e59be 100644
--- a/lib/ring/rte_ring_generic_pvt.h
+++ b/lib/ring/rte_ring_generic_pvt.h
@@ -106,7 +106,7 @@ __rte_ring_move_prod_head(struct rte_ring *r, unsigned int is_sp,
  * @param is_sc
  *   Indicates whether multi-consumer path is needed or not
  * @param n
- *   The number of elements we will want to enqueue, i.e. how far should the
+ *   The number of elements we will want to dequeue, i.e. how far should the
  *   head be moved
  * @param behavior
  *   RTE_RING_QUEUE_FIXED:    Dequeue a fixed number of items from a ring
-- 
2.32.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-stable] [PATCH] ring: fix comment for __rte_ring_move_cons_head()
  2021-08-23 17:28 [dpdk-stable] [PATCH] ring: fix comment for __rte_ring_move_cons_head() Cian Ferriter
@ 2021-08-24 19:32 ` Honnappa Nagarahalli
  2021-10-01 12:47   ` Thomas Monjalon
  0 siblings, 1 reply; 3+ messages in thread
From: Honnappa Nagarahalli @ 2021-08-24 19:32 UTC (permalink / raw)
  To: Cian Ferriter, Konstantin Ananyev; +Cc: dev, bruce.richardson, stable, nd, nd

<snip>

> 
> Change "enqueue" to "dequeue" because the __rte_ring_move_cons_head()
> function is updating the consumer head for dequeue.
> 
> Fixes: 0dfc98c507b1 ("ring: separate out head index manipulation")
> Cc: bruce.richardson@intel.com
> Cc: stable@dpdk.org
> 
> Signed-off-by: Cian Ferriter <cian.ferriter@intel.com>
LGTM
Acked-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>

> ---
>  lib/ring/rte_ring_c11_pvt.h     | 2 +-
>  lib/ring/rte_ring_generic_pvt.h | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/lib/ring/rte_ring_c11_pvt.h b/lib/ring/rte_ring_c11_pvt.h index
> 37e0b2afd6..f895950df4 100644
> --- a/lib/ring/rte_ring_c11_pvt.h
> +++ b/lib/ring/rte_ring_c11_pvt.h
> @@ -111,7 +111,7 @@ __rte_ring_move_prod_head(struct rte_ring *r,
> unsigned int is_sp,
>   * @param is_sc
>   *   Indicates whether multi-consumer path is needed or not
>   * @param n
> - *   The number of elements we will want to enqueue, i.e. how far should the
> + *   The number of elements we will want to dequeue, i.e. how far should the
>   *   head be moved
>   * @param behavior
>   *   RTE_RING_QUEUE_FIXED:    Dequeue a fixed number of items from a ring
> diff --git a/lib/ring/rte_ring_generic_pvt.h b/lib/ring/rte_ring_generic_pvt.h
> index c95ad7e12c..5acb6e59be 100644
> --- a/lib/ring/rte_ring_generic_pvt.h
> +++ b/lib/ring/rte_ring_generic_pvt.h
> @@ -106,7 +106,7 @@ __rte_ring_move_prod_head(struct rte_ring *r,
> unsigned int is_sp,
>   * @param is_sc
>   *   Indicates whether multi-consumer path is needed or not
>   * @param n
> - *   The number of elements we will want to enqueue, i.e. how far should the
> + *   The number of elements we will want to dequeue, i.e. how far should the
>   *   head be moved
>   * @param behavior
>   *   RTE_RING_QUEUE_FIXED:    Dequeue a fixed number of items from a ring
> --
> 2.32.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-stable] [PATCH] ring: fix comment for __rte_ring_move_cons_head()
  2021-08-24 19:32 ` Honnappa Nagarahalli
@ 2021-10-01 12:47   ` Thomas Monjalon
  0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2021-10-01 12:47 UTC (permalink / raw)
  To: Cian Ferriter
  Cc: Konstantin Ananyev, stable, dev, bruce.richardson, Honnappa Nagarahalli

> > Change "enqueue" to "dequeue" because the __rte_ring_move_cons_head()
> > function is updating the consumer head for dequeue.
> > 
> > Fixes: 0dfc98c507b1 ("ring: separate out head index manipulation")
> > Cc: bruce.richardson@intel.com
> > Cc: stable@dpdk.org
> > 
> > Signed-off-by: Cian Ferriter <cian.ferriter@intel.com>
> LGTM
> Acked-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>

Applied, thanks.



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-10-01 12:47 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-23 17:28 [dpdk-stable] [PATCH] ring: fix comment for __rte_ring_move_cons_head() Cian Ferriter
2021-08-24 19:32 ` Honnappa Nagarahalli
2021-10-01 12:47   ` Thomas Monjalon

patches for DPDK stable branches

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ http://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git