* [dpdk-stable] [PATCH] lib/librte_eal: fix unrecongized telemetry eal arg
@ 2019-07-15 10:54 Sean Morrissey
2019-07-19 10:04 ` Laatz, Kevin
0 siblings, 1 reply; 4+ messages in thread
From: Sean Morrissey @ 2019-07-15 10:54 UTC (permalink / raw)
To: dev
Cc: kevin.laatz, harry.vanhaaren, john.oloughlin, marko.kovacevic,
Sean Morrissey, ciara.power, stable
Added telemetry to EAL long options so that when
--telemetry is passed as an EAL arg that there is
no unrecognized argument error message printed.
Fixes: 8877ac688b52 ("telemetry: introduce infrastructure")
Cc: ciara.power@intel.com
Cc: stable@dpdk.org
Signed-off-by: Sean Morrissey <sean.morrissey@intel.com>
---
lib/librte_eal/common/eal_common_options.c | 3 +++
lib/librte_eal/common/eal_options.h | 4 ++++
2 files changed, 7 insertions(+)
diff --git a/lib/librte_eal/common/eal_common_options.c b/lib/librte_eal/common/eal_common_options.c
index 512d5088e..24e36cf23 100644
--- a/lib/librte_eal/common/eal_common_options.c
+++ b/lib/librte_eal/common/eal_common_options.c
@@ -81,6 +81,9 @@ eal_long_options[] = {
{OPT_LEGACY_MEM, 0, NULL, OPT_LEGACY_MEM_NUM },
{OPT_SINGLE_FILE_SEGMENTS, 0, NULL, OPT_SINGLE_FILE_SEGMENTS_NUM},
{OPT_MATCH_ALLOCATIONS, 0, NULL, OPT_MATCH_ALLOCATIONS_NUM},
+#ifdef RTE_LIBRTE_TELEMETRY
+ {OPT_TELEMETRY, 0, NULL, OPT_TELEMETRY_NUM },
+#endif
{0, 0, NULL, 0 }
};
diff --git a/lib/librte_eal/common/eal_options.h b/lib/librte_eal/common/eal_options.h
index 9855429e5..e4c8e25c2 100644
--- a/lib/librte_eal/common/eal_options.h
+++ b/lib/librte_eal/common/eal_options.h
@@ -69,6 +69,10 @@ enum {
OPT_IOVA_MODE_NUM,
#define OPT_MATCH_ALLOCATIONS "match-allocations"
OPT_MATCH_ALLOCATIONS_NUM,
+#ifdef RTE_LIBRTE_TELEMETRY
+ #define OPT_TELEMETRY "telemetry"
+ OPT_TELEMETRY_NUM,
+#endif
OPT_LONG_MAX_NUM
};
--
2.17.1
--------------------------------------------------------------
Intel Research and Development Ireland Limited
Registered in Ireland
Registered Office: Collinstown Industrial Park, Leixlip, County Kildare
Registered Number: 308263
This e-mail and any attachments may contain confidential material for the sole
use of the intended recipient(s). Any review or distribution by others is
strictly prohibited. If you are not the intended recipient, please contact the
sender and delete all copies.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-stable] [PATCH] lib/librte_eal: fix unrecongized telemetry eal arg
2019-07-15 10:54 [dpdk-stable] [PATCH] lib/librte_eal: fix unrecongized telemetry eal arg Sean Morrissey
@ 2019-07-19 10:04 ` Laatz, Kevin
2019-07-22 16:40 ` Thomas Monjalon
0 siblings, 1 reply; 4+ messages in thread
From: Laatz, Kevin @ 2019-07-19 10:04 UTC (permalink / raw)
To: Sean Morrissey, dev
Cc: harry.vanhaaren, john.oloughlin, marko.kovacevic, ciara.power, stable
On 15/07/2019 11:54, Sean Morrissey wrote:
> Added telemetry to EAL long options so that when
> --telemetry is passed as an EAL arg that there is
> no unrecognized argument error message printed.
>
> Fixes: 8877ac688b52 ("telemetry: introduce infrastructure")
> Cc: ciara.power@intel.com
> Cc: stable@dpdk.org
>
> Signed-off-by: Sean Morrissey <sean.morrissey@intel.com>
> ---
> lib/librte_eal/common/eal_common_options.c | 3 +++
> lib/librte_eal/common/eal_options.h | 4 ++++
> 2 files changed, 7 insertions(+)
>
> diff --git a/lib/librte_eal/common/eal_common_options.c b/lib/librte_eal/common/eal_common_options.c
> index 512d5088e..24e36cf23 100644
> --- a/lib/librte_eal/common/eal_common_options.c
> +++ b/lib/librte_eal/common/eal_common_options.c
> @@ -81,6 +81,9 @@ eal_long_options[] = {
> {OPT_LEGACY_MEM, 0, NULL, OPT_LEGACY_MEM_NUM },
> {OPT_SINGLE_FILE_SEGMENTS, 0, NULL, OPT_SINGLE_FILE_SEGMENTS_NUM},
> {OPT_MATCH_ALLOCATIONS, 0, NULL, OPT_MATCH_ALLOCATIONS_NUM},
> +#ifdef RTE_LIBRTE_TELEMETRY
> + {OPT_TELEMETRY, 0, NULL, OPT_TELEMETRY_NUM },
> +#endif
> {0, 0, NULL, 0 }
> };
>
> diff --git a/lib/librte_eal/common/eal_options.h b/lib/librte_eal/common/eal_options.h
> index 9855429e5..e4c8e25c2 100644
> --- a/lib/librte_eal/common/eal_options.h
> +++ b/lib/librte_eal/common/eal_options.h
> @@ -69,6 +69,10 @@ enum {
> OPT_IOVA_MODE_NUM,
> #define OPT_MATCH_ALLOCATIONS "match-allocations"
> OPT_MATCH_ALLOCATIONS_NUM,
> +#ifdef RTE_LIBRTE_TELEMETRY
> + #define OPT_TELEMETRY "telemetry"
> + OPT_TELEMETRY_NUM,
> +#endif
> OPT_LONG_MAX_NUM
> };
>
LGTM, thanks!
Acked-by: Kevin Laatz <kevin.laatz@intel.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-stable] [PATCH] lib/librte_eal: fix unrecongized telemetry eal arg
2019-07-19 10:04 ` Laatz, Kevin
@ 2019-07-22 16:40 ` Thomas Monjalon
0 siblings, 0 replies; 4+ messages in thread
From: Thomas Monjalon @ 2019-07-22 16:40 UTC (permalink / raw)
To: Sean Morrissey
Cc: stable, Laatz, Kevin, dev, harry.vanhaaren, john.oloughlin,
marko.kovacevic, ciara.power
19/07/2019 12:04, Laatz, Kevin:
> On 15/07/2019 11:54, Sean Morrissey wrote:
> > Added telemetry to EAL long options so that when
> > --telemetry is passed as an EAL arg that there is
> > no unrecognized argument error message printed.
> >
> > Fixes: 8877ac688b52 ("telemetry: introduce infrastructure")
> > Cc: ciara.power@intel.com
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Sean Morrissey <sean.morrissey@intel.com>
>
> Acked-by: Kevin Laatz <kevin.laatz@intel.com>
Applied, thanks
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-stable] [PATCH] lib/librte_eal: fix unrecongized telemetry eal arg
[not found] <20190711144017.23081-1-sean.morrissey@intel.com>
@ 2019-07-11 15:33 ` OLoughlin, John
0 siblings, 0 replies; 4+ messages in thread
From: OLoughlin, John @ 2019-07-11 15:33 UTC (permalink / raw)
To: Morrissey, Sean; +Cc: ciara.power, stable
Hi Seán,
Thanks for that
I can confirm that the patch is functionally correct
Regards John
-----Original Message-----
From: Morrissey, Sean
Sent: Thursday, July 11, 2019 3:40 PM
To: OLoughlin, John <john.oloughlin@intel.com>
Cc: Morrissey, Sean <sean.morrissey@intel.com>; ciara.power@intel.com; stable@dpdk.org
Subject: [PATCH] lib/librte_eal: fix unrecongized telemetry eal arg
Added telemetry to EAL long options so that when --telemetry is passed as an EAL arg that there is no unrecognized argument error message printed.
Fixes: 8877ac688b52 ("telemetry: introduce infrastructure")
Cc: ciara.power@intel.com
Cc: stable@dpdk.org
Signed-off-by: Sean Morrissey <sean.morrissey@intel.com>
---
lib/librte_eal/common/eal_common_options.c | 3 +++
lib/librte_eal/common/eal_options.h | 8 +++++++-
2 files changed, 10 insertions(+), 1 deletion(-)
diff --git a/lib/librte_eal/common/eal_common_options.c b/lib/librte_eal/common/eal_common_options.c
index 512d5088e..b7e511a63 100644
--- a/lib/librte_eal/common/eal_common_options.c
+++ b/lib/librte_eal/common/eal_common_options.c
@@ -80,6 +80,9 @@ eal_long_options[] = {
{OPT_VMWARE_TSC_MAP, 0, NULL, OPT_VMWARE_TSC_MAP_NUM },
{OPT_LEGACY_MEM, 0, NULL, OPT_LEGACY_MEM_NUM },
{OPT_SINGLE_FILE_SEGMENTS, 0, NULL, OPT_SINGLE_FILE_SEGMENTS_NUM},
+#ifdef RTE_LIBRTE_TELEMETRY
+ {OPT_TELEMETRY, 0, NULL, OPT_TELEMETRY_NUM },
+#endif
{OPT_MATCH_ALLOCATIONS, 0, NULL, OPT_MATCH_ALLOCATIONS_NUM},
{0, 0, NULL, 0 }
};
diff --git a/lib/librte_eal/common/eal_options.h b/lib/librte_eal/common/eal_options.h
index 9855429e5..f819845f5 100644
--- a/lib/librte_eal/common/eal_options.h
+++ b/lib/librte_eal/common/eal_options.h
@@ -67,9 +67,15 @@ enum {
OPT_SINGLE_FILE_SEGMENTS_NUM,
#define OPT_IOVA_MODE "iova-mode"
OPT_IOVA_MODE_NUM,
+
+#ifdef RTE_LIBRTE_TELEMETRY
+ #define OPT_TELEMETRY "telemetry"
+ OPT_TELEMETRY_NUM,
+#endif
+
#define OPT_MATCH_ALLOCATIONS "match-allocations"
OPT_MATCH_ALLOCATIONS_NUM,
- OPT_LONG_MAX_NUM
+ OPT_LONG_MAX_NUM,
};
extern const char eal_short_options[];
--
2.17.1
--------------------------------------------------------------
Intel Research and Development Ireland Limited
Registered in Ireland
Registered Office: Collinstown Industrial Park, Leixlip, County Kildare
Registered Number: 308263
This e-mail and any attachments may contain confidential material for the sole
use of the intended recipient(s). Any review or distribution by others is
strictly prohibited. If you are not the intended recipient, please contact the
sender and delete all copies.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-07-22 16:40 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-15 10:54 [dpdk-stable] [PATCH] lib/librte_eal: fix unrecongized telemetry eal arg Sean Morrissey
2019-07-19 10:04 ` Laatz, Kevin
2019-07-22 16:40 ` Thomas Monjalon
[not found] <20190711144017.23081-1-sean.morrissey@intel.com>
2019-07-11 15:33 ` OLoughlin, John
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).