patches for DPDK stable branches
 help / color / mirror / Atom feed
* [dpdk-stable] [PATCH v2] kni: fix the type for MAC address
       [not found] <1548301983-20020-1-git-send-email-panjie5@jd.com>
@ 2019-04-10  6:05 ` Jie Pan
  2019-04-10  6:20 ` Jie Pan
  1 sibling, 0 replies; 5+ messages in thread
From: Jie Pan @ 2019-04-10  6:05 UTC (permalink / raw)
  To: cetc15panj; +Cc: Jie Pan, stable

The type for MAC address should be unsigned.

Fixes: 1cfe212ed17a ("kni: support MAC address change")
Cc: stable@dpdk.org

Signed-off-by: Jie Pan <panjie5@jd.com>
---
 kernel/linux/kni/kni_misc.c                       | 2 +-
 lib/librte_eal/linux/eal/include/rte_kni_common.h | 2 +-
 lib/librte_kni/rte_kni.h                          | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/kernel/linux/kni/kni_misc.c b/kernel/linux/kni/kni_misc.c
index 31845e1..b6f474d 100644
--- a/kernel/linux/kni/kni_misc.c
+++ b/kernel/linux/kni/kni_misc.c
@@ -447,7 +447,7 @@ struct kni_net {
 		ether_addr_copy(net_dev->dev_addr, kni->lad_dev->dev_addr);
 	else {
 		/* if user has provided a valid mac address */
-		if (is_valid_ether_addr((unsigned char *)(dev_info.mac_addr)))
+		if (is_valid_ether_addr(dev_info.mac_addr))
 			memcpy(net_dev->dev_addr, dev_info.mac_addr, ETH_ALEN);
 		else
 			/*
diff --git a/lib/librte_eal/linux/eal/include/rte_kni_common.h b/lib/librte_eal/linux/eal/include/rte_kni_common.h
index 5afa087..5db5a13 100644
--- a/lib/librte_eal/linux/eal/include/rte_kni_common.h
+++ b/lib/librte_eal/linux/eal/include/rte_kni_common.h
@@ -127,7 +127,7 @@ struct rte_kni_device_info {
 	/* mbuf size */
 	unsigned mbuf_size;
 	unsigned int mtu;
-	char mac_addr[6];
+	uint8_t mac_addr[6];
 };
 
 #define KNI_DEVICE "kni"
diff --git a/lib/librte_kni/rte_kni.h b/lib/librte_kni/rte_kni.h
index 9a9a7d7..c93d3a9 100644
--- a/lib/librte_kni/rte_kni.h
+++ b/lib/librte_kni/rte_kni.h
@@ -68,7 +68,7 @@ struct rte_kni_conf {
 
 	__extension__
 	uint8_t force_bind : 1; /* Flag to bind kernel thread */
-	char mac_addr[ETHER_ADDR_LEN]; /* MAC address assigned to KNI */
+	uint8_t mac_addr[ETHER_ADDR_LEN]; /* MAC address assigned to KNI */
 	uint16_t mtu;
 };
 
-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [dpdk-stable] [PATCH v2] kni: fix the type for MAC address
       [not found] <1548301983-20020-1-git-send-email-panjie5@jd.com>
  2019-04-10  6:05 ` [dpdk-stable] [PATCH v2] kni: fix the type for MAC address Jie Pan
@ 2019-04-10  6:20 ` Jie Pan
  2019-04-19 12:15   ` Ferruh Yigit
  1 sibling, 1 reply; 5+ messages in thread
From: Jie Pan @ 2019-04-10  6:20 UTC (permalink / raw)
  To: ferruh.yigit; +Cc: dev, Jie Pan, stable

The type for MAC address should be unsigned.

Fixes: 1cfe212ed17a ("kni: support MAC address change")
Cc: stable@dpdk.org

Signed-off-by: Jie Pan <panjie5@jd.com>
---
 kernel/linux/kni/kni_misc.c                       | 2 +-
 lib/librte_eal/linux/eal/include/rte_kni_common.h | 2 +-
 lib/librte_kni/rte_kni.h                          | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/kernel/linux/kni/kni_misc.c b/kernel/linux/kni/kni_misc.c
index 31845e1..b6f474d 100644
--- a/kernel/linux/kni/kni_misc.c
+++ b/kernel/linux/kni/kni_misc.c
@@ -447,7 +447,7 @@ struct kni_net {
 		ether_addr_copy(net_dev->dev_addr, kni->lad_dev->dev_addr);
 	else {
 		/* if user has provided a valid mac address */
-		if (is_valid_ether_addr((unsigned char *)(dev_info.mac_addr)))
+		if (is_valid_ether_addr(dev_info.mac_addr))
 			memcpy(net_dev->dev_addr, dev_info.mac_addr, ETH_ALEN);
 		else
 			/*
diff --git a/lib/librte_eal/linux/eal/include/rte_kni_common.h b/lib/librte_eal/linux/eal/include/rte_kni_common.h
index 5afa087..5db5a13 100644
--- a/lib/librte_eal/linux/eal/include/rte_kni_common.h
+++ b/lib/librte_eal/linux/eal/include/rte_kni_common.h
@@ -127,7 +127,7 @@ struct rte_kni_device_info {
 	/* mbuf size */
 	unsigned mbuf_size;
 	unsigned int mtu;
-	char mac_addr[6];
+	uint8_t mac_addr[6];
 };
 
 #define KNI_DEVICE "kni"
diff --git a/lib/librte_kni/rte_kni.h b/lib/librte_kni/rte_kni.h
index 9a9a7d7..c93d3a9 100644
--- a/lib/librte_kni/rte_kni.h
+++ b/lib/librte_kni/rte_kni.h
@@ -68,7 +68,7 @@ struct rte_kni_conf {
 
 	__extension__
 	uint8_t force_bind : 1; /* Flag to bind kernel thread */
-	char mac_addr[ETHER_ADDR_LEN]; /* MAC address assigned to KNI */
+	uint8_t mac_addr[ETHER_ADDR_LEN]; /* MAC address assigned to KNI */
 	uint16_t mtu;
 };
 
-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dpdk-stable] [PATCH v2] kni: fix the type for MAC address
  2019-04-10  6:20 ` Jie Pan
@ 2019-04-19 12:15   ` Ferruh Yigit
  2019-04-19 15:29     ` [dpdk-stable] [dpdk-dev] " Rami Rosen
  0 siblings, 1 reply; 5+ messages in thread
From: Ferruh Yigit @ 2019-04-19 12:15 UTC (permalink / raw)
  To: Jie Pan; +Cc: dev, stable

On 4/10/2019 7:20 AM, Jie Pan wrote:
> The type for MAC address should be unsigned.
> 
> Fixes: 1cfe212ed17a ("kni: support MAC address change")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Jie Pan <panjie5@jd.com>

Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dpdk-stable] [dpdk-dev] [PATCH v2] kni: fix the type for MAC address
  2019-04-19 12:15   ` Ferruh Yigit
@ 2019-04-19 15:29     ` Rami Rosen
  2019-04-19 20:58       ` Thomas Monjalon
  0 siblings, 1 reply; 5+ messages in thread
From: Rami Rosen @ 2019-04-19 15:29 UTC (permalink / raw)
  To: Ferruh Yigit; +Cc: Jie Pan, dev, stable

On 4/10/2019 7:20 AM, Jie Pan wrote:
> The type for MAC address should be unsigned.
>
> Fixes: 1cfe212ed17a ("kni: support MAC address change")
> Cc: stable@dpdk.org
>
> Signed-off-by: Jie Pan <panjie5@jd.com>

Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>

Reviewed-by: Rami Rosen <ramirose@gmail.com>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dpdk-stable] [dpdk-dev] [PATCH v2] kni: fix the type for MAC address
  2019-04-19 15:29     ` [dpdk-stable] [dpdk-dev] " Rami Rosen
@ 2019-04-19 20:58       ` Thomas Monjalon
  0 siblings, 0 replies; 5+ messages in thread
From: Thomas Monjalon @ 2019-04-19 20:58 UTC (permalink / raw)
  To: Ferruh Yigit; +Cc: dev, Rami Rosen, Jie Pan, stable

19/04/2019 17:29, Rami Rosen:
> On 4/10/2019 7:20 AM, Jie Pan wrote:
> > The type for MAC address should be unsigned.
> >
> > Fixes: 1cfe212ed17a ("kni: support MAC address change")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Jie Pan <panjie5@jd.com>
> 
> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
> 
> Reviewed-by: Rami Rosen <ramirose@gmail.com>

Applied, thanks



^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2019-04-19 20:58 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <1548301983-20020-1-git-send-email-panjie5@jd.com>
2019-04-10  6:05 ` [dpdk-stable] [PATCH v2] kni: fix the type for MAC address Jie Pan
2019-04-10  6:20 ` Jie Pan
2019-04-19 12:15   ` Ferruh Yigit
2019-04-19 15:29     ` [dpdk-stable] [dpdk-dev] " Rami Rosen
2019-04-19 20:58       ` Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).