From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3B2CCA0032 for ; Fri, 18 Feb 2022 16:50:56 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 33BE540141; Fri, 18 Feb 2022 16:50:56 +0100 (CET) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id D390740141; Fri, 18 Feb 2022 16:50:53 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1645199454; x=1676735454; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=eoRH1PSfUzJ1sKkrdeT52y99Ev9Qj6tfKBACGp203QI=; b=UY+nC+Jp0aDd+/q35+1RNkMpuEI8bcFO7JB/5M7/Uf363OIQwgwjbudM 9UHYbzx1dw80I8ZP9f5nZfhZg+KlMN1xsemPj0K7J/Y0gjrHK7hDajK8e ea1+ibqxK1S53uDM2pCWGKEXLzNaaLcUEUdw3SauyQJEuA33i8YIC+1y+ fVvzaBjU/kH3/PG7Iljr1sfCqq6Bp89A6n+86hOOwL9TqXfnxJAL5Cjz/ UIcpf0MOdPsxjMOXELRHp3MBs6mWu1s7CgqATAcHYi8FVyuxbOpWGHZX4 Oca6sjEftpoXlLt6LPHT7L+jEZ8kyxvknInbwPd61NoTZFwq2YmkaEoQs g==; X-IronPort-AV: E=McAfee;i="6200,9189,10261"; a="337593462" X-IronPort-AV: E=Sophos;i="5.88,379,1635231600"; d="scan'208";a="337593462" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Feb 2022 07:50:52 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,379,1635231600"; d="scan'208";a="682543975" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmsmga001.fm.intel.com with ESMTP; 18 Feb 2022 07:50:52 -0800 Received: from orsmsx604.amr.corp.intel.com (10.22.229.17) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Fri, 18 Feb 2022 07:50:51 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Fri, 18 Feb 2022 07:50:51 -0800 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.171) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Fri, 18 Feb 2022 07:50:51 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lUq/5LM+A9LrnbTy9G/aKtyjqLA7q4lru/jL+EgXjZRQo6xKyayzMpRAJukFobka83lNx8hsYRjzMuVYXM4jqS5z/pgcNRmNiNEPIlHejuZNTDGsrbjEzCzx07XLmb7KFXlvSd/aXXL3SnSmeHT7dimF1x1tnhSmR+LpQCRrwE0GBFSSRWnTHXVyZBYC+pfM68/QwGfua8QPGmolECmkM5nrt0kOqGeAEU6yUHxvFvvxDOEL7c4DtOuxKcNK/jDP0pEE0nHyYT8QsfqFJnCmrveXdwR6E/QhaJDAr4st9N7tJs2CuplTFzlIYevpjH13apmhNqqOHYUjCDqWs7H0kA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=L68AtMFmyQjff7vfmD+VAR0+Yzf5mSJXzxOUuFGHVH4=; b=CAPK5CfASe6ChXthamoKPqXsb/0BtQlWP9zzSDTqaVgHBv+bqPAjwe7AbO4sisXbAL5Oy4X88bj7dn1feJxr9tB57/aJCtdCR2XJh94tq5H3zzR26RB65iWWEQCg4oaAG/rVe0sa/HD46snoxkvewQjAfNm8PPfKPj5fK4/aK79syradsEUNkfl9ZrWm8CJoDpt64JyzMFgKmddNgoR2LB3OmBLVqLGDY4PFhxbwAFM2zvwgO+GGNYEHm/eVrlsCqDRlce8KL3tLHctTCq0pHRSpKEppWzhfvTm83icehT95d1XuRcgFx8dC18y7/K+aG/6vBzajMlP+OD3SEoKrFA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by SJ0PR11MB4990.namprd11.prod.outlook.com (2603:10b6:a03:2d8::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.16; Fri, 18 Feb 2022 15:50:49 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::98be:5506:5020:28a2]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::98be:5506:5020:28a2%4]) with mapi id 15.20.4995.024; Fri, 18 Feb 2022 15:50:49 +0000 Message-ID: <19185cf3-72ea-4a77-fbc4-db6773a3022a@intel.com> Date: Fri, 18 Feb 2022 15:50:40 +0000 Subject: Re: [PATCH] net/sfc: fix the argument to sizeof for unit cache Content-Language: en-US To: Andrew Rybchenko , Weiguo Li CC: , , References: <191c80de-37d4-da06-5fef-fdc3e47c58cb@intel.com> <8c95121b-bb87-55c0-5d2b-d98f19c87283@oktetlabs.ru> From: Ferruh Yigit X-User: ferruhy In-Reply-To: <8c95121b-bb87-55c0-5d2b-d98f19c87283@oktetlabs.ru> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0041.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:61::29) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ee0d0816-718a-4bbe-e8a3-08d9f2f66f87 X-MS-TrafficTypeDiagnostic: SJ0PR11MB4990:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:2201; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ZmS8YusoPu5Vt0oZ/1ntvGxPg+Ni9IjmiW8E7p/HOhjSawIl/bbRjePSOTwooEM7g9Xl5TzWO8olKt/7NzMQKJGG5f/ACOaM5vSBOdaMV23vK6HXtVME5KN8/DJsFbNe8F7DfK51r3+UeGI5EJOsqBWTSmvFz4/sZ70ZahEKPWlwFvkxgYU12wloOTg6UyY2iMx2elBaAhXPTO98CqumcqTfEO+FkRQVyZuY4saz5mZNtxTzhh6uhxnLpg0l+IhjyrfGx0cC75eL2XObzyzh4DFvG+0RlFx6gUb5ep2wYAP5kKkI19Psmf2ONCPrBnNfHj3jobB0jpIEvUvg/3nbFvOxisuCWWwLXONb1SCVc+N/VVx5b/C5lV6UtucvMMBi3KmAuRRoi5whUT8IzXtaoKRSd0VQ636ZdQrmA4L6IsKAhVuLlN2hIeg6cYJRMERk0cCwnlQ/rR42jNwhtOWcUOVd4F3ADNT3usWxm2u5YQ7AcwXGvaeLHhfw/WdfN28+7p+Nf2d71IneCXJrhBmZNAI5IazeabvkxNRSiAniuwK+QUKQUJhMhgUH5iYMEUGXu7B8ctGoI2YjlHNudGqodtTMkZJ2lITQhF15ATWVvGeX4+Y4V7FeyTRmB8qlxlW8oUbz8R37sRmC4bTzdbk+v5blXRv/ZWy5ISD1gumorIfpRsd5s0gtSlcNoutOp0cHKjbSiGm3pRVYTQwXGuGrvWGlguOaVvRvyQix/IBtUc90LU60gmm58j7TM0yRniMHPHBKuJpRDnRA4Y40KIN+0Lf6cqAWP6Lf14rhsBVEXx+baBhqITJtUt4w/vnyorTY X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(5660300002)(2616005)(66946007)(38100700002)(8676002)(4326008)(2906002)(26005)(8936002)(66556008)(186003)(44832011)(31696002)(6666004)(66476007)(6506007)(53546011)(316002)(508600001)(86362001)(36756003)(110136005)(6486002)(966005)(4744005)(6512007)(82960400001)(31686004)(48020200001)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?b0tSbkhOanhZak4zZEw0dUhUTzJvNjVNd05tdWtIN1ZQOEN3QmsrdTFrZ0ox?= =?utf-8?B?enFwMnYxNldQTnVUWEVidVlaQUEvOHkrbUQ2M3BqVFV4Y2xVWU1pS251c2RF?= =?utf-8?B?cUNLQ3l1REhGa1VudktDcmNBM3RHVW5vbUZWSVNEcWEzQkxQUlVNR1FuTmZV?= =?utf-8?B?VlVYSjdjTm5JVS8wZmhkdlEvd1lRUDV3ZlpnK25INDFtODVGWWZ6NXZRV1RQ?= =?utf-8?B?M0cyRzFxVFhiVW9sVU5RRGZYMStkRkgxb0QwQUpMZmd3OUk3aWxObk1ycGlU?= =?utf-8?B?NEtHTnJBYWtGSU1iRkx5YTFmS1cyaWtIMHNNbFRmYXZvWGxiTXJTY1JEQ21o?= =?utf-8?B?WTZWT1cwTm9oVVBaVjBkcFNBYmJ2b01KMG5oZE40RmlUYU0wUFNlQ0xKM2NU?= =?utf-8?B?eEJlSUUxcmlQSE1Nd1piRVhWc1I2ZnRSL2RsQnZiQUdjcy8rNUpzRTVIbXZ4?= =?utf-8?B?S1lvcktjNE41VG04eTRlSGsrNFBrQ0cydStQalJHZnJSS21LeFlHVkJyeTlJ?= =?utf-8?B?WjhseTluSVRUSjg5ZjlpaDlPLzhRS21OZlNpcWtxbjBlTzZOeXhZMmVYZkJx?= =?utf-8?B?UWhjQkFYd3BNOERhMTBPWUtmY0hMUVZnb0FRYWlCOWczb082VUE3RXhzemVV?= =?utf-8?B?VlYwU09JN2NocHB5cDRwMDBGeFFpR3FZc2wxWThoZExLamI4ckVXMVRIVk53?= =?utf-8?B?S2pXQlgyQndUM3U1YmRPbXRXbnJtZmIwSExIYlh2RHNPQ1QwUDlkS3phN1RL?= =?utf-8?B?T0paZitRc0VCeVRGZThya2pQakJaZWVLbEQrandPRUlDSllxUW5RODdmbmJl?= =?utf-8?B?Sm8ybmNlaWVGeWxhN2phWTA5RklRbnRkRGxwa01kRC9VdVNRNVhMOUVUcWhG?= =?utf-8?B?eHJRMnJLUmZRVU9ETTZIdmNLTUhFRmlnZGtkYTNPY3o4aElET2t5UllyQURJ?= =?utf-8?B?MHRsbnJHZzFlQWNQblJmN3B3WFFCS0N2UWF1Sm51WElDUVZ4MEVpTVFQU1ho?= =?utf-8?B?L3ZPYmhtV25TRW4wYUhFWEZROWZWcG84RzA5TVJnWEcxL3QySk80c1E1L1Yy?= =?utf-8?B?bWRLUnhkRlpEM2FIQ0RSWmZwc29TRXRySEFLbFF0Mlg0VDQyY3p1cU1hcmFU?= =?utf-8?B?M280SEE3eEJkWEttZkJpRTRTend2Y1NzZEhnbkdibE5RNkpVNUN5WlJwbUY0?= =?utf-8?B?dEtiQktUeHV3bXVMekcvb2tiengzWU9ITVZUcEZ4bDZTcllFbGEzMHRPNENE?= =?utf-8?B?c3pGR1NaZTlIcmZEbnVVRTJNN3IxVWxWK0hNczVieklUaE1VSjZTMjY4K3ZB?= =?utf-8?B?YXBXRXQ1OWxka3dJZGRQQmU4RVdoRmFPd3dDQ0JZQWRrSXd6QmJQdXFLQU1X?= =?utf-8?B?QXgyZ3dQM2hpZGRrZ0VQNEJGdzVXSzlwSUdhNE5xc2tETEFyZGdJajVoOXNs?= =?utf-8?B?NWl5azNlT29JZkpqL2IxSGp6RDMxUWVNbldobDlWZUdCYUxVQ3I3ZndRemIw?= =?utf-8?B?Q0llNzlpSEF6Zkh1YUpSdlYvcVRuaTVBeFNaQmsrQjREaC9VbElLR2t1WThI?= =?utf-8?B?eW1GOWVhRFlESkdRVzRwTjlxVmtmTEdDa2RqOG1xemlGdlRSMzRIczF1amVS?= =?utf-8?B?Rm5RdmJ2L2U1MnZMeUpNV0N5SjRHY3dXWVJ4SC9xemdqdlNvZlczZjNjMWdR?= =?utf-8?B?QTU3Nk5Sb1pkR1JpdG9wSndWZjJxUjlQSEp2T01MZVNqNHdjdmh1bEUxTDZa?= =?utf-8?B?WVB4R0t5QnF4YkpadjVGRDgxQi83Z1VmUjFYa1dTeFk1dkFBK3c1YWt3TVpa?= =?utf-8?B?K1V6WmlqSFJzUzdCaVlxNEhTWmtFbjRnb3YwRU5Ubnpod290djNqemtHM3JF?= =?utf-8?B?SWVZVGlTRzhWZmo3VHR6Z0pnU1VpZzlJN3RpbjlPNXRCRldDWUUrNGV3R2xW?= =?utf-8?B?WGZaUW9tei9YdEthN3RXd0RacUpENElvdkwxVW94dUJzd1IxOXBvT1lNVHV6?= =?utf-8?B?VVZhYlpYcTZvQTBBeW1WSkZEcVhldHc3TEZzbEJUVENnR09jT1dsYTJ2SVdq?= =?utf-8?B?clRMMEpocWlXRFA0Q2ZUYXlRclBSUnYvLy9lWFQweEpaNXhiVGQ3eVVWRU0y?= =?utf-8?B?UGwyZjdQRnZxZy80ZCtZQUJYeVJ3cmt1dVduUDBIVzNwNERSZmQrcndWNHlU?= =?utf-8?Q?xYHZlYQYG76umr/aXuoiwO4=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: ee0d0816-718a-4bbe-e8a3-08d9f2f66f87 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Feb 2022 15:50:49.9047 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ITx/r8N2gJQlhwN2cbr1LTU1F+j3dngQZ+utjVphTHtAfAU2dbWGVTCEuKv+Frp93hfQaFP05ChVz0QKp3gRoA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB4990 X-OriginatorOrg: intel.com X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On 2/18/2022 2:43 PM, Andrew Rybchenko wrote: > On 2/18/22 17:38, Ferruh Yigit wrote: >> On 12/21/2021 6:41 AM, Weiguo Li wrote: >>> The size of unit cache should be sizeof(**cache) instead of >>> sizeof(*cache). Memory reallocation is inadequate by sizeof(*cache) >>> for the platform whose size of pointer is 32-bits. Found by coccinelle >>> (see https://coccinelle.gitlabpages.inria.fr/website) script. >>> >>> Fixes: 63abf8d29225 ("net/sfc: support SW stats groups") >>> Cc: stable@dpdk.org >>> >>> Signed-off-by: Weiguo Li > > Reviewed-by: Andrew Rybchenko > Applied to dpdk-next-net/main, thanks.