patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Tal Shnaiderman <talshn@nvidia.com>
Cc: dev@dpdk.org, matan@nvidia.com, rasland@nvidia.com,
	ophirmu@nvidia.com, stable@dpdk.org
Subject: Re: [dpdk-stable] [PATCH] net/mlx5/windows: fix link speed calculation
Date: Mon, 05 Apr 2021 21:01:14 +0200	[thread overview]
Message-ID: <1920198.nUkcdjmOzk@thomas> (raw)
In-Reply-To: <20210405161844.9560-1-talshn@nvidia.com>

There is no previous commit with net/mlx5/windows as title prefix.
In general, there is "on Windows" at the end of the title.
This way we can have the same formatting when fixing the common code
for a Windows case.

05/04/2021 18:18, Tal Shnaiderman:
> In Windows DevX returns the value of the current link speed
> in bps rate, the conversion to the Mbps rate expected by DPDK
> is incorrect and fixed.

"was" incorrect.

I think you should explain the confusion between Mbit/s and Mibit/s.

> -	dev_link.link_speed = context_obj->mlx5_dev.link_speed / (1024 * 1024);
> +	dev_link.link_speed = context_obj->mlx5_dev.link_speed / (1000 * 1000);




  reply	other threads:[~2021-04-05 19:01 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-05 16:18 Tal Shnaiderman
2021-04-05 19:01 ` Thomas Monjalon [this message]
2021-04-06  7:02   ` Tal Shnaiderman
2021-04-06  7:31 ` [dpdk-stable] [PATCH v2] net/mlx5: fix link speed calculation on Windows Tal Shnaiderman
2021-04-06  7:46   ` Matan Azrad
2021-04-08 10:59   ` Raslan Darawsheh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1920198.nUkcdjmOzk@thomas \
    --to=thomas@monjalon.net \
    --cc=dev@dpdk.org \
    --cc=matan@nvidia.com \
    --cc=ophirmu@nvidia.com \
    --cc=rasland@nvidia.com \
    --cc=stable@dpdk.org \
    --cc=talshn@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).