* [dpdk-stable] [PATCH] devtools: fix file listing in maintainers check
@ 2021-06-15 12:49 Thomas Monjalon
2021-06-23 9:19 ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon
0 siblings, 1 reply; 2+ messages in thread
From: Thomas Monjalon @ 2021-06-15 12:49 UTC (permalink / raw)
To: dev; +Cc: stable
When having multiple working trees, the main one has a .git directory
while attached trees have a .git file.
Thus the git check should work for both file and directory.
In the case there is no working tree (.git not readable), the command
"find" is used and should be able to list paths with wildcards.
Wildcards work only as shell expansion in the case of file paths,
so the quotes must be removed.
Fixes: 27c2ce563216 ("maintainers: start a Linux-style file")
Cc: stable@dpdk.org
Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
---
devtools/check-maintainers.sh | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/devtools/check-maintainers.sh b/devtools/check-maintainers.sh
index df3f740b6e..71697bb352 100755
--- a/devtools/check-maintainers.sh
+++ b/devtools/check-maintainers.sh
@@ -15,10 +15,10 @@ files () # <path> [<path> ...]
if [ -z "$1" ] ; then
return
fi
- if [ -d .git ] ; then
+ if [ -r .git ] ; then
git ls-files "$1"
else
- find "$1" -type f |
+ find $1 -type f |
sed 's,^\./,,'
fi |
# if not ended by /
--
2.31.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [dpdk-stable] [dpdk-dev] [PATCH] devtools: fix file listing in maintainers check
2021-06-15 12:49 [dpdk-stable] [PATCH] devtools: fix file listing in maintainers check Thomas Monjalon
@ 2021-06-23 9:19 ` Thomas Monjalon
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Monjalon @ 2021-06-23 9:19 UTC (permalink / raw)
To: dev; +Cc: stable, david.marchand
15/06/2021 14:49, Thomas Monjalon:
> When having multiple working trees, the main one has a .git directory
> while attached trees have a .git file.
> Thus the git check should work for both file and directory.
>
> In the case there is no working tree (.git not readable), the command
> "find" is used and should be able to list paths with wildcards.
> Wildcards work only as shell expansion in the case of file paths,
> so the quotes must be removed.
>
> Fixes: 27c2ce563216 ("maintainers: start a Linux-style file")
> Cc: stable@dpdk.org
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
Applied
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-06-23 9:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-15 12:49 [dpdk-stable] [PATCH] devtools: fix file listing in maintainers check Thomas Monjalon
2021-06-23 9:19 ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).