From: Thomas Monjalon <thomas@monjalon.net>
To: Gavin Hu <gavin.hu@arm.com>
Cc: stable@dpdk.org, dev@dpdk.org, nd@arm.com,
Honnappa.Nagarahalli@arm.com, dharmik.thakkar@arm.com
Subject: Re: [dpdk-stable] [PATCH v4] test/rcu: fix build for small number of cores
Date: Mon, 25 Nov 2019 23:40:43 +0100 [thread overview]
Message-ID: <1986568.lXXHI0cLKO@xps> (raw)
In-Reply-To: <1574652993-17755-1-git-send-email-gavin.hu@arm.com>
25/11/2019 04:36, Gavin Hu:
> If the RTE_MAX_LCORE is less than 10, a compilation error is generated:
> app/test/test_rcu_qsbr.c:234:10: error: comparison of integer
> expressions of different signedness: ‘unsigned int’ and ‘int’
> [-Werror=sign-compare]
>
> The cause is (RTE_MAX_LCORE - 10) results in a negative value.
>
> To fix, use rte_rand() to find a number between 0 and RTE_MAX_LCORE.
>
> Fixes: b87089b0bb19 ("test/rcu: add API and functional tests")
> Cc: stable@dpdk.org
>
> Signed-off-by: Gavin Hu <gavin.hu@arm.com>
> Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
> Reviewed-by: Steve Capper <steve.capper@arm.com>
> Reviewed-by: Dharmik Thakkar <dharmik.thakkar@arm.com>
Applied, thanks
prev parent reply other threads:[~2019-11-25 22:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1564616902-13861-1-git-send-email-gavin.hu@arm.com>
2019-07-31 23:32 ` [dpdk-stable] [PATCH 1/2] test/rcu: fix the compiling error for armv8.2 Gavin Hu
2019-07-31 23:48 ` [dpdk-stable] [PATCH v2 1/3] " Gavin Hu
2019-11-11 5:41 ` [dpdk-stable] [PATCH v3 " Gavin Hu
2019-11-20 22:18 ` Thomas Monjalon
2019-11-21 11:23 ` Gavin Hu (Arm Technology China)
2019-11-25 3:36 ` [dpdk-stable] [PATCH v4] test/rcu: fix build for small number of cores Gavin Hu
2019-11-25 22:40 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1986568.lXXHI0cLKO@xps \
--to=thomas@monjalon.net \
--cc=Honnappa.Nagarahalli@arm.com \
--cc=dev@dpdk.org \
--cc=dharmik.thakkar@arm.com \
--cc=gavin.hu@arm.com \
--cc=nd@arm.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).