patches for DPDK stable branches
 help / color / mirror / Atom feed
* [dpdk-stable] [PATCH 1/2] eal/windows: do not install virt2phys header
       [not found] <20211001163726.78308-1-dmitry.kozliuk@gmail.com>
@ 2021-10-01 16:37 ` Dmitry Kozlyuk
  2021-10-11 19:07   ` Thomas Monjalon
  0 siblings, 1 reply; 2+ messages in thread
From: Dmitry Kozlyuk @ 2021-10-01 16:37 UTC (permalink / raw)
  To: dev
  Cc: Dmitry Kozlyuk, stable, Narcisa Ana Maria Vasile, Dmitry Malloy,
	Pallavi Kadam

The header was not intended to be a public one.
DPDK users should use `rte_mem_virt2iova()` to translate addresses.
Other virt2phys users should use the header from the driver instead.

Fixes: 2a5d547a4a9b ("eal/windows: implement basic memory management")
Cc: stable@dpdk.org

Signed-off-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
---
 lib/eal/windows/include/meson.build | 1 -
 1 file changed, 1 deletion(-)

diff --git a/lib/eal/windows/include/meson.build b/lib/eal/windows/include/meson.build
index b3534b025f..5fb1962ac7 100644
--- a/lib/eal/windows/include/meson.build
+++ b/lib/eal/windows/include/meson.build
@@ -5,6 +5,5 @@ includes += include_directories('.')
 
 headers += files(
         'rte_os.h',
-        'rte_virt2phys.h',
         'rte_windows.h',
 )
-- 
2.29.3


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dpdk-stable] [PATCH 1/2] eal/windows: do not install virt2phys header
  2021-10-01 16:37 ` [dpdk-stable] [PATCH 1/2] eal/windows: do not install virt2phys header Dmitry Kozlyuk
@ 2021-10-11 19:07   ` Thomas Monjalon
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Monjalon @ 2021-10-11 19:07 UTC (permalink / raw)
  To: Dmitry Kozlyuk
  Cc: dev, stable, stable, Narcisa Ana Maria Vasile, Dmitry Malloy,
	Pallavi Kadam

01/10/2021 18:37, Dmitry Kozlyuk:
> The header was not intended to be a public one.
> DPDK users should use `rte_mem_virt2iova()` to translate addresses.
> Other virt2phys users should use the header from the driver instead.
> 
> Fixes: 2a5d547a4a9b ("eal/windows: implement basic memory management")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
> ---
>  headers += files(
>          'rte_os.h',
> -        'rte_virt2phys.h',
>          'rte_windows.h',
>  )

We should plan to rename it.
Files starting with rte_ are supposed to be public.



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-10-11 19:07 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20211001163726.78308-1-dmitry.kozliuk@gmail.com>
2021-10-01 16:37 ` [dpdk-stable] [PATCH 1/2] eal/windows: do not install virt2phys header Dmitry Kozlyuk
2021-10-11 19:07   ` Thomas Monjalon

patches for DPDK stable branches

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ http://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git