From: "Rao, Nikhil" <nikhil.rao@intel.com>
To: "jerinj@marvell.com" <jerinj@marvell.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] eventdev: fix doxygen comment
Date: Mon, 24 Jun 2019 06:13:51 +0000 [thread overview]
Message-ID: <1F668163772FA946975B9466A9DFF729EDE624AA@ORSMSX122.amr.corp.intel.com> (raw)
In-Reply-To: <20190619080309.32188-1-jerinj@marvell.com>
Hi Jerin,
> -----Original Message-----
> From: jerinj@marvell.com [mailto:jerinj@marvell.com]
> Sent: Wednesday, June 19, 2019 1:33 PM
> To: dev@dpdk.org; Jerin Jacob <jerinj@marvell.com>
> Cc: stable@dpdk.org; Rao, Nikhil <nikhil.rao@intel.com>
> Subject: [dpdk-dev] [PATCH] eventdev: fix doxygen comment
>
> From: Jerin Jacob <jerinj@marvell.com>
>
> Update rte_eventdev.h file description to adapt to Tx adapter changes.
>
> Fixes: c9bf83947e2e ("eventdev: add eth Tx adapter APIs")
> Cc: stable@dpdk.org
> Cc: Nikhil Rao <nikhil.rao@intel.com>
>
> Signed-off-by: Jerin Jacob <jerinj@marvell.com>
> ---
> lib/librte_eventdev/rte_eventdev.h | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/lib/librte_eventdev/rte_eventdev.h
> b/lib/librte_eventdev/rte_eventdev.h
> index 517cd8083..a5ec5d99b 100644
> --- a/lib/librte_eventdev/rte_eventdev.h
> +++ b/lib/librte_eventdev/rte_eventdev.h
> @@ -181,9 +181,9 @@
> * The *dequeue* operation gets one or more events from the event ports.
> * The application process the events and send to downstream event queue
> through
> * rte_event_enqueue_burst() if it is an intermediate stage of event
> processing,
> - * on the final stage, the application may send to different subsystem like
> - * ethdev to send the packet/event on the wire using ethdev
> - * rte_eth_tx_burst() API.
> + * on the final stage, the application may send to Tx adapter for
> maintaining
> + * the ingress order and then to send the packet/event on the wire using
> + * rte_event_eth_tx_adapter_enqueue() API.
Since the change above is applicable only if eventdev supports the RTE_EVENT_ETH_TX_ADAPTER_CAP_INTERNAL_PORT, can we rephrase to include both cases ? The Tx adapter documentation has the details, it would be good to cross reference it.
Thanks,
Nikhil
> *
> * The point at which events are scheduled to ports depends on the device.
> * For hardware devices, scheduling occurs asynchronously without any
> software
> --
> 2.21.0
next prev parent reply other threads:[~2019-06-24 6:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-19 8:03 jerinj
2019-06-24 6:13 ` Rao, Nikhil [this message]
2019-07-02 6:45 ` [dpdk-stable] [dpdk-dev] [PATCH v2] " jerinj
2019-07-02 7:35 ` Rao, Nikhil
2019-07-02 7:44 ` Jerin Jacob Kollanukkaran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1F668163772FA946975B9466A9DFF729EDE624AA@ORSMSX122.amr.corp.intel.com \
--to=nikhil.rao@intel.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).