From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1F4B2A04A6 for ; Wed, 9 Feb 2022 14:57:12 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0F34141223; Wed, 9 Feb 2022 14:57:12 +0100 (CET) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mails.dpdk.org (Postfix) with ESMTP id C95A340140; Wed, 9 Feb 2022 14:57:09 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1644415030; x=1675951030; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=ONGcoMmup53F0ytXsDV9EaGfhmtcY/ZC6aJgEfVzKfY=; b=Ub/VdKrt1ipwoa/S/vGoJPFedrNu7YheK+ESJHg8QiN7eUPHjJWLOTbl Bf0tIp4jakB4b1WdSqmqPDozmFykNnjfcxy0f3NVggNbtYRClOWe/j4bU ucL239RJmzQoC+XJk6H8vORKWeaX5iYHlUPYKySZdIBDjVm2g8yjyhYbv f32CzmdiWdfROjQ7yD0PkRAWtvrf1VMYp3eY7cMEBNhf8Ugx4OM3j/vu3 PYglLKRXLhomTtxiC/HMLhlBJ1vKcn7YQcD+VrMqwXEZn+wXJmc6pKB3q MldAHmhoVN6TySjKwpAJzTG3MN/CoPzIALE7kvwXgyr2F4Byjg+6/95sA w==; X-IronPort-AV: E=McAfee;i="6200,9189,10252"; a="249156535" X-IronPort-AV: E=Sophos;i="5.88,355,1635231600"; d="scan'208";a="249156535" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Feb 2022 05:57:08 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,355,1635231600"; d="scan'208";a="485247271" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga006.jf.intel.com with ESMTP; 09 Feb 2022 05:57:08 -0800 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Wed, 9 Feb 2022 05:57:07 -0800 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Wed, 9 Feb 2022 05:57:07 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Wed, 9 Feb 2022 05:57:07 -0800 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.102) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Wed, 9 Feb 2022 05:57:06 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HHeU1dW8b3Srxbb/nlIGqXnCZOomhwQjDGahoGJzlBf+/gdHd9l3f0umiqbBRxjVCVmeWfC0G63AA+WjboFh59Ic0gNr9lNHLF16i6WxBUBiiaId1FuPK7u8XLOWhc4dLzKMEUD4JYG24CnSLXK4T2llhskdPbBPQeERfsTtKEDlUQghrgq9NC8qEtOoLvLQedczhKMGH6NoC6GFTYv4D+Sto1jdLOv3rtEtIau28uba/0bVMvn6sXSs+hwA1RC2U+d3n6KK71s6YmOySI8hNjpi+C77Vqz5n3Z+HIjLhFqq8yCBTTakchmxHvAfcVgi5DY7hsJoTSBL9SJsS63jaw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sHX2Kt9CUV3Gxti4DQAgn2rBuYyT91YF3C6Gpu2HN1Q=; b=dX/8Yg/GWg9am57T7thKfhaq0aWCuUDXsJ0iW0j+00rn+AOeK+gXAO1n0FTftA6fAbsbjhSCCkfIPrK2SWJUGy0rNCiBdGsPs7/J05O9wzwUXpY4M9GfaO5szUCTPcSqR72YqhoAynNv556PQtBMNr1dKoKsTRQ+qtORjbzRrMsNsybHP0MwjNZLtR4AiWHgBG3hJtDCfS3t/uEnGBFLoELEf84w4GTkEyq6A5KfOIPmZ2n2NE14ZdmrJYdKrAbIAbxQLI2AMNAFzt8XdF9LURJRcKwrNoefcN92rJmfSZyNJHIlit97tQ+pliWer+G1zBg/PEby+8ho5oEyEiE7MA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by MWHPR1101MB2352.namprd11.prod.outlook.com (2603:10b6:300:7e::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.12; Wed, 9 Feb 2022 13:57:05 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::98be:5506:5020:28a2]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::98be:5506:5020:28a2%4]) with mapi id 15.20.4975.011; Wed, 9 Feb 2022 13:57:05 +0000 Message-ID: <1ab6f6c4-7284-4ee4-8828-7bd9e98baccd@intel.com> Date: Wed, 9 Feb 2022 13:56:59 +0000 Subject: Re: [PATCH v2] net/memif: remove pointer deference before null check Content-Language: en-US To: Weiguo Li , CC: , "stable@dpdk.org" References: From: Ferruh Yigit X-User: ferruhy In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0226.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a6::15) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8a5c28ed-fb5e-4a51-1d03-08d9ebd40dcb X-MS-TrafficTypeDiagnostic: MWHPR1101MB2352:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:295; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: KbubmYdrn6npv5y2/cUzpnqGtwEFbSVs6EUwxq1bBvmjC55Lu+fLP2GYROTYIJmU+54KYUmZ58atovLhD3LlJ4DyOVGiG68FwPLN0xs25uQ8GAar0iYeFIKYDpgpfwcHG3UGoXrt0RxrjBSXMw9DnPxrHZosKybcpfYRLinKX1VyVsZcOPn4zK7ddwU8GKCDFcT5WZgn9JdtNj2MAA6B2r5cf7vPGiXvMZC2wZ3GhPqNT9Rw9K/F52OH1NTtgJ2vLaMj1M3DFj4w/suHNsuA0HkLKZ2EzhFv42ewF2z3R/lDBXjrW2/02CG4DfsAJP1DLghYeGyfes5nQ6LmHfxlrz0MLpCn8Z7nYmEf9VjHDeMGgXyofMzBnmtH923dXl+M32SUPJw63EXEXeNy5Q8i3SpgQ68Sk3w0Wawi2PnCVuVG6XNAk4IRoD7TCOB1USdKZgjLT6Uh09MOBnjcKOZIOrRGLjBgrWV9uuLqQtst6SRs79jQkc1Ig5rux+KbVIEQG8FeLOSRc1SeLCf8YoJW/fEkI5eLVLw4SUoSGfKVZ5rJ1UQ3riyOrZI+SzrYRexidTLfYxtJghGiYp504WcptxFK+Cm3MUzs65T7EEH0xWzc+eP4UhcQQOgobZCxLax3drD9C/rA5CtvAQJ9yXnl8oeN7AjWLqga0N2EPU+fcprrCnelv31VHAiHQCCfKPgZETmrhLXOdRPWerc6H2JYlQg6JoFhIFRadbvc33n+FOfgSzuuioCD3k+PT6LjICXN X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(6512007)(6486002)(55236004)(36756003)(82960400001)(53546011)(508600001)(31696002)(6666004)(4744005)(6506007)(4326008)(38100700002)(8676002)(2906002)(2616005)(26005)(66946007)(66476007)(5660300002)(316002)(44832011)(66556008)(31686004)(86362001)(186003)(8936002)(48020200001)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RjBJV1N0V0x0aUNsNHVNSnk5emFQV05YYTU1Y2NMcEV2SlFzTERNMEQ5OXky?= =?utf-8?B?Mmt6Slh6dm1LcUdvWUQxdlloTXpsZnY1RnpNNTJFeUlDMExuclZlSW1iYTFG?= =?utf-8?B?bExKMFBvWUIxZHpUNUkxVDRRbzVOZWhDbFJIWjBHZE02anlXbmMxOE5mVENw?= =?utf-8?B?Q0VhNVA5aWF6S1BzdDl4cEpudWlJUDBxdGpDOXhibUx3bFpIQ2RCT0tNRXQv?= =?utf-8?B?czQvZnJvY2twOWljLzVNMEJKQ3BvYXVzV1VMd1ozRUs2STJ1OEtqMENXTFZU?= =?utf-8?B?dzJMYzh4T2grWmxDaG1lOFJLNThYTkdyemQ3dVdXeDREUWV2aEI1MktwUUNk?= =?utf-8?B?NVdYcTNIVXhHd1FKTW9remlONVM1alJZeEJZcDRUR3hRRzdVMjFlMlkwdEhC?= =?utf-8?B?aG9XVzMxdFZCcGlER2ZWeEFJT2EyOVp6ekpERlJFTnp0RFZXSTQ1VkEvQ2hV?= =?utf-8?B?VmNUa0tLODE5RElxYkVTYjdnR2I2ZnY4QS9La0xsRThpUkthQUhhYmpsZjA0?= =?utf-8?B?SWp1R09JWlV6SzAzZzZ4dzJya2NYWjI1TkF2R3hwL1RnNk5BT3EzWDZEcGN3?= =?utf-8?B?QWZ4MzhBYXN2T0NlMlFaN3o2ZUJzUVBYVXduUjZrU3hnK2EzdXk4bjJjbTl0?= =?utf-8?B?elMzd0hIa3cvTkxzOG1qc2ZpMHhyNGVHMWlXOVRWT1E3UlNBaUtobFdwR2hH?= =?utf-8?B?K1VScU1qNnBvNFkyeGxqNlpIVzhNUzByLzkyQndjMHpWLzQvcUVGZ2dNRXps?= =?utf-8?B?U2ZWTEJHSWFQd3JzYmtMVVB1Nm9mRFFpeDJzSDRqdUhxWWNtUUxmWjBBQ25J?= =?utf-8?B?eFlTbjRscWdDNDdkUHZIR3Vaci9mMGdHeUxqUlVnWjN1cnl0ekhPdzQ0Qk1o?= =?utf-8?B?QTNML2V2b21KblYvYk9hbHJ3dG91OTF2dFBJVzNtMUo2WW1QNnFrK1BoUVFt?= =?utf-8?B?Z1VQN2MzQ3J1dnB5TW9GejNxWVpBenRmak9ld3ZEMjJWOHJsQTJvTy9hNDZT?= =?utf-8?B?ODdsNldGR2FpY05TTmVKMUZyZy9ZWFBhdVZ4SjdGMEVJOHE2WkU1VjBOS3JJ?= =?utf-8?B?V3l5UG9McTNOL1dFRmV3RXp6dEZQaS81c1VBd3RVWDNGOGN5TUNpMnJJamtK?= =?utf-8?B?U1BjKzUvVU1WY2NWeXNwOFlscXFvWFd1N2N4a0NpZjlDcm03TStabEpDeEI2?= =?utf-8?B?WWdxQmVhQ1p2K2s4SGU0a0ZKd0lYaUFhRWZ0RUZyb1dPMVk0dlNQOVR5Szl1?= =?utf-8?B?eHNoTFV0VlBZNU5JMFZxRVNHUkowRVphQWxBMERRWEFCSDlNR3RYR1BJNVhI?= =?utf-8?B?WGtNWkZwMHR0RlIwYmgvSzRpMTFqQmhnWWZNQjhoRGp3VDUraU9CSnB0bkRT?= =?utf-8?B?Z1NSRjNPYXpXenRhSGZDeGxLQ24waEtSdnQ2dVUzK3gvRWNRa0FsUmU0bXVo?= =?utf-8?B?YW1mMFMzWHF3OG9zc0pBd0FJS3psTUMxU0trbVFLdHBJOG5kbVhhRzFjTnQw?= =?utf-8?B?OHdWL1VBZExybVFPQURZY0d4djRSUFhORy83alRUdllYYktoQUxtRjZhajRy?= =?utf-8?B?Qkt3cWZHTTVMSWlkNWhhRUxINmEwSnNLQjJOajNicVFpNlQ2d2d3UHp0ZnZR?= =?utf-8?B?T1Irei9CWU1mVVlKSVlneFhLbkZ1bmNjQ2pZcU1IbHJyUnorMGdyUmpPVThE?= =?utf-8?B?QlMySTN1aUw5Q1gvWHpnRGUvUnlKZEQ2cEd1RHRmOUJybWdtSTZ0bUxVRzR0?= =?utf-8?B?eGptN2RBRzl1aFNHQ0VpWTVtZ3E0MEZUM0FGM2E2YlVwZ0RpMWtKRjJnZWlS?= =?utf-8?B?UmdiZTBjRkhjR0dscS94b1hIbno5K0lIS29ZaGZTU3dxTGM4eDJaOEl5dUh4?= =?utf-8?B?Z0ZGMllqUUZQcWlGQ3FSVGJaMXRIeFNVMTdGMzh1bGFnTkhjaUMxdWxNK1lB?= =?utf-8?B?bk5sMVFObEdCdW5BcktVcGk5QnR4aFpHQ1J2RlFWYmlJTmF3VFp1TEpZYmRq?= =?utf-8?B?UjRmZ0U1SVBvSmNCWkcvS2h4TGhCdU52aXpNQWJDaUhtVmowWVc4bUk4K0Jl?= =?utf-8?B?UWRhTVVJS3hIWXVKL2dMTnNVL0ZxTExKUUtEZHROdWI5QjZVaW4vWVc4RW8r?= =?utf-8?B?R1JheUFyYTNtNE5vQnNjVHJIK0t2eitYN2FSNndvQ1VPcVJHNHg1dDNwT1hF?= =?utf-8?Q?eIOKrEiLJBeF04N4zgRcQlo=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 8a5c28ed-fb5e-4a51-1d03-08d9ebd40dcb X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Feb 2022 13:57:05.0082 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: jHzzxtk+L7tYL2Re5R95Mu9+C8OOUlCxkSoDZoO+d6D6nKvvobSdI3lK7PVu9zgUYukLEbd2OboJ9Fe/CD9mhw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1101MB2352 X-OriginatorOrg: intel.com X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On 2/9/2022 7:39 AM, Weiguo Li wrote: > There are duplicates of assignment here, the one before null check > may cause a null pointer deference, so remove the previous one. > > Fixes: 09c7e63a71f9 ("net/memif: introduce memory interface PMD") > Cc: stable@dpdk.org > Signed-off-by: Weiguo Li Reviewed-by: Ferruh Yigit