On 11/26/19 4:37 PM, Jin Yu wrote:
> Coverity issue: 350592
> Fixes: c19beb3f38cd ("examples/vhost_blk: introduce vhost storage sample")
> Cc: stable@dpdk.org
>
> Signed-off-by: Jin Yu <jin.yu@intel.com>
> ---
> examples/vhost_blk/vhost_blk.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/examples/vhost_blk/vhost_blk.c b/examples/vhost_blk/vhost_blk.c
> index 3182a488b..ff2f138b3 100644
> --- a/examples/vhost_blk/vhost_blk.c
> +++ b/examples/vhost_blk/vhost_blk.c
> @@ -852,7 +852,7 @@ new_device(int vid)
>
> if (ctrlr->packed_ring) {
> /* for the reconnection */
> - ret = rte_vhost_get_vring_base_from_inflight(
> + rte_vhost_get_vring_base_from_inflight(
> ctrlr->bdev->vid, i,
> &blk_vq->last_avail_idx,
> &blk_vq->last_used_idx);
>
It may be safer to handle the error, isn't it?
Maxime
Coverity issue: 350592 Fixes: c19beb3f38cd ("examples/vhost_blk: introduce vhost storage sample") Cc: stable@dpdk.org Signed-off-by: Jin Yu <jin.yu@intel.com> --- examples/vhost_blk/vhost_blk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/vhost_blk/vhost_blk.c b/examples/vhost_blk/vhost_blk.c index 3182a488b..ff2f138b3 100644 --- a/examples/vhost_blk/vhost_blk.c +++ b/examples/vhost_blk/vhost_blk.c @@ -852,7 +852,7 @@ new_device(int vid) if (ctrlr->packed_ring) { /* for the reconnection */ - ret = rte_vhost_get_vring_base_from_inflight( + rte_vhost_get_vring_base_from_inflight( ctrlr->bdev->vid, i, &blk_vq->last_avail_idx, &blk_vq->last_used_idx); -- 2.17.2
add the assert to handle error. Coverity issue: 350592 Fixes: c19beb3f38cd ("examples/vhost_blk: introduce vhost storage sample") Cc: stable@dpdk.org Signed-off-by: Jin Yu <jin.yu@intel.com> --- v2 - add the error hander --- examples/vhost_blk/vhost_blk.c | 1 + 1 file changed, 1 insertion(+) diff --git a/examples/vhost_blk/vhost_blk.c b/examples/vhost_blk/vhost_blk.c index 3182a488b..e1036bf3a 100644 --- a/examples/vhost_blk/vhost_blk.c +++ b/examples/vhost_blk/vhost_blk.c @@ -856,6 +856,7 @@ new_device(int vid) ctrlr->bdev->vid, i, &blk_vq->last_avail_idx, &blk_vq->last_used_idx); + assert(ret == 0); blk_vq->avail_wrap_counter = blk_vq->last_avail_idx & (1 << 15); -- 2.17.2
On 11/27/19 1:16 PM, Jin Yu wrote:
> add the assert to handle error.
>
> Coverity issue: 350592
> Fixes: c19beb3f38cd ("examples/vhost_blk: introduce vhost storage sample")
> Cc: stable@dpdk.org
>
> Signed-off-by: Jin Yu <jin.yu@intel.com>
> ---
> v2 - add the error hander
> ---
> examples/vhost_blk/vhost_blk.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/examples/vhost_blk/vhost_blk.c b/examples/vhost_blk/vhost_blk.c
> index 3182a488b..e1036bf3a 100644
> --- a/examples/vhost_blk/vhost_blk.c
> +++ b/examples/vhost_blk/vhost_blk.c
> @@ -856,6 +856,7 @@ new_device(int vid)
> ctrlr->bdev->vid, i,
> &blk_vq->last_avail_idx,
> &blk_vq->last_used_idx);
> + assert(ret == 0);
>
> blk_vq->avail_wrap_counter = blk_vq->last_avail_idx &
> (1 << 15);
>
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Thanks,
Maxime
On 11/27/19 1:57 PM, Maxime Coquelin wrote:
>
>
> On 11/27/19 1:16 PM, Jin Yu wrote:
>> add the assert to handle error.
>>
>> Coverity issue: 350592
>> Fixes: c19beb3f38cd ("examples/vhost_blk: introduce vhost storage sample")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Jin Yu <jin.yu@intel.com>
>> ---
>> v2 - add the error hander
>> ---
>> examples/vhost_blk/vhost_blk.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/examples/vhost_blk/vhost_blk.c b/examples/vhost_blk/vhost_blk.c
>> index 3182a488b..e1036bf3a 100644
>> --- a/examples/vhost_blk/vhost_blk.c
>> +++ b/examples/vhost_blk/vhost_blk.c
>> @@ -856,6 +856,7 @@ new_device(int vid)
>> ctrlr->bdev->vid, i,
>> &blk_vq->last_avail_idx,
>> &blk_vq->last_used_idx);
>> + assert(ret == 0);
>>
>> blk_vq->avail_wrap_counter = blk_vq->last_avail_idx &
>> (1 << 15);
>>
>
> Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
>
> Thanks,
> Maxime
>
Applied to dpdk-next-virtio/master.
Thanks,
Maxime