patches for DPDK stable branches
 help / color / Atom feed
* [dpdk-stable] [dpdk-dev] [PATCH v2] test-pmd: fix memory leaks when mtr policer actions update fails
@ 2020-05-25  1:46 wangyunjian
  2020-05-25  6:51 ` Thomas Monjalon
  2020-05-27 22:57 ` Ferruh Yigit
  0 siblings, 2 replies; 7+ messages in thread
From: wangyunjian @ 2020-05-25  1:46 UTC (permalink / raw)
  To: dev; +Cc: jerry.lilijun, xudingke, Yunjian Wang, stable

From: Yunjian Wang <wangyunjian@huawei.com>

This patch fixes the Huawei internal coverity reported
resource leak issue.

Fixes: e63b50162aa3 ("app/testpmd: clean metering and policing commands")
Cc: stable@dpdk.org

Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>
---
v2:
 * Update commit log
---
 app/test-pmd/cmdline_mtr.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/app/test-pmd/cmdline_mtr.c b/app/test-pmd/cmdline_mtr.c
index caa7e9864..ee16244de 100644
--- a/app/test-pmd/cmdline_mtr.c
+++ b/app/test-pmd/cmdline_mtr.c
@@ -1262,6 +1262,7 @@ static void cmd_set_port_meter_policer_action_parsed(void *parsed_result,
 	ret = rte_mtr_policer_actions_update(port_id, mtr_id,
 		action_mask, actions, &error);
 	if (ret != 0) {
+		free(actions);
 		print_err_msg(&error);
 		return;
 	}
-- 
2.23.0



^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [dpdk-stable] [dpdk-dev] [PATCH v2] test-pmd: fix memory leaks when mtr policer actions update fails
  2020-05-25  1:46 [dpdk-stable] [dpdk-dev] [PATCH v2] test-pmd: fix memory leaks when mtr policer actions update fails wangyunjian
@ 2020-05-25  6:51 ` Thomas Monjalon
  2020-05-26  2:04   ` wangyunjian
  2020-05-27 22:57 ` Ferruh Yigit
  1 sibling, 1 reply; 7+ messages in thread
From: Thomas Monjalon @ 2020-05-25  6:51 UTC (permalink / raw)
  To: wangyunjian
  Cc: dev, stable, jerry.lilijun, xudingke, Yunjian Wang, stable,
	cristian.dumitrescu

25/05/2020 03:46, wangyunjian:
> From: Yunjian Wang <wangyunjian@huawei.com>
> 
> This patch fixes the Huawei internal coverity reported
> resource leak issue.

The problem is not seen in the community Coverity?


> Fixes: e63b50162aa3 ("app/testpmd: clean metering and policing commands")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>
> ---
> v2:
>  * Update commit log

Please, next time, use --in-reply-to to keep v1 and v2 in the same thread.



^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [dpdk-stable] [dpdk-dev] [PATCH v2] test-pmd: fix memory leaks when mtr policer actions update fails
  2020-05-25  6:51 ` Thomas Monjalon
@ 2020-05-26  2:04   ` wangyunjian
  2020-05-26  7:13     ` Thomas Monjalon
  0 siblings, 1 reply; 7+ messages in thread
From: wangyunjian @ 2020-05-26  2:04 UTC (permalink / raw)
  To: Thomas Monjalon
  Cc: dev, stable, Lilijun (Jerry), xudingke, cristian.dumitrescu

> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> Sent: Monday, May 25, 2020 2:51 PM
> To: wangyunjian <wangyunjian@huawei.com>
> Cc: dev@dpdk.org; stable@dpdk.org; Lilijun (Jerry) <jerry.lilijun@huawei.com>;
> xudingke <xudingke@huawei.com>; wangyunjian <wangyunjian@huawei.com>;
> stable@dpdk.org; cristian.dumitrescu@intel.com
> Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v2] test-pmd: fix memory leaks
> when mtr policer actions update fails
> 
> 25/05/2020 03:46, wangyunjian:
> > From: Yunjian Wang <wangyunjian@huawei.com>
> >
> > This patch fixes the Huawei internal coverity reported resource leak
> > issue.
> 
> The problem is not seen in the community Coverity?

I don't know much about that.

> 
> 
> > Fixes: e63b50162aa3 ("app/testpmd: clean metering and policing
> > commands")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>
> > ---
> > v2:
> >  * Update commit log
> 
> Please, next time, use --in-reply-to to keep v1 and v2 in the same thread.

OK, thanks.

> 


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [dpdk-stable] [dpdk-dev] [PATCH v2] test-pmd: fix memory leaks when mtr policer actions update fails
  2020-05-26  2:04   ` wangyunjian
@ 2020-05-26  7:13     ` Thomas Monjalon
  2020-05-27  2:10       ` wangyunjian
  0 siblings, 1 reply; 7+ messages in thread
From: Thomas Monjalon @ 2020-05-26  7:13 UTC (permalink / raw)
  To: wangyunjian
  Cc: dev, stable, Lilijun (Jerry),
	xudingke, cristian.dumitrescu, john.mcnamara

26/05/2020 04:04, wangyunjian:
> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> > 25/05/2020 03:46, wangyunjian:
> > > From: Yunjian Wang <wangyunjian@huawei.com>
> > >
> > > This patch fixes the Huawei internal coverity reported resource leak
> > > issue.
> > 
> > The problem is not seen in the community Coverity?
> 
> I don't know much about that.

Please, could you register and check here?
https://scan.coverity.com/projects/dpdk-data-plane-development-kit




^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [dpdk-stable] [dpdk-dev] [PATCH v2] test-pmd: fix memory leaks when mtr policer actions update fails
  2020-05-26  7:13     ` Thomas Monjalon
@ 2020-05-27  2:10       ` wangyunjian
  2020-05-27  8:05         ` Thomas Monjalon
  0 siblings, 1 reply; 7+ messages in thread
From: wangyunjian @ 2020-05-27  2:10 UTC (permalink / raw)
  To: Thomas Monjalon
  Cc: dev, stable, Lilijun (Jerry),
	xudingke, cristian.dumitrescu, john.mcnamara

> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> Sent: Tuesday, May 26, 2020 3:14 PM
> To: wangyunjian <wangyunjian@huawei.com>
> Cc: dev@dpdk.org; stable@dpdk.org; Lilijun (Jerry) <jerry.lilijun@huawei.com>;
> xudingke <xudingke@huawei.com>; cristian.dumitrescu@intel.com;
> john.mcnamara@intel.com
> Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v2] test-pmd: fix memory leaks
> when mtr policer actions update fails
> 
> 26/05/2020 04:04, wangyunjian:
> > From: Thomas Monjalon [mailto:thomas@monjalon.net]
> > > 25/05/2020 03:46, wangyunjian:
> > > > From: Yunjian Wang <wangyunjian@huawei.com>
> > > >
> > > > This patch fixes the Huawei internal coverity reported resource
> > > > leak issue.
> > >
> > > The problem is not seen in the community Coverity?
> >
> > I don't know much about that.
> 
> Please, could you register and check here?
> https://scan.coverity.com/projects/dpdk-data-plane-development-kit

OK, I have registered, but I do not find this issue in it.
Thanks,
Yunjian

> 
> 


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [dpdk-stable] [dpdk-dev] [PATCH v2] test-pmd: fix memory leaks when mtr policer actions update fails
  2020-05-27  2:10       ` wangyunjian
@ 2020-05-27  8:05         ` Thomas Monjalon
  0 siblings, 0 replies; 7+ messages in thread
From: Thomas Monjalon @ 2020-05-27  8:05 UTC (permalink / raw)
  To: wangyunjian
  Cc: dev, stable, Lilijun (Jerry),
	xudingke, cristian.dumitrescu, john.mcnamara

27/05/2020 04:10, wangyunjian:
> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> > 26/05/2020 04:04, wangyunjian:
> > > From: Thomas Monjalon [mailto:thomas@monjalon.net]
> > > > 25/05/2020 03:46, wangyunjian:
> > > > > From: Yunjian Wang <wangyunjian@huawei.com>
> > > > >
> > > > > This patch fixes the Huawei internal coverity reported resource
> > > > > leak issue.
> > > >
> > > > The problem is not seen in the community Coverity?
> > >
> > > I don't know much about that.
> > 
> > Please, could you register and check here?
> > https://scan.coverity.com/projects/dpdk-data-plane-development-kit
> 
> OK, I have registered, but I do not find this issue in it.

Thanks for having check.




^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [dpdk-stable] [dpdk-dev] [PATCH v2] test-pmd: fix memory leaks when mtr policer actions update fails
  2020-05-25  1:46 [dpdk-stable] [dpdk-dev] [PATCH v2] test-pmd: fix memory leaks when mtr policer actions update fails wangyunjian
  2020-05-25  6:51 ` Thomas Monjalon
@ 2020-05-27 22:57 ` Ferruh Yigit
  1 sibling, 0 replies; 7+ messages in thread
From: Ferruh Yigit @ 2020-05-27 22:57 UTC (permalink / raw)
  To: wangyunjian, dev; +Cc: jerry.lilijun, xudingke, stable

On 5/25/2020 2:46 AM, wangyunjian wrote:
> From: Yunjian Wang <wangyunjian@huawei.com>
> 
> This patch fixes the Huawei internal coverity reported
> resource leak issue.
> 
> Fixes: e63b50162aa3 ("app/testpmd: clean metering and policing commands")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>

Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>

Updating commit log as following:

"
    app/testpmd: fix memory leaks on error path

    This patch fixes the resource leak issue.

    Fixes: e63b50162aa3 ("app/testpmd: clean metering and policing commands")
    Cc: stable@dpdk.org
"

1) Updated patch title
2) Removed reference to internal coverity, since others can't access it, this
information doesn't add value


Applied to dpdk-next-net/master, thanks.

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, back to index

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-25  1:46 [dpdk-stable] [dpdk-dev] [PATCH v2] test-pmd: fix memory leaks when mtr policer actions update fails wangyunjian
2020-05-25  6:51 ` Thomas Monjalon
2020-05-26  2:04   ` wangyunjian
2020-05-26  7:13     ` Thomas Monjalon
2020-05-27  2:10       ` wangyunjian
2020-05-27  8:05         ` Thomas Monjalon
2020-05-27 22:57 ` Ferruh Yigit

patches for DPDK stable branches

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ http://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/ public-inbox