From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id 97E431E2F for ; Mon, 29 Oct 2018 14:12:33 +0100 (CET) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20181029131232euoutp012a7d2a6f79d3d9571936aebf39e762f1~iFn3NcYm11270112701euoutp01J for ; Mon, 29 Oct 2018 13:12:32 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20181029131232euoutp012a7d2a6f79d3d9571936aebf39e762f1~iFn3NcYm11270112701euoutp01J DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1540818752; bh=iBlV4dsmR3ZpNERTl10+oWYCbrx1d8sHCVlRr5MrOIg=; h=Subject:To:Cc:From:Date:In-Reply-To:References:From; b=L8x5qwl1gJRvDvfRQwl35BNXPkuZlTQJlcSEW9tuE6n2niO1vdVE1Vsrp8fFJwl+H SfBwKpywfjuRtC9umf3AvEYzINw6JhQyzG6Nnc0EMsVWKYZhvZTM7gHYSrEkFrdZd6 CUlPIRD29E5nSLb5CY3bcLmuBLhlMRNyk0sus8MY= Received: from eusmges3new.samsung.com (unknown [203.254.199.245]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20181029131231eucas1p105c888fa2e6955176d1d2b4385bf9a7a~iFn2s2-BT2408924089eucas1p1D; Mon, 29 Oct 2018 13:12:31 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges3new.samsung.com (EUCPMTA) with SMTP id A5.FE.04806.F3707DB5; Mon, 29 Oct 2018 13:12:31 +0000 (GMT) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20181029131230eucas1p1ec39f5b89a5e3cdaf394663786568daa~iFn19zc_42815228152eucas1p1B; Mon, 29 Oct 2018 13:12:30 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20181029131230eusmtrp21cf62236f393031ae41c15908965d04c~iFn1tz4tP1196511965eusmtrp2B; Mon, 29 Oct 2018 13:12:30 +0000 (GMT) X-AuditID: cbfec7f5-367ff700000012c6-ab-5bd7073fb671 Received: from eusmtip2.samsung.com ( [203.254.199.222]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id CC.EF.04284.E3707DB5; Mon, 29 Oct 2018 13:12:30 +0000 (GMT) Received: from [106.109.129.180] (unknown [106.109.129.180]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20181029131230eusmtip2de4fe5266755287690c7f339695337fb~iFn1XcyT-1862418624eusmtip2S; Mon, 29 Oct 2018 13:12:30 +0000 (GMT) To: Luca Boccassi , Maxime Coquelin Cc: dpdk stable From: Ilya Maximets Message-ID: <1d025844-5d3b-40d0-25c0-221bedf0a252@samsung.com> Date: Mon, 29 Oct 2018 16:12:25 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <20181029125329.17729-3-bluca@debian.org> Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprGKsWRmVeSWpSXmKPExsWy7djPc7r27NejDeZvFbCY07SO3eJK+092 i2Ode1gs/nX8YXdg8fjVNpfZ49eCpawe7/ddZfPo27KKMYAlissmJTUnsyy1SN8ugSujbcpr poLp4hXPDp1mbGCcL9TFyMkhIWAiseLbPMYuRi4OIYEVjBJHbq+Dcr4wSrRPvs4GUiUk8JlR 4uRxYZiOjgmbWSCKljNKXDrdyAzhfGSU+LDnAztIlbBAnMTOBy+YQWwRgRCJp8cmsoDYzAKK Eu0zullBbDYBHYlTq48wgti8AnYSvzbPBYuzCKhKNJ6+BVYvKhAh0XF/NRtEjaDEyZlPwOKc AmYSM5afZIeYKS7R9GUlK4QtL7H97RywgyQE+tklZk3qBXI4gBwXibXfnSA+EJZ4dXwLO4Qt I/F/53wmCLte4n7LS0aI3g5GiemH/kEl7CW2vD7HDjKHWUBTYv0ufYiwo0TTuSksEOP5JG68 FYQ4gU9i0rbpUFt5JTraoCGtIvH74HJmCFtK4ua7z+wTGJVmIXlsFpJnZiF5ZhbC3gWMLKsY xVNLi3PTU4uN81LL9YoTc4tL89L1kvNzNzECU8vpf8e/7mDc9yfpEKMAB6MSD+8D7mvRQqyJ ZcWVuYcYJTiYlUR4X50FCvGmJFZWpRblxxeV5qQWH2KU5mBREuddNm9jtJBAemJJanZqakFq EUyWiYNTqoHRY8Nevz6+VhWxVa8TqqamnOT3+s+44dG8hxe073Fufv/If9LL2TK+t0vSXJ8+ V/2lfOrl3AsHF5skPOFeG3ZjxZ/lWlfWHGYpkQy0DJS6HT37+qGj36L1IsQVvZ+93C0dav1h 6fK57gtS8hcwPwvbdfe+fxJL9/ZfDAoLLBnuq70wPr9aoDhorxJLcUaioRZzUXEiACFG52Qp AwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrFIsWRmVeSWpSXmKPExsVy+t/xe7p27NejDSZskLGY07SO3eJK+092 i2Ode1gs/nX8YXdg8fjVNpfZ49eCpawe7/ddZfPo27KKMYAlSs+mKL+0JFUhI7+4xFYp2tDC SM/Q0kLPyMRSz9DYPNbKyFRJ384mJTUnsyy1SN8uQS+jbcprpoLp4hXPDp1mbGCcL9TFyMkh IWAi0TFhMwuILSSwlFFicXcURFxK4sevC6wQtrDEn2tdbF2MXEA17xklDi5qYAJJCAvESex8 8IIZxBYRCJGYufgnO4jNLKAo0T6jmxWi4SGjxLF368AmsQnoSJxafYQRxOYVsJP4tXkuWJxF QFWi8fQtsCtEBSIkzr5cB1UjKHFy5hOwOKeAmcSM5SehFqhL/Jl3iRnCFpdo+rKSFcKWl9j+ dg7zBEahWUjaZyFpmYWkZRaSlgWMLKsYRVJLi3PTc4sN9YoTc4tL89L1kvNzNzEC42nbsZ+b dzBe2hh8iFGAg1GJh/cB97VoIdbEsuLK3EOMEhzMSiK8r84ChXhTEiurUovy44tKc1KLDzGa Aj03kVlKNDkfGOt5JfGGpobmFpaG5sbmxmYWSuK85w0qo4QE0hNLUrNTUwtSi2D6mDg4pRoY mTuKsr9t5Z9wi2/LLq6Fdlp9La3P5W5WNs7IdtjU/8xsf6HgsgrN1Hmpkz9aeG26rut6wMqh cZ/QtYr+972hqlZC2nMeOR2qOftPwd6sPOz4Yduw6O2ph/kPri2P0lHXk+LbdinF0sdh7VTL kCX65RrdfzzYZ9Yo5W75mM61/XbIj92b2hOVWIozEg21mIuKEwHtKxTIvQIAAA== X-CMS-MailID: 20181029131230eucas1p1ec39f5b89a5e3cdaf394663786568daa X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-RootMTR: 20181029125428epcas4p394a48c1ce3fa22687c026f451751045e X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20181029125428epcas4p394a48c1ce3fa22687c026f451751045e References: <20181015115144.27626-1-bluca@debian.org> <20181029125329.17729-1-bluca@debian.org> <20181029125329.17729-3-bluca@debian.org> Subject: Re: [dpdk-stable] patch 'vhost: fix payload size of reply' has been queued to LTS release 16.11.9 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Oct 2018 13:12:33 -0000 Hi, I'm not sure if we need to backport this change because sending the payload doesn't cause any issues in current QEMU implementation. Anyway, If you want to do that, the change should be done like this (and some comments merge will be needed): --- diff --git a/lib/librte_vhost/vhost_user.c b/lib/librte_vhost/vhost_user.c index 04c92ceb3..44b792420 100644 --- a/lib/librte_vhost/vhost_user.c +++ b/lib/librte_vhost/vhost_user.c @@ -1114,7 +1114,7 @@ vhost_user_msg_handler(int vid, int fd) vhost_user_set_log_base(dev, &msg); /* it needs a reply */ - msg.size = sizeof(msg.payload.u64); + msg.size = 0; send_vhost_message(fd, &msg); break; case VHOST_USER_SET_LOG_FD: --- This is because before commit e951355ffcae ("vhost: make message handling functions prepare the reply") replies was handled in-place by the caller function. Best regards, Ilya Maximets. On 29.10.2018 15:53, Luca Boccassi wrote: > Hi, > > FYI, your patch has been queued to LTS release 16.11.9 > > Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. > It will be pushed if I get no objections before 10/31/18. So please > shout if anyone has objections. > > Also note that after the patch there's a diff of the upstream commit vs the patch applied > to the branch. If the code is different (ie: not only metadata diffs), due for example to > a change in context or macro names, please double check it. > > Thanks. > > Luca Boccassi > > --- >>>From 2fb95d184bf2b7715c9e2696059d41fd044a2d88 Mon Sep 17 00:00:00 2001 > From: Maxime Coquelin > Date: Fri, 12 Oct 2018 14:40:32 +0200 > Subject: [PATCH] vhost: fix payload size of reply > > [ upstream commit 57b4d90b5893db2678ca3e28c50e1fcd37bb9b91 ] > > QEMU doesn't expect any payload for the reply of > VHOST_USER_SET_LOG_BASE request, so don't send any. > Note that the Vhost-user specification isn't clear about > it and would need to be fixed. > > Fixes: 54f9e32305d4 ("vhost: handle dirty pages logging request") > > Reported-by: Ilya Maximets > Signed-off-by: Maxime Coquelin > Acked-by: Ilya Maximets > --- > lib/librte_vhost/vhost_user.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/lib/librte_vhost/vhost_user.c b/lib/librte_vhost/vhost_user.c > index f3b286e72..a88f19aae 100644 > --- a/lib/librte_vhost/vhost_user.c > +++ b/lib/librte_vhost/vhost_user.c > @@ -911,6 +911,12 @@ vhost_user_set_log_base(struct virtio_net *dev, struct VhostUserMsg *msg) > dev->log_base = dev->log_addr + off; > dev->log_size = size; > > + /* > + * The spec is not clear about it (yet), but QEMU doesn't expect > + * any payload in the reply. > + */ > + msg->size = 0; > + > return 0; > } > >