From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8655EA0C4E for ; Tue, 19 Oct 2021 14:25:51 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 714524118A; Tue, 19 Oct 2021 14:25:51 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id 5B8B8410F4; Tue, 19 Oct 2021 14:25:49 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10141"; a="215658529" X-IronPort-AV: E=Sophos;i="5.85,384,1624345200"; d="scan'208";a="215658529" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Oct 2021 05:25:48 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,384,1624345200"; d="scan'208";a="550788477" Received: from orsmsx605.amr.corp.intel.com ([10.22.229.18]) by fmsmga004.fm.intel.com with ESMTP; 19 Oct 2021 05:25:47 -0700 Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Tue, 19 Oct 2021 05:25:47 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Tue, 19 Oct 2021 05:25:47 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.175) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Tue, 19 Oct 2021 05:25:47 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KsYZ4uk2YdbXv2AJHW8XDMjH97csCE1DpJREdNPw53wNH0tN0Fty63DfEJ1hfrqcBmM9k90Y4og5Ongk+XogOwUiGvSLh6c0JRdgdg7ZL+9OC4MrekdNhSUo9ak/gFfC/2YcMblk8jBMOX4pnMUeua2kh0Uz9LYGRVvmg1kEhtqjOWf75jKNWSO7ZIxPehkjenkUdBIoqH2GC8OSjA0gjx/OlXydkPmkhxtlpHjLUymKpcT9B6nE74sEMvt63TzfDYESSgO58iMYWbTOOFyTcEdzpCyKv18AO5Enus2EayoTbNma/DP+roVvK630B9rZXj4M6So9RAt7slS6KYtWuA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+zsXjmAXAlthPRA44dE4hAHByaCw3axT+/orzK31A4g=; b=emU8Q3n6gQFlr5WDS0PB3RtJFFiI7eFrsXtY85w22Bi0YqJ7LNZ2TXC1jHfXRp1Ri5ymaZ4WwcWYjte7RjLm3HlOXAj4LviFS9nyAmJs6Vk+hn4WgSj1rM4IstcVTjiEnUFqyZYLGrz6md/MGnFz3Mhk1WsFiK/H9t7bIzYno5A5QJrIYjeqFlR+GaUuXBKKHQF2z34Cf6O6f5+gDfvypHedLQakHyaOJwS8E1ASH3Lu+FVVeebiS/imu0Rz+iQ72SGDDaGT07PA9I4QK4pE/8Q6vkB+HLBG9IRNSFZ0l/2yaLg0wNafMs+EEtYogrQymyjWb9IHazWC8ZCRLE6O0A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+zsXjmAXAlthPRA44dE4hAHByaCw3axT+/orzK31A4g=; b=skFrx35evjybdMMUQhV7s16lFS3ZM1BW2+OoccbvQyFvAQmQGbQ6mNMaR3BykuRbW8uya6GkSjdVJ9xZ8K3VaHXn3ENDgJd649VjF6kzYQP56/L/ASWgJGw9PH4a711yLcZu5VGh/XeSbgqrFF4FeTzIv1JTdShQAn2+umDHEQM= Authentication-Results: semihalf.com; dkim=none (message not signed) header.d=none;semihalf.com; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB4984.namprd11.prod.outlook.com (2603:10b6:510:34::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.17; Tue, 19 Oct 2021 12:25:45 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c%5]) with mapi id 15.20.4608.018; Tue, 19 Oct 2021 12:25:45 +0000 Message-ID: <1d7e93c7-bbc8-83f1-a5f4-abebc81dd486@intel.com> Date: Tue, 19 Oct 2021 13:25:39 +0100 Content-Language: en-US To: Michal Krawczyk CC: , , , , , References: <20211015162701.16324-1-mk@semihalf.com> <20211019105629.11731-1-mk@semihalf.com> <20211019105629.11731-4-mk@semihalf.com> From: Ferruh Yigit X-User: ferruhy In-Reply-To: <20211019105629.11731-4-mk@semihalf.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0392.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:18f::19) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by LO4P123CA0392.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:18f::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.14 via Frontend Transport; Tue, 19 Oct 2021 12:25:43 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: dedc122e-1946-44c7-08e6-08d992fb934e X-MS-TrafficTypeDiagnostic: PH0PR11MB4984: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7691; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: wYyTZs4enoOm4MoOcp1HZ9M5X/NqFW3Q3C3DNPsl2tQskU2PylflJc6Nzd+1xr3Z8wVV5sj6jsgyS+NMeRttV7zmZcvZUwjYTHRNxMncXmDbhmq3QtWCF3tLvMqBpfoWsuNi9Dv0rHnYt8vu3h52En6vZUxPwMjUG2cScgnd5g6hf/m9L85nIKaN5r4JQ24X38wswAv8WxOj6JmnIj8rQpzL8VXWNyKHy3xT4r+j4Md7XuUIIQ19OyN8Wr1JAfjQtWZI8pIgb/aEfoHhkRzM9vcy1ryQrG/Kb1Pt9TDtSHd8Cmo1zyA4bckropgvHKsCR7Q3lmxRmlEV++xeNXIwkJHGHTG5y1CacALU6OG0SAvB0z84h+COwLDsHJNDgk27s/73oixWERWq5sh9mHeWsKiK5wN5vjveaIw2/n4gJ0zvzfHgfuJMvV9I14MSORNQe9AE9RI3JIxdAWV00bCI1SQbQiCtpo5XC09k1tP5dkysAD6YMPdZON6dVSz10LxuQl+/y2P3RxSUXvwfyYXYA4IdUajG8fM8gFekqqjZvQjmSDaXLArGEcFdchrK01MPLHG7pgMm7v7GlZoZ56d+rGSHxV9u9vxvreRd+PQf/z/bsz/7qv42TMeQ90vBaQvSVZMxRW2dfAc0BuPYot9fYuwx7Iwl4vh4pJv8VY6E+Z2RyWGMGrl/9HgK3goHtS1cnB4fzxUGE3kZ7FUadwK9xvBo7Osa9QuYPa71fNlXCwzbaW80DZwlf9ju65YGNMREqxWIpNEg51kofr9mGME3+1lF4BHp0W3NmeHp6CUpy2U= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(26005)(44832011)(6486002)(83380400001)(6916009)(66946007)(82960400001)(186003)(2616005)(36756003)(31696002)(31686004)(86362001)(6666004)(66556008)(16576012)(66476007)(38100700002)(966005)(508600001)(316002)(8676002)(4326008)(2906002)(53546011)(5660300002)(956004)(8936002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aGNURzg1bXMwVU05WTIxVUg3cCtDYjdoRUhKUVBSajVQVlZpYlJaTDdJd2du?= =?utf-8?B?MWMxUEZEa09RaUFMVlFJK2N0OGg0MHc0RmNWUFBPMzNneXdBbXRYSEdOZzkv?= =?utf-8?B?QXRVTUhHN0JlUXc2eEcyS0g5OUo4c3pBOXhzYnROMVRmaW40RXIwN0dReHBJ?= =?utf-8?B?WnpBc2E2MDNTaVRteXZDR1g1S2REdU1qRzA2MC9BMWhuTzRmSjF0YUYyTmdV?= =?utf-8?B?Q0lQRzcwUEZ4NElhb0R4cWhNMC9MR1Q5L01vL3FPNjk5UkhnSG9odHhXSE52?= =?utf-8?B?YllnTEJzc2tLTkdHK3UvMXIvYU84bFAwSEhnQVpNUU5PT3QvcENZdnBEQ05U?= =?utf-8?B?NzlLQWZ4OU42NXVGa0JGMEtwdjlTeEM2cGJmWHJDMExkeGZ0UTQxZU1xSVNs?= =?utf-8?B?VUYwTFFKMGg2aHlTaE9hcytFQ1R5eGlKRXdiYXhvYnVBUVgyQzFmQWluNzZw?= =?utf-8?B?aW9HZjNGWkxhdnBUNU5UVEI5SnVnMWRHdDBXSDNZbnNKc0ttaG1ubVFVeXFW?= =?utf-8?B?NTQ0MTdBWFRMTjV2UHhGRTZsdXJqWE1zWXFEbXowaHBuWUt3ZFpycUJlN1lO?= =?utf-8?B?V2RTV3NPcTdubXBZNHNnVlpST1VSbFN6V0t4ZGlSTlRwaUdKbGVCckZLZHhG?= =?utf-8?B?VmlWY3RUaGFieXhoZmVBbjFxTVVRYVorVWwyUEljM0VCNWR4Q2dYdVA4ZnhK?= =?utf-8?B?Y1NERUNOcWNTUmZubTJiTmIzT0Y4eXlpSnFrQUlrMXA2V2tFdzBieEVLcTNE?= =?utf-8?B?ZHBrRjJqakVYTVlXZWJWazFXcy9rQnhBK3o5YVZkc3ArNjRzVXN2TXNndHJr?= =?utf-8?B?anRpN2ZBb1ZMT3BXQWlKUXZlS1ZVRlRhL2Y5WExkQ0Zta0hrVWNKSWlCWGhh?= =?utf-8?B?NENDcHVmZmdkTTJQZ0MvTG5GY2FBZ2FSN0NMSWN5RjlBU01EMytRazdXN3dD?= =?utf-8?B?QzZqbTZXYWpZcEh3VTVNYThxMWtiZGs0dm12ZVFXWTN6ejkzWlJVL0hRdW1L?= =?utf-8?B?S1RaeDFhVThMaUZjdTFPa0xpRFRtcXlsTUtHMXczMTZCTGNTQ0VodnBkN3hO?= =?utf-8?B?UGdualVRMnhFdVFrZnRXUlpLVkRnVFJKTXFPMHplSVg4QjQwdnNTZ0lNNXRN?= =?utf-8?B?UnNEZVhSTWJzdGtiYTVzaHE3NENRM3pva3ExbTRMeXNEakZHcjlLUTR4RjlM?= =?utf-8?B?NXdTNXlCaEhPenZYeFRRb09OMmtwWVdvRmdCOHowWUVJK3J2UnVGQkQ5S0lC?= =?utf-8?B?blhNd2NXM0ZaVzBvRHBzd2RodExCbzdzeUcxZ1RpNG1kQy9PMW1sbXMwSkdl?= =?utf-8?B?cVVid1dvbm5EMkpybFlkMjJnc0VDcHNJNHhsdmsyRk4valM4M0VRSXoxdlkv?= =?utf-8?B?Z1IxcmVQMEg3bXFIMG0yZ1NBRndjT0k1WGx3b3ZhKzBjNVhyamdHWml2amY2?= =?utf-8?B?QkxGbEVTZmowUEpHSnpwVk9ETDB0ck11dFU2TzZPWnh5cDNhL0trM1ZiKzI0?= =?utf-8?B?RWNNdkxmOTcxWlBKRG9GSTNKaXJUWHgwRWVZRjZ4aytZS0g3ZGdFZWVmTjdU?= =?utf-8?B?ZHpKL1UwaGdRTU5ZUWJDY2RoelpEUE5PUTMwNnRocGNVSlcybHVUV3YvbnVv?= =?utf-8?B?aEhRT1FXd1IyMG0ydzJaMUx2UFA3eXdCWS9kbHBlQm1sK2NRVkRlQ1ptWWtJ?= =?utf-8?B?QjdyS1hQVlpDbG1EU2l4eE9tdkJDNU4vNlhQL2tjMGxsNFphVTJXK1hORllK?= =?utf-8?Q?DrxPjZiiqgwuHj+B2cvtviRLn1Hs8qYh3HoA3V6?= X-MS-Exchange-CrossTenant-Network-Message-Id: dedc122e-1946-44c7-08e6-08d992fb934e X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Oct 2021 12:25:45.8045 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: DTPZpepBfODM9eZxz8FneX8BTQZDgaECpiHKU3GI6phzJRofvHTCt2iqNMisK8onpaaqC9XynMvne9eGKytjNw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4984 X-OriginatorOrg: intel.com Subject: Re: [dpdk-stable] [PATCH v3 3/7] net/ena: fix per-queue offload capabilities X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On 10/19/2021 11:56 AM, Michal Krawczyk wrote: > PMD shouldn't advertise the same offloads as both per-queue and > per-port [1]. Each offload capability should go either to the > [rt]x_queue_offload_capa or [rt]x_offload_capa. > This is not exactly true. It is expected that queue offloads advertised as part of port offloads too. The logic is, if any offload can be applied in queue granularity it can be applied to all queues which becomes port offload. In document: Port capabilities = per-queue capabilities + pure per-port capabilities. There is a difference between "pure per-port capability" and "port capability", this may be source of the confusion. Since driver doesn't support queue specific offloads, code is not wrong, I will remove above paragraph and merge the patch, if you have objection or change request, please let me know, I can update in next-net. > As ENA currently doesn't support offloads which could be configured > per-queue, only per-port flags should be set. > > In addition, to make the code cleaner, parsing appropriate offload > flags is encapsulated into helper functions, in a similar matter it's > done by the other PMDs. > > [1] https://doc.dpdk.org/guides/prog_guide/ > poll_mode_drv.html?highlight=offloads#hardware-offload > > Fixes: 7369f88f88c0 ("net/ena: convert to new Rx offloads API") > Fixes: 56b8b9b7e5d2 ("net/ena: convert to new Tx offloads API") > Cc: stable@dpdk.org > > Signed-off-by: Michal Krawczyk > Reviewed-by: Igor Chauskin > Reviewed-by: Shai Brandes <...>