From: Ferruh Yigit <ferruh.yigit@intel.com>
To: "Doherty, Declan" <declan.doherty@intel.com>,
Matan Azrad <matan@mellanox.com>
Cc: dev@dpdk.org, stable@dpdk.org, Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [dpdk-stable] [PATCH] net/bonding: fix slave activation simultaneously
Date: Mon, 14 May 2018 13:41:30 +0100 [thread overview]
Message-ID: <1dfd3e27-9870-8851-cf92-7b4e36c49154@intel.com> (raw)
In-Reply-To: <0aad672c-210a-db8c-53f3-98660fe17f1d@intel.com>
On 5/14/2018 12:45 PM, Doherty, Declan wrote:
> On 24/04/2018 12:29 PM, Matan Azrad wrote:
>> The bonding PMD decides to activate\deactivate its slaves according to
>> the slaves link statuses.
>> Thus, it registers to the LSC events of the slaves ports and
>> activates\deactivates them from its LSC callbacks called asynchronously
>> by the host thread when the slave link status is changed.
>>
>> In addition, the bonding PMD uses the callback for slave activation
>> when it tries to start it, this operation is probably called by the
>> master thread.
>>
>> Consequently, a slave may be activated in the same time by two
>> different threads and may cause a lot of optional errors, for example,
>> slave mempool recreation with the same name causes an error.
>>
>> Synchronize the critical section in the LSC callback using a special
>> new spinlock.
>>
>> Fixes: 414b202343ce ("bonding: fix initial link status of slave")
>> Fixes: a45b288ef21a ("bond: support link status polling")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Matan Azrad <matan@mellanox.com>
>> ---
> ...
>>
>
> Acked-by: Declan Doherty <declan.doherty@intel.com>
>
Applied to dpdk-next-net/master, thanks.
next prev parent reply other threads:[~2018-05-14 12:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-24 11:29 Matan Azrad
2018-05-14 2:07 ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon
2018-05-14 11:45 ` [dpdk-stable] " Doherty, Declan
2018-05-14 12:41 ` Ferruh Yigit [this message]
2018-05-14 15:01 ` [dpdk-stable] [dpdk-dev] " Chas Williams
2018-05-15 8:24 ` Matan Azrad
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1dfd3e27-9870-8851-cf92-7b4e36c49154@intel.com \
--to=ferruh.yigit@intel.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=matan@mellanox.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).