From: Kevin Traynor <ktraynor@redhat.com>
To: "Power, Ciara" <ciara.power@intel.com>,
"Zhang, AlvinX" <alvinx.zhang@intel.com>,
"christian.ehrhardt@canonical.com"
<christian.ehrhardt@canonical.com>,
"Chen, LingliX" <linglix.chen@intel.com>,
"Jiang, YuX" <yux.jiang@intel.com>,
"Van Haaren, Harry" <harry.van.haaren@intel.com>
Cc: "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [PATCH v4] telemetry: fix race in telemetry control thread creation
Date: Tue, 13 Jul 2021 14:44:37 +0100 [thread overview]
Message-ID: <1e663aa8-782b-e711-ecf7-ae3253c9f7ae@redhat.com> (raw)
In-Reply-To: <MN2PR11MB3821C9C53C99C4B528808B87E6149@MN2PR11MB3821.namprd11.prod.outlook.com>
On 13/07/2021 14:31, Power, Ciara wrote:
> Hi Alvin,
>
>> -----Original Message-----
>> From: Zhang, AlvinX <alvinx.zhang@intel.com>
>> Sent: Tuesday 13 July 2021 07:42
>> To: christian.ehrhardt@canonical.com; Chen, LingliX <linglix.chen@intel.com>;
>> Jiang, YuX <yux.jiang@intel.com>; Power, Ciara <ciara.power@intel.com>; Van
>> Haaren, Harry <harry.van.haaren@intel.com>
>> Cc: Zhang, AlvinX <alvinx.zhang@intel.com>; stable@dpdk.org
>> Subject: [PATCH v4] telemetry: fix race in telemetry control thread creation
>>
>> Before the caller returns from function "rte_ctrl_thread_create", the newly
>> created thread may have ran, and because the thread control flag was not set
>> before, the new thread may exit soon.
>> This is not what the developer expected.
>>
>> This patch puts the setting thread control flag to the place that before creating
>> new thread.
>>
>> Reported-at: https://bugs.dpdk.org/show_bug.cgi?id=731
>> Fixes: 8877ac688b52 ("telemetry: introduce infrastructure")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Alvin Zhang <alvinx.zhang@intel.com>
>> ---
>>
> <snip>
>
> Thanks for this, I guess it is targeted towards both 18.11 and 19.11 stable releases?
18.11 LTS is no longer maintained, so it would just be a candidate for
19.11 but I guess that was the intent looking at the Bz.
> This file was removed in 20.11 so won't be needed there.
>
> Acked-by: Ciara Power <ciara.power@intel.com>
>
>
prev parent reply other threads:[~2021-07-13 13:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-13 6:41 Alvin Zhang
2021-07-13 13:31 ` Power, Ciara
2021-07-13 13:44 ` Kevin Traynor [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1e663aa8-782b-e711-ecf7-ae3253c9f7ae@redhat.com \
--to=ktraynor@redhat.com \
--cc=alvinx.zhang@intel.com \
--cc=christian.ehrhardt@canonical.com \
--cc=ciara.power@intel.com \
--cc=harry.van.haaren@intel.com \
--cc=linglix.chen@intel.com \
--cc=stable@dpdk.org \
--cc=yux.jiang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).